PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
51 stars 21 forks source link

Custom Sapling growth stage #1572

Open Maroon28 opened 2 years ago

Maroon28 commented 2 years ago

Terms

Discord tag (optional)

Maroon#1461

Describe the solution you'd like

Currently, placing custom saplings makes them instantly grow into their tree forms. While this works, it's quite unrealistic and doesn't exactly fit well vanilla-wise. It'd be awesome if we can somehow let the saplings be placed down normally (no need to retain their texture or anything.), then when using bonemeal on it, it'd grow into a custom tree.

This could be achieved by keeping track of all custom placed saplings, and when interacted with using bonemeal it'd continue the growth process. Or maybe by injecting NBT data into the block, then checking for that nbt data when using a bonemeal.

Is your feature request related to a problem?

No. I wouldn't consider instant growth a problem

Describe alternatives you've considered

I tried to use the API to make an addon for this, but unfortunately it was limited when it came to trees.

Additional context

If this is a potentially laggy feature, we could add a config option to disable instant growth, which would take off a lot of the load.

Maroon28 commented 2 years ago

Hi @LoneDev6 ! Any idea if this will be implemented soon? Really looking forward to it!

LoneDev6 commented 2 years ago

Hello, it's not that easy currently, the only way to do that is using entities (like other plugins do) and this causes an insane amount of clientside FPS drop. For now I have no usable solution, I'll obviously implement that as soon as I find (or if Mojang introduces some features) a good way of doing that.

evilsaloon commented 1 year ago

I have a suggestion for this feature: Instead of keeping track of the growth phase and trying to emulate vanilla, let users set a delay for the tree populator/sapling action. This way, at least you will be able to set a certain amount of seconds/ticks for the tree to "grow", so it'll look a lot more natural, instead of just growing the tree instantly.

razorrider7 commented 1 year ago

I have a suggestion for this feature: Instead of keeping track of the growth phase and trying to emulate vanilla, let users set a delay for the tree populator/sapling action. This way, at least you will be able to set a certain amount of seconds/ticks for the tree to "grow", so it'll look a lot more natural, instead of just growing the tree instantly.

Should this be implemented, it would be great to add an option to add some randomness to the speed at which they grow, as well.