PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

Register ItemsAdder items in ItemBridge registry #1585

Closed ElMoha943 closed 11 months ago

ElMoha943 commented 2 years ago

Terms

Discord tag (optional)

Valen#7358

Describe the solution you'd like

There is this plugin called ItemBridge, wich help adding compatibility between plugins. I already suggested this in discord and people seem to like it.

Is your feature request related to a problem?

Not directly but there are plugins having trouble to implement things, for example using other custom items inside IAs recipes/vendors.

Describe alternatives you've considered

There are similar plugins like Mimic for example that would also do the job, ideally ia should support both.

Additional context

No response

ElMoha943 commented 2 years ago

imagen

ArubikU commented 2 years ago

public class ItemsAdderBridge implements ItemBridgeListener{

private static ItemBridge bridge;
public static void setup(Plugin plugin){
    bridge = new ItemBridge(plugin, "itemsadder", "ia");
    bridge.registerListener(new ItemsAdderBridge());
}

@Override
public ItemStack fetchItemStack(String item){
    return ItemsAdder.getCustomItem(item);
}

}

@LoneDev6

LoneDev6 commented 2 years ago

Will be added in 3.1.0

ElMoha943 commented 2 years ago

@LoneDev6 is this working on vendor behaviour? imagen imagen

LoneDev6 commented 2 years ago

I literally just implemented the code sent by @ArubikU , this code makes OTHER plugins use ItemsAdder items, not the opposite.

https://itemsadder.devs.beer/compatibility-with-other-plugins/compatible/itembridge

ElMoha943 commented 2 years ago

Would it be possible to implement it inside items adder too? it kinda was the whole point of the suggestion 😅

ElMoha943 commented 2 years ago

@LoneDev6 would it be possible to add that?

LoneDev6 commented 2 years ago

There is no need to bump issues, as you can see there are 174 currently opened suggestions/help requests. Anyway, this request is not really straightforward to be implemented, I'll try to find a proper solution to do that but it's not easy to add without introducing issues. The Minecraft trading GUI is known to be unstable because most recipes won't match if the items have complex NBT data inside. That's one of the reasons why I'd avoid adding compatibility.

ElMoha943 commented 2 years ago

Sorry for the bump, i didnt want to open a new issue of the same topic and didnt know if you saw the message bc it was already closed.

About compatibility, you could add itemsbridge/mimic compat inside vendors and worst case essenario some items wouldnt work, but at least most would.

Thanx you again for taking time to answer this issue <3

EDIT: I tried with shopkeepers wich has same kind of GUI and in my case (using Nova and QualityArmory items) items work fine.

LoneDev6 commented 2 years ago

No problem, I wish I could answer faster but you can clearly see the amount of messages I get scattered around all the websites. I'll try to find the best solution to support every plugin.

Basically you to be able to use mimic/itemsbridge items in:

Nothing else?

Continuation on: #3169

ElMoha943 commented 2 years ago

Nothing else i can think off, does recipes include all crating table, cooking, anvil repair, etc?

Garfieldwxg55 commented 2 years ago

Would this also be compatible with the /ia menu? Thanks