PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

Emojis no longer working in chat after updating. #1886

Closed Cobalt246 closed 2 years ago

Cobalt246 commented 2 years ago

Terms

Discord tag (optional)

Dr. Terror#0222

What happened?

Hello, after recently updating protocollib, I also had to update ItemsAdder (so it still functions).

After doing so emojis in chat stopped working. This is all I did.

I don't have any chat management plugin other than VaultChatFormatter, which I really don't think is the problem since it's recommended by you and I didn't update it at all.

Emojis still work on signs.

Steps to reproduce the issue

  1. Update to latest protocollib version.

  2. Update to latest Itemsadder version.

  3. Restart server

  4. Try to use emojis in chat.

Server version

This server is running Paper version git-Paper-39 (MC: 1.19) (Implementing API version 1.19-R0.1-SNAPSHOT) (Git: 37afe98) You are 42 version(s) behind

ItemsAdder Version

ItemsAdder version 3.2.3e-2

ProtocolLib Version

ProtocolLib version 5.0.0-SNAPSHOT-b587

LoneLibs Version

LoneLibs version 1.0.19

LightAPI Version (optional)

LightAPI version bukkit-5.3.0 (build SNAPSHOT)

LibsDisguises Version (optional)

LibsDisguises version 10.0.29-SNAPSHOT

FULL server log

latest (4).log

Error (optional)

No response

ItemsAdder config.yml

metrics: true
update-checker: true
disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false
resource-pack:
  hosting:
    no-host:
      enabled: false
    auto-external-host:
      enabled: false
    self-host:
      enabled: true
      server-ip: 91.109.116.4
      pack-port: 8001
    external-host:
      enabled: false
      url: ''
      skip-url-file-type-check___DONT_ASK_HELP_IF_SET_TRUE: false
  apply-on-join: true
  kick-player-on-decline: false
  kick-player-on-fail: false
  delay-ticks: 1
  notify-other-plugins-interfering: true
  title:
    enabled: true
  protect-player:
    black-screen: true
    hide-hud: true
    cancel-movement: false
    lock-player: false
  command:
    usage-cooldown-seconds: 60
  custom-font:
    enabled: false
    name: ipaexg.ttf
    shift: '[0,0]'
    size: 11.0
    oversample: 2.0
  thin-font:
    enabled: false
  zip:
    protect-file-from-unzip:
      enabled: false
      extreme: false
    compress-png-files: true
    compress-json-files: true
    overwrite-vanilla-models: false
    overwrite-vanilla-lang-json: false
    generate-custom-armors-textures:
      vanilla_1_17: true
      optifine: true
    disable-overwrite-leather-armor-layers-textures: false
    fix_transparent_noteblocks__disable-for-more-performance: false
    ignore-files-ext:
    - db
    - yml
    - xcf
    - psd
    - html
    - gz
    - rar
    - zip
    - 7z
    - bbmodel
    - iaentitymodel
  items:
    CustomModelData-starting-value:
      ALL: 10000
      DIAMOND: 11000
config_files:
  lang: en
  dictionaries-lang: en
  extract-default-resources: false
  extract-default-configs: false
  legacy_pack: false
blocks:
  light-api: true
  fix-liquids-flow: true
  fix-floating-blocks: true
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
    search-also-in-these-biomes:
      enabled: false
      biomes:
      - BEACH
      - BIRCH_FOREST
      - BIRCH_FOREST_HILLS
      - FOREST
      - MOUNTAINS
      - MOUNTAIN_EDGE
      - GRAVELLY_MOUNTAINS
      - PLAINS
      - RIVER
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: false
    allow-any-item: true
  disable-REAL: false
  disable-REAL_TRANSPARENT: false
  disable-REAL_NOTE: false
  disable-REAL_WIRE: false
  disable-FIRE: false
items:
  fix-show-attack-and-damage-as-lore: true
  give_death_location_maps: true
  hide-custom-durability-lore: false
liquids:
  enabled: true
huds:
  enabled: true
loots:
  allow-loots-drop-from-spawners-using-silk-touch: false
mobs:
  disable-MOB-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
font_images:
  replace-in-customitems-name-and-lore: true
  chat:
    enabled: true
    doublecheck-permission__disable-for-more-performance: false
    add-hover-suggestion: true
  command:
    enabled: true
    commandblocks: true
    excluded:
    - home
    - sethome
    - tpa
  sign:
    enabled: true
  book:
    enabled: true
  anvil:
    enabled: true
  inventory-title:
    enabled: true
  vault-prefix-suffix:
    enabled: true
    update-every-ticks: 1200
  scoreboard-teams:
    enabled: false
    update-every-ticks: 3600
  player-display-name:
    enabled: true
    update-every-ticks: 1200
effects:
  hide-scoreboard-numbers: false
  text-effects:
    enabled: true
    replace-in-customitems-name-and-lore: true
    chat:
      enabled: true
    sign:
      enabled: true
    book:
      enabled: true
    anvil:
      enabled: true
entities:
  max-furniture-vehicles-per-chunk: 50
  allow-removing-old-furnitures_2_3_11: false
  custom-entitites:
    enabled: true
    interval-rendering-packets-ticks: 1
    emotes: false
    optimized-packets: true
recipes:
  hide-vanilla-unrecognized-recipe-errors: true
  fix-packet-too-large-kick: false
  custom-recipes:
    unlock:
      all-on-join: true
      on-pickup:
        any: true
        ingredients: true
  remove-vanilla-recipes:
    enabled: true
    list:
      DIAMOND_SWORD: false
      IRON_INGOT: false
debug:
  items:
    log-files-loading: false
    log-items-loading: false
    log-items-loading-disabled: false
    log-font-images-loading: false
    log-huds-loading: false
    log-attribute-modifiers-loading: false
    log-warnings: false
    log-loots-loading: false
    log-loots-loading-disabled: false
    log-armors-loading: false
  recipes:
    log-recipes-loading: false
    log-recipes-loading-disabled: false
    log-recipes-removed-vanilla: false
    log-fix-packet-too-large: false
    log-recipes-unknown-item: false
  resource-pack:
    log-extract-default-resources: false
    log-not-extract-default-resources-already-exist: false
  blocks:
    log-save: false
    log-save-on-unload: false
    log-mined-unknown-blocks: true
  worlds-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: false
    log-generation: false
  trees-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  surface-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
  player-stats:
    log-save: false
  performance:
    loading-ms: true
  huds:
    log-triggers: false
  other:
    log-dictionaries-loading: false
    log-liquids-loading: false
    log-minecraft_lang_overwrite-loading: false
  categories:
    log-total-loaded: true
    log-single-loaded: true
    log-single-loaded-overwrite: true
    log-single-skip: true
    log-icon-failed-load: false
  entities:
    log-files-loading: false
    log-entities-loading: false
    log-entities-loading-disabled: false
  cave-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
chat-preview: false

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

Plugins List list

Cobalt246 commented 2 years ago

Also just to note: I NEVER use PlugMan to load or unload ItemsAdder, or any of its dependencies.

LoneDev6 commented 2 years ago

Emojis no longer working in chat after updating

after updating what? I mean, what did you update in order to make them stop working?

Cobalt246 commented 2 years ago

Emojis no longer working in chat after updating

after updating what? I mean, what did you update in order to make them stop working?

Itemsadder and ProtocolLib.

Cobalt246 commented 2 years ago

My players have also found:

Hammers no longer work.

Crafting cheese kicks them from the server.

None of these things happened prior to updating.

LoneDev6 commented 2 years ago

So you basically updated just ItemsAdder and ProtocolLib? What happens if you downgrade to the previous versions? Can you please also tell me which versions you were using before updating? Thanks.

Cobalt246 commented 2 years ago

Downgrading breaks the plugin entirely. Nothing works anymore.

I was using ItemsAdder 3.2.0c-beta6 and ProtocolLib-5.0.0-SNAPSHOT (I have no idea which build specifically.)

Cobalt246 commented 2 years ago

Should you have the time, feel free to contact me on discord and I'll gladly give you access to my Pterodactyl panel, as well as operator on the server.

Cobalt246 commented 2 years ago

?

play275 commented 2 years ago

? I had the same problem, so I rolled back to ItemsAdder_3.2.3c, the emoji can be displayed, the hammer can be used, but the peeled potatoes cannot be crafted, and once crafted, they will be kicked out of the server.

Cobalt246 commented 2 years ago

play275

what version of protocollib are you using?

play275 commented 2 years ago

https://ci.dmulloy2.net/job/ProtocolLib/lastSuccessfulBuild/

Cobalt246 commented 2 years ago

https://ci.dmulloy2.net/job/ProtocolLib/lastSuccessfulBuild/

This fixed my emojis, but it still seems like hammers aren't working.

Nonetheless, thanks a bunch!

If it's not too much trouble to ask, what version of paper are you using?

Cobalt246 commented 2 years ago

So.... just not getting a reply anymore?

LoneDev6 commented 2 years ago

This whole issues report is extremely vague, confusing and doesn't include useful information. I'm always open to fixing issues and helping people but this report absolutely doesn't allow me to understand how to reproduce the reported issue.

I need also a log of when the issue occurred, not a random log. Thanks

100petr commented 2 years ago

image Hi, I updated the server to 1.19.2 purpur and the emojis are also not working for me in the chat. It started doing this already on 1.19 when I updated protocollib, but I was using an older version where there was no problem, but now I need the current protocollib (due libsdisguises). Specifically, I used protocollib b575 and there was no problem, maybe it wasn't in another newer one, I don't know, I haven't tried. There is no error in the console about the itemsadder. I hope for a fix soon. Log: https://pastebin.com/d7Lr0Fsf

LoneDev6 commented 2 years ago

So basically updating ProtocolLib is the cause of the issue? What is your chat plugin?

100petr commented 2 years ago

yes, but I can't tell now exactly which build started causing the problem. I sent the build number where there was definitely no problem. maybe within a day I will find an even older (versus latest) build with which it was a problemĀ Ā  chat plugin I have essentials, but it worked when I uploaded an older version of protocollib, so the essentials version won't affect it.

100petr commented 2 years ago

So I'm looking and I noticed this problem already with protocollib b586 (3.8.), so anything newer than b586 will not be related to this (maybe there will only be other changes). So something between b576 and b586 is causing this.

LoneDev6 commented 2 years ago

So it seems something changed in ProtocolLib?

100petr commented 2 years ago

probably yes. because it does after updating protocollibĀ 

TonyMontero commented 2 years ago

Actually updating to the latest protocollib doesn't fix the issue (at the moment)

LoneDev6 commented 2 years ago

Seems Mojang changed again how chat works in 1.19.1. A fix will be published, thanks