block_trade_machine stops working after iareload/iazip

[purejosh]

Terms

• [X] I'm using the very latest version of ItemsAdder and its dependencies.
• [X] I already searched on this Github page to check if the same issue was already reported.
• [X] I already searched on the plugin wiki to know if a solution is already known.
• [X] I already asked on the #💬ia-community-help channel on Discord to know if anyone already has a solution for the issue.

Discord tag (optional)

purejosh#2047

What happened?

I have a custom upgrade table which trades a base weapon and an upgrade item, to get an upgraded weapon. This block stops responding to right click GUI open after using iareload or iazip. This issue became present in recent versions, as I was on a much older version with no issues, and it became an issue after upgrading.

Steps to reproduce the issue

Right click block_trade_machine with at least one valid trade, observe that it works. Use iareload Right click block_trade_machine with at least one valid trade, observe that it fails to open GUI.

Server version

This server is running Paper version git-Paper-111 (MC: 1.19.1) (Implementing API version 1.19.1-R0.1-SNAPSHOT) (Git: 02831e3) You are running the latest version Previous version: git-Paper-387 (MC: 1.18.2)

ItemsAdder Version

3.2.3-R9

ProtocolLib Version

5.0.0-SNAPSHOT-b587

LoneLibs Version

1.0.20

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

No response

Error (optional)

No response

ItemsAdder config.yml

metrics: true
update-checker: true
disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false
resource-pack:
  hosting:
    no-host:
      enabled: false
    auto-external-host:
      enabled: false
    self-host:
      enabled: true
      server-ip: 192.34.113.4
      pack-port: 32103
    external-host:
      enabled: false
      url: ''
      skip-url-file-type-check___DONT_ASK_HELP_IF_SET_TRUE: false
  apply-on-join: true
  kick-player-on-decline: false
  kick-player-on-fail: false
  delay-ticks: 1
  notify-other-plugins-interfering: true
  title:
    enabled: true
  protect-player:
    black-screen: true
    hide-hud: true
    cancel-movement: true
    lock-player: true
  command:
    usage-cooldown-seconds: 60
  custom-font:
    enabled: false
    name: ipaexg.ttf
    shift: '[0,0]'
    size: 11.0
    oversample: 2.0
  thin-font:
    enabled: false
  zip:
    protect-file-from-unzip:
      enabled: true
      extreme: true
    overwrite-vanilla-models: true
    overwrite-vanilla-lang-json: false
    fix_transparent_noteblocks__disable-for-more-performance: false
    ignore-files-ext:
    - db
    - yml
    - xcf
    - html
    compress-png-files: true
    compress-json-files: true
    generate-custom-armors-textures:
      vanilla_1_17: true
      optifine: true
    disable-overwrite-leather-armor-layers-textures: false
  items:
    CustomModelData-starting-value:
      ALL: 10000
      DIAMOND: 11000
config_files:
  lang: en
  dictionaries-lang: en
  extract-default-resources: false
  extract-default-configs: false
  legacy_pack: false
blocks:
  light-api: true
  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false
  cancel-break-wrong-tool:
    enabled: true
    send-actionbar: true
  campfire:
    unlit-on-place: true
    allow-any-item: true
  disable-REAL: true
  disable-REAL_TRANSPARENT: false
  disable-REAL_NOTE: false
  disable-REAL_WIRE: false
  disable-FIRE: false
  fix-liquids-flow: true
  fix-floating-blocks: true
items:
  fix-show-attack-and-damage-as-lore: true
  give_death_location_maps: true
  hide-custom-durability-lore: true
liquids:
  enabled: true
huds:
  enabled: true
mobs:
  disable-MOB-behaviour__DISABLE_AT_YOUR_OWN_RISK: false
font_images:
  chat:
    enabled: true
    doublecheck-permission__disable-for-more-performance: false
    add-hover-suggestion: true
  command:
    enabled: true
    commandblocks: true
    excluded:
    - home
    - sethome
    - tpa
  sign:
    enabled: true
  book:
    enabled: true
  anvil:
    enabled: true
  inventory-title:
    enabled: true
  vault-prefix-suffix:
    enabled: true
    update-every-ticks: 1200
  scoreboard-teams:
    enabled: false
    update-every-ticks: 3600
  player-display-name:
    enabled: true
    update-every-ticks: 1200
  replace-in-customitems-name-and-lore: true
effects:
  hide-scoreboard-numbers: false
  text-effects:
    enabled: true
    replace-in-customitems-name-and-lore: true
    chat:
      enabled: true
    sign:
      enabled: true
    book:
      enabled: true
    anvil:
      enabled: true
entities:
  max-furniture-vehicles-per-chunk: 70
  allow-removing-old-furnitures_2_3_11: false
  custom-entitites:
    enabled: true
    emotes: true
    interval-rendering-packets-ticks: 1
    optimized-packets: true
recipes:
  hide-vanilla-unrecognized-recipe-errors: true
  custom-recipes:
    unlock:
      all-on-join: false
      on-pickup:
        any: false
        ingredients: true
  remove-vanilla-recipes:
    enabled: false
    list:
      DIAMOND_SWORD: false
      IRON_INGOT: false
  fix-packet-too-large-kick: false
debug:
  items:
    log-files-loading: false
    log-items-loading: false
    log-items-loading-disabled: false
    log-font-images-loading: false
    log-huds-loading: false
    log-attribute-modifiers-loading: false
    log-warnings: false
    log-loots-loading: false
    log-loots-loading-disabled: false
    log-armors-loading: true
  recipes:
    log-recipes-loading: false
    log-recipes-loading-disabled: false
    log-recipes-removed-vanilla: false
    log-fix-packet-too-large: false
    log-recipes-unknown-item: false
  resource-pack:
    log-extract-default-resources: false
    log-not-extract-default-resources-already-exist: false
  blocks:
    log-save: false
    log-save-on-unload: false
    log-mined-unknown-blocks: true
  worlds-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  trees-populators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-populators: false
    log-loading-no-world: true
    log-generation: false
  surface-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
  player-stats:
    log-save: false
  performance:
    loading-ms: true
  huds:
    log-triggers: false
  other:
    log-dictionaries-loading: false
    log-liquids-loading: false
    log-minecraft_lang_overwrite-loading: false
  categories:
    log-total-loaded: true
    log-single-loaded: false
    log-single-loaded-overwrite: false
    log-single-skip: false
    log-icon-failed-load: false
  entities:
    log-files-loading: false
    log-entities-loading: false
    log-entities-loading-disabled: false
  cave-decorators:
    log-loading: false
    log-loading-disabled: false
    log-loading-no-decorators: false
    log-loading-no-world: true
    log-generation: false
loots:
  allow-loots-drop-from-spawners-using-silk-touch: false
chat-preview: false

Problematic items yml configuration file (optional)

info:
  namespace: pureweapons
#
recipes:
  crafting_table:
    upgrade_table:
      permission: pureweapons.upgrade_table
      enabled: true
      pattern:
      - xlx
      - xix
      - xsx
      ingredients:
        s: SMITHING_TABLE
        i: itemsadder:iron_plate
        l: LAVA_BUCKET
      result:
        item: pureweapons:upgrade_table
        amount: 1
#
items:
  upgrade_table:
    display_name: Upgrade Table
    permission: upgrade_table
    resource: 
      material: PAPER
      generate: false
      model_path: block/upgrade_table
    specific_properties:
      block:
        placed_model:
          type: REAL_NOTE
          break_particles: ITEM
    behaviours:
      block_trade_machine:
        title: Upgrade Table
        trades_list:
#-----NETHERITE-----
          netherite_katana:
            ingredients:
              slot1:
                item: pureweapons:diamond_katana
                amount: 1
              slot2:
                item: NETHERITE_INGOT
                amount: 1
            result:
              item: pureweapons:netherite_katana
              amount: 1
          netherite_tachi:
            ingredients:
              slot1:
                item: pureweapons:netherite_katana
                amount: 1
              slot2:
                item: NETHERITE_SCRAP
                amount: 3
            result:
              item: pureweapons:netherite_tachi
              amount: 1
          netherite_spear:
            ingredients:
              slot1:
                item: pureweapons:diamond_spear
                amount: 1
              slot2:
                item: NETHERITE_INGOT
                amount: 1
            result:
              item: pureweapons:netherite_spear
              amount: 1
          netherite_buster:
            ingredients:
              slot1:
                item: pureweapons:diamond_buster
                amount: 1
              slot2:
                item: NETHERITE_INGOT
                amount: 1
            result:
              item: pureweapons:netherite_buster
              amount: 1
          netherite_hammer:
            ingredients:
              slot1:
                item: pureweapons:diamond_hammer
                amount: 1
              slot2:
                item: NETHERITE_INGOT
                amount: 1
            result:
              item: pureweapons:netherite_hammer
              amount: 1
# -----PRISMARINE-----
          prismarine_sword:
            ingredients:
              slot1:
                item: NETHERITE_SWORD
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_sword
              amount: 1
          prismarine_katana:
            ingredients:
              slot1:
                item: pureweapons:netherite_katana
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_katana
              amount: 1
          prismarine_tachi:
            ingredients:
              slot1:
                item: pureweapons:netherite_tachi
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_tachi
              amount: 1
          prismarine_spear:
            ingredients:
              slot1:
                item: pureweapons:netherite_spear
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_spear
              amount: 1
          prismarine_buster:
            ingredients:
              slot1:
                item: pureweapons:netherite_buster
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_buster
              amount: 1
          prismarine_pickaxe:
            ingredients:
              slot1:
                item: NETHERITE_PICKAXE
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_pickaxe
              amount: 1
          prismarine_axe:
            ingredients:
              slot1:
                item: NETHERITE_AXE
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_axe
              amount: 1
          prismarine_shovel:
            ingredients:
              slot1:
                item: NETHERITE_SHOVEL
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_shovel
              amount: 1
          prismarine_hoe:
            ingredients:
              slot1:
                item: NETHERITE_HOE
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_hoe
              amount: 1
          prismarine_hammer:
            ingredients:
              slot1:
                item: pureweapons:netherite_hammer
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_hammer
              amount: 1
          prismarine_helmet:
            ingredients:
              slot1:
                item: NETHERITE_HELMET
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_helmet
              amount: 1
          prismarine_chestplate:
            ingredients:
              slot1:
                item: NETHERITE_CHESTPLATE
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_chestplate
              amount: 1
          prismarine_leggings:
            ingredients:
              slot1:
                item: NETHERITE_LEGGINGS
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_leggings
              amount: 1
          prismarine_boots:
            ingredients:
              slot1:
                item: NETHERITE_BOOTS
                amount: 1
              slot2:
                item: pureweapons:prismarine_ingot
                amount: 1
            result:
              item: pureweapons:prismarine_boots
              amount: 1
# -----WITHERITE-----
          witherite_sword:
            ingredients:
              slot1:
                item: NETHERITE_SWORD
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_sword
              amount: 1
          witherite_katana:
            ingredients:
              slot1:
                item: pureweapons:netherite_katana
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_katana
              amount: 1
          witherite_tachi:
            ingredients:
              slot1:
                item: pureweapons:netherite_tachi
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_tachi
              amount: 1
          witherite_spear:
            ingredients:
              slot1:
                item: pureweapons:netherite_spear
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_spear
              amount: 1
          witherite_buster:
            ingredients:
              slot1:
                item: pureweapons:netherite_buster
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_buster
              amount: 1
          witherite_pickaxe:
            ingredients:
              slot1:
                item: NETHERITE_PICKAXE
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_pickaxe
              amount: 1
          witherite_axe:
            ingredients:
              slot1:
                item: NETHERITE_AXE
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_axe
              amount: 1
          witherite_shovel:
            ingredients:
              slot1:
                item: NETHERITE_SHOVEL
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_shovel
              amount: 1
          witherite_hoe:
            ingredients:
              slot1:
                item: NETHERITE_HOE
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_hoe
              amount: 1
          witherite_hammer:
            ingredients:
              slot1:
                item: pureweapons:netherite_hammer
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_hammer
              amount: 1
          witherite_helmet:
            ingredients:
              slot1:
                item: NETHERITE_HELMET
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_helmet
              amount: 1
          witherite_chestplate:
            ingredients:
              slot1:
                item: NETHERITE_CHESTPLATE
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_chestplate
              amount: 1
          witherite_leggings:
            ingredients:
              slot1:
                item: NETHERITE_LEGGINGS
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_leggings
              amount: 1
          witherite_boots:
            ingredients:
              slot1:
                item: NETHERITE_BOOTS
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:witherite_boots
              amount: 1
#-----DRAGONITE-----
          dragonite_sword:
            ingredients:
              slot1:
                item: NETHERITE_SWORD
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_sword
              amount: 1
          dragonite_katana:
            ingredients:
              slot1:
                item: pureweapons:netherite_katana
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_katana
              amount: 1
          dragonite_tachi:
            ingredients:
              slot1:
                item: pureweapons:netherite_tachi
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_tachi
              amount: 1
          dragonite_spear:
            ingredients:
              slot1:
                item: pureweapons:netherite_spear
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_spear
              amount: 1
          dragonite_buster:
            ingredients:
              slot1:
                item: pureweapons:netherite_buster
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_buster
              amount: 1
          dragonite_pickaxe:
            ingredients:
              slot1:
                item: NETHERITE_PICKAXE
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_pickaxe
              amount: 1
          dragonite_axe:
            ingredients:
              slot1:
                item: NETHERITE_AXE
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_axe
              amount: 1
          dragonite_shovel:
            ingredients:
              slot1:
                item: NETHERITE_SHOVEL
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_shovel
              amount: 1
          dragonite_hoe:
            ingredients:
              slot1:
                item: NETHERITE_HOE
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_hoe
              amount: 1
          dragonite_hammer:
            ingredients:
              slot1:
                item: pureweapons:netherite_hammer
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_hammer
              amount: 1
          dragonite_helmet:
            ingredients:
              slot1:
                item: NETHERITE_HELMET
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_helmet
              amount: 1
          dragonite_chestplate:
            ingredients:
              slot1:
                item: NETHERITE_CHESTPLATE
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_chestplate
              amount: 1
          dragonite_leggings:
            ingredients:
              slot1:
                item: NETHERITE_LEGGINGS
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_leggings
              amount: 1
          dragonite_boots:
            ingredients:
              slot1:
                item: NETHERITE_BOOTS
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:dragonite_boots
              amount: 1
#-----SUPER PICKAXE-----
          prismarine_pickaxe_s:
            ingredients:
              slot1:
                item: pureweapons:prismarine_pickaxe
                amount: 1
              slot2:
                item: BEACON
                amount: 3
            result:
              item: pureweapons:prismarine_pickaxe_s
              amount: 1
          witherite_pickaxe_s:
            ingredients:
              slot1:
                item: pureweapons:witherite_pickaxe
                amount: 1
              slot2:
                item: BEACON
                amount: 3
            result:
              item: pureweapons:witherite_pickaxe_s
              amount: 1
          dragonite_pickaxe_s:
            ingredients:
              slot1:
                item: pureweapons:dragonite_pickaxe
                amount: 1
              slot2:
                item: BEACON
                amount: 3
            result:
              item: pureweapons:dragonite_pickaxe_s
              amount: 1
#-----VESSEL-----
          infused_vessel:
            ingredients:
              slot1:
                item: pureweapons:vessel
                amount: 1
              slot2:
                item: pureweapons:witherite_ingot
                amount: 1
            result:
              item: pureweapons:infused_vessel
              amount: 1
          cursed_vessel:
            ingredients:
              slot1:
                item: pureweapons:vessel
                amount: 1
              slot2:
                item: pureweapons:dragonite_ingot
                amount: 1
            result:
              item: pureweapons:cursed_vessel
              amount: 1
          wither_vessel:
            ingredients:
              slot1:
                item: pureweapons:infused_vessel
                amount: 1
              slot2:
                item: pureweapons:cursed_vessel
                amount: 1
            result:
              item: pureweapons:wither_vessel
              amount: 1
          dragon_vessel:
            ingredients:
              slot1:
                item: pureweapons:cursed_vessel
                amount: 1
              slot2:
                item: pureweapons:infused_vessel
                amount: 1
            result:
              item: pureweapons:dragon_vessel
              amount: 1

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

[LoneDev6]

I see you are still running 1.19.1, is there any reason to stay behind? It might be a Spigot bug and most likely fixed on 1.19.2.

[purejosh]

I'll give it a try, but it'll take some time before I'm able to.

[LoneDev6]

Thanks! Note that the plugin is registering these trades using the Spigot API, that's why I assumed it could have been a Spigot bug, since I didn't change anything about the load of trades.