Closed RebelDs closed 1 year ago
bump
What exactly is this SKIN feature? Is it using the shader hack?
The skin feature was meant to apply custom textures (via custom model data) to an item created in MMOItems.
an item of the SKIN type can be placed over a compatible item (sword skins to swords, armor skins to armors, etc) and the initial item would change textures to fit the custom model data of the SKIN type item.
Basically, this feature allows changing the Custom Model Data of an item on the fly, while keeping all mmoitems-related attributes.
With ItemsAdder and its method of keeping MMOItems' NBT Tags on armors for example, the shader of the armor doesn't change to fit the skin's Custom Model Data.
The issue is that the shader doesn't use CustomModelData to reskin armors but uses colors. You have to make sure that MMOItems feature also ports the item color to the new item and not only CustomModelData.
Terms
Discord tag (optional)
xRebelD#0585
What happened?
Hey! ItemsAdder seems to be incompatible with the skin system MMOItems has. We figured out how to work with custom armors, but the moment we apply skins to them (through mmoitems) they do not inherit their new texture. Here's a video displaying this incompatibility. https://www.youtube.com/watch?v=eS4RIjMDXC4
Steps to reproduce the issue
Server version
[11:31:54 INFO]: Checking version, please wait... [11:31:54 INFO]: This server is running Paper version git-Paper-411 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 6625db3 on ver/1.17.1) You are running the latest version Previous version: git-Paper-794 (MC: 1.16.5)
ItemsAdder Version
[11:32:41 INFO]: ItemsAdder version 3.2.3-r9 [11:32:41 INFO]: Customized Minecraft without client mods! [11:32:41 INFO]: Website: devs.beer [11:32:41 INFO]: Author: LoneDev
ProtocolLib Version
[11:32:53 INFO]: ProtocolLib version 4.8.0 [11:32:53 INFO]: Provides read/write access to the Minecraft protocol. [11:32:53 INFO]: Authors: dmulloy2 and comphenix
LoneLibs Version
[11:33:05 INFO]: LoneLibs version 1.0.21 [11:33:05 INFO]: Collection of libs used by my plugins [11:33:05 INFO]: Authors: LoneDev and others
LightAPI Version (optional)
No response
LibsDisguises Version (optional)
[11:33:32 INFO]: LibsDisguises version 10.0.31 [11:33:32 INFO]: A disguise plugin with various disguises. [11:33:32 INFO]: Authors: libraryaddict, Byteflux and Navid K.
FULL server log
https://mclo.gs/S7BNxib#L2162
Error (optional)
No response
ItemsAdder config.yml
Problematic items yml configuration file (optional)
Other files, you can drag and drop them here to upload. (optional)
No response
Screenshots/Videos (you can drag and drop files or paste links)
https://www.youtube.com/watch?v=eS4RIjMDXC4