Closed LuluxClient closed 1 year ago
Now you see why I decided to avoid coding custom farms directly into itemsadder.
Anyway most of the lag is caused by CustomCrops plugin not by ItemsAdder.
Ask them to optimize the code, getType
is using a lot of CPU.
Anyway most of the lag is caused by CustomCrops plugin not by ItemsAdder. Ask them to optimize the code,
getType
is using a lot of CPU.ItemsAdder itself is not using a lot of CPU.
Hey thanks for the quick answer, I've also contacted them and I'm currently waiting on an answer from them !
A quick guess is that they rely entirely on the Spigot API for very fast checks, this is a bad idea since the Spigot API is not optimized for such frequency. They should switch to NMS for some of their logic.
Terms
Discord tag (optional)
Lulux#4614
What happened?
I've noticed that after enabling custom blocks to ItemsAdder that it was causing some heavy lag and huge CPU spikes: https://spark.lucko.me/kVwZUXcuvE . I'm using CustomCrops that creates new farms with Real_wire (tripewire) and noteblocks and it hooks on ItemsAdder
Steps to reproduce the issue
Have lots of custom blocs and real_wire
Server version
This server is running Pufferfish version git-Pufferfish-40 (MC: 1.19.2) (Implementing API version 1.19.2-R0.1-SNAPSHOT) (Git: deb9638 on HEAD) You are running 6 versions beyond. Please update your server when possible to maintain stability, security, and receive the latest optimizations. Previous version: git-Prismarine-"69d16d0" (MC: 1.19.2)
ItemsAdder Version
3.3.0-beta-r8
ProtocolLib Version
5.0.0
LoneLibs Version
1.0.21
LightAPI Version (optional)
none
LibsDisguises Version (optional)
10.0.31
FULL server log
private
Error (optional)
ItemsAdder config.yml
Problematic items yml configuration file (optional)
Other files, you can drag and drop them here to upload. (optional)
https://spark.lucko.me/kVwZUXcuvE
Screenshots/Videos (you can drag and drop files or paste links)
No response