search

PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
55 stars 21 forks source link

[BUG] Bucket Fill event and custom durability don't work #215

Closed YoutubeNosios closed 4 years ago

YoutubeNosios commented 4 years ago

Describe the bug The event bucket_fill doesnt work and the custom durability dont work for buckets

To Reproduce Add bucket_fill event and custom durability on a bucket

Expected Action Do the actions associated action with the bucket_fill event and add a durability bar to it

Info

LoneDev6 commented 4 years ago

bucket_fill

Please provide the config of your item so I can check what you mean. Thanks.

EDIT: durability bar cannot be shown on BUCKET material since it's not an item that has durability in vanilla Minecraft. You have to use "usages"

    durability:
      usages: 15
    events:
      bucket_fill:
        decrement_usages:
           amount: 1
YoutubeNosios commented 4 years ago

Hey ! There is my item : And can you add an option to cancel the event please ? https://hasteb.in/gapihamu.yaml

LoneDev6 commented 4 years ago

Hey ! There is my item : And can you add an option to cancel the event please ? https://hasteb.in/gapihamu.yaml

Thanks I will publish an update today that fixes the event as now it's not called because of a bug. This is how to properly configure your infinite bucket after the update:

  infinite_bucket_full:
    display_name: Infinite Bucket Full
    permission: 'adamod.items'
    resource:
      material: WATER_BUCKET
      generate: true
      textures:
      - item/infinite_bucket_full.png
    durability:
      usages: 5
    events:
      bucket_empty:
        cancel: true
        decrement_usages:
          amount: 1
        replace_near_blocks:
          radius:
            x: 1
            y: 1
            z: 1
          from: AIR
          to: WATER
  infinite_bucket:
    display_name: Infinite Bucket
    permission: 'adamod.items'
    resource:
      material: BUCKET
      generate: true
      textures:
      - item/infinite_bucket.png
    events:
      bucket_fill:
        cancel: true
        give_item:
          item: infinite_bucket_full
          amount: 1
        decrement_amount:
          amount: 1
YoutubeNosios commented 4 years ago

I don't want a full bucket , the infinite bucket is made to remove water infinitely , but thank you for publishing an update !

LoneDev6 commented 4 years ago

I don't want a full bucket , the infinite bucket is made to remove water infinitely , but thank you for publishing an update !

ahhh okay, well it's easy then, this will work after the update:

  infinite_bucket:
    display_name: Infinite Bucket
    permission: 'adamod.items'
    resource:
      material: BUCKET
      generate: true
      textures:
      - item/infinite_bucket.png
    durability:
      usages: 5
    events:
      bucket_fill:
        cancel: true
        decrement_usages:
          amount: 1