PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
55 stars 21 forks source link

Betterranks and old texturepack compatibility #2158

Closed EPGMooky closed 1 year ago

EPGMooky commented 1 year ago

Terms

Discord tag (optional)

EPGMooky#2597

What happened?

I tried the merge separately addon betterranks and they didn't work. Finally I tried to merge an old resourcepack where I had these ranks and it popped up a bunch of errors that I can't identify

Thank you for your help!

Steps to reproduce the issue

  1. Betterranks merge. 2, ranks always shows this symbol [].

Server version

Current: git-Purpur-1857 (MC: 1.19.2)* Previous: git-Purpur-1845 (MC: 1.19.2)

ItemsAdder Version

3.3.0-beta-r10

ProtocolLib Version

5.0.0-SNAPSHOT-b600

LoneLibs Version

1.0.21

LightAPI Version (optional)

No response

LibsDisguises Version (optional)

No response

FULL server log

No response

Error (optional)

[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/tags/rpg.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/tags/creative.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/tags/economy.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/tags/vanilla.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/tags/offline.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/tags/online.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/srsupport.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/hbuilder.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/developer.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/support.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/exarch.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/zealot.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/builder.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/esupport.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/hsupport.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/manager.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/influencer.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/mentor.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/dreenal.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/patron.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/booster_logo.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/booster.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/neophyte.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/player.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/tsupport.png
[14:00:27] [Craft Scheduler Thread - 36 - ItemsAdder/ERROR]: [ItemsAdder] Invalid character in namespace 'Allerial' of file: /contents/Allerial/assets/betterranks/textures/font/rank/moderator.png

ItemsAdder config.yml

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

image

Akiranya commented 1 year ago

I also have betterrank plugin installed and it works fine with the IA 3.3.0-r10

The actual issue is because IA 3.3 enforces the namespace rule according to the standard of Minecraft resourcepack. That is, namespace must be all lowercase and can only contains _ and numbers.

Changing Allerial to allerial should resolve this issue.

EPGMooky commented 1 year ago

Yes, thanks!! This resolve namespace problem. But betterranks still dont work and show only [] [] <---this

EPGMooky commented 1 year ago

image2 image

EPGMooky commented 1 year ago

I I tried these placeholders: :admin: %img_admin%

Akiranya commented 1 year ago

Have a look at the new file structure of IA 3.3+: https://itemsadder.devs.beer/3-3-vs-3-2

You need to migrate your old betterrank files into the new structure. The same applies to any other packs you have.

EPGMooky commented 1 year ago

"Are old 3.2 packs compatible? Yes, you can just continue using the old structure (items_packs and resource_pack). ItemsAdder will still load your assets from these folders if still available."

But ill try

LoneDev6 commented 1 year ago

Have a look at the new file structure of IA 3.3+: https://itemsadder.devs.beer/3-3-vs-3-2

You need to migrate your old betterrank files into the new structure. The same applies to any other packs you have.

Migration is not mandatory, the old structure will still load fine. There is something else broken here. Check your server console for errors, if you still cannot load the font images read here: https://itemsadder.devs.beer/faq/identify-why-textures-are-not-shown

EPGMooky commented 1 year ago

It worked until the new version.. that acctually fix the space problem but broken everything else.

If i create new "config" folder and put it together with textures it fixed like half of the tags. Not all of them for some reason.

I don't understand how only some textures can work? obrazek

EPGMooky commented 1 year ago

[12:52:36] [Worker-Main-8/WARN]: Unable to load font 'minecraft:default' in fonts.json in resourcepack: 'c6a68722d0e33acb184ab50655052d285884471d'

EPGMooky commented 1 year ago

I dont really know what this mean

Akiranya commented 1 year ago

Have you tried just fixing the uppercase namespace but leaving the rest of files intact?

As LoneDev said, the old structure data still works and you don't need to migrate to the new structure for the time being.

EPGMooky commented 1 year ago

Looks like i fixed it. My old Minecraft:default font dont like new merge system... so i regenerate it by the new system and it work

EPGMooky commented 1 year ago

Thanks for help Lone and Akiranya!

EPGMooky commented 1 year ago

Thanks for help Lone and Akiranya!

LoneDev6 commented 1 year ago

Happy everything works fine now! I'm always happy when my customers are satisfied. I hope you will consider leaving a good review :) it would help me to stay motivated and continue delivering updates.