Emotes have wrong offset of some off-hand accessories

glutaminus commented 1 year ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

No response

What happened?

continuing from issue in #2232 as it got locked and I can't comment on it. so I create new Issue on it. to make it simple
@LoneDev6 try to test and can not reproduce the issue.

https://user-images.githubusercontent.com/90768288/230078790-f0c91171-55d3-4ac6-b44e-6445afa00285.mp4

and the reason for this is because the issue are only happened on some off-hand items. for some examples I'll use the built-in accessories like wing/tail/backpack to test, and this is what i get

https://user-images.githubusercontent.com/90768288/230080960-c09ae011-3e53-47ff-96ea-4318a1a62af2.mp4

(ignore the wrong skin bugs as I forgot to update my skin plugin and the video i show is short & only test on wing because I can't upload bigger files but you get the point) so with this, we can see that some accessories like wing or some that is stick to the off-hand can have wrong off-set when use emotes? any reason why this happen and maybe some solutions?

Steps to reproduce the issue

execute /iaget itemsadder:demoniac_red_wings
put the wing on the off-hand slots
execute /iaemote death_1

Server version

git-Purpur-1838 (MC.1.19.2)

ItemsAdder Version

ItemsAdder version 3.4.1-r5

ProtocolLib Version

ProtocolLib version 5.0.0-SNAPSHOT-B602

LoneLibs Version

LoneLibs version 1.0.24

FULL server log

No response

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

https://user-images.githubusercontent.com/90768288/230080960-c09ae011-3e53-47ff-96ea-4318a1a62af2.mp4

LoneDev6 commented 1 year ago

The reason is probably because the armorstand used to display the offhand item of the emote is holding the model in the mainhand of itself, so it will use the mainhand model location instead of the offhand.

I'll check if I can fix this but I sincerely doubt I can do it without restructuring the armorstand code.

glutaminus commented 1 year ago

wish it could be fixed so i don't have to work on each item.. but since it's stalled I will tell an alternate way to fix this problem for those who want to get rid of this problem. you need to move your model's X-axis of thirdperson display by (probably around) 10 from the original X-axis that you wanted it to look like. for example: if i have

    "display": {
        "thirdperson_righthand": {
            "rotation": [70, 0, 0],
            "translation": [-5.5, -5, 8.5],
            "scale": [2.5, 2.5, 2.5]
        },

I will need to move the x axis by 10 so it will be 4.5

    "display": {
        "thirdperson_righthand": {
            "rotation": [70, 0, 0],
            "translation": [4.5, -5, 8.5],
            "scale": [2.5, 2.5, 2.5]
        },

note that you will not want to use the model for main hand anymore since the weird offset will be moved to your main hand instead from now on.

PluginBugs / Issues-ItemsAdder