2x2 crafting recipes are not usable on every slot like vanilla recipes would

konfix commented 1 year ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

No response

What happened?

Hello, I have defined custom 2x2 recipes for my custom blocks. The issue with them is that they don't work properly. They work fine in survival inventory's 2x2 crafting table, but they don't work in the 3x3 crafting table (block).

The only way you can make them work in 3x3 crafting tables is by using upper-right slots. Upper-left, down-left, down-right slots don't work, the result item is empty. However, when I try to get the item from the result (even though it's empty), it will play a sound as if something is there.

I have tried both methods from the wiki for creating 2x2 recipes, but none of them work properly.

See video for explanation.

Steps to reproduce the issue

Survival gamemode, open the inventory and create a 2x2 custom item -> works
Place a crafting table block, open it, try making the 2x2 shape for that custom item -> doesn't work
Move the items to the top-right corner -> works

Server version

Current: git-Purpur-1962 (MC: 1.19.4)* Previous: git-Purpur-1956 (MC: 1.19.4)

You are running the latest version

ItemsAdder Version

ItemsAdder version 3.4.1-r6

ProtocolLib Version

ProtocolLib version 5.0.0-SNAPSHOT-b631

LoneLibs Version

LoneLibs version 1.0.24

FULL server log

Not needed, there are 0 errors/notes/warnings

Error (optional)

No response

Problematic items yml configuration file (optional)

----------
METHOD 1
----------
recipes:
  crafting_table:
    red_concrete_bricks:
      enabled: true
      pattern:
      - XZZ
      - XZZ
      ingredients:
        Z: RED_CONCRETE
      result:
        item: mystic:red_concrete_bricks
        amount: 1
----------
METHOD 2
----------
recipes:
  crafting_table:
    red_concrete_bricks:
      enabled: true
      pattern:
      - ZZ
      - ZZ
      ingredients:
        Z: RED_CONCRETE
      result:
        item: mystic:red_concrete_bricks
        amount: 1

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

https://user-images.githubusercontent.com/66477781/232333511-4a017e98-7e66-4545-b786-50041839aff1.mp4

LoneDev6 commented 1 year ago

Will be checked, anyway the feature was tested extensively so it's strange, it should work just fine.

IPECTER commented 1 year ago

@LoneDev6 I have same problem.

- A
- A
- S

LoneDev6 commented 1 year ago

@LoneDev6 I have same problem.
- A
- A
- S

Please provide more details of why this is not working and how you expect the recipe to work.

To be honest I don't see why your players would need to craft the sword like that, just create a 3x3 recipe in this case.

- XAX
- XAX
- XSX

The 2x2 recipes were extensively tested and worked fine. Some examples can be found on the wiki and on my default pack. https://itemsadder.devs.beer/plugin-usage/adding-content/recipes/crafting#2x2-recipe https://github.com/search?q=repo%3AItemsAdder%2FDefaultPack+recipes&type=code

IPECTER commented 1 year ago

@LoneDev6 I have same problem.
- A
- A
- S
Please provide more details of why this is not working and how you expect the recipe to work.

To be honest I don't see why your players would need to craft the sword like that, just create a 3x3 recipe in this case.
- XAX
- XAX
- XSX
The 2x2 recipes were extensively tested and worked fine. Some examples can be found on the wiki and on my default pack. https://itemsadder.devs.beer/plugin-usage/adding-content/recipes/crafting#2x2-recipe https://github.com/search?q=repo%3AItemsAdder%2FDefaultPack+recipes&type=code

If you do this, there's a problem that's different from the vanilla method In the first place, this problem is with ItemsAdder

LoneDev6 commented 1 year ago

I still don't understand why you're not creating the recipe like this:


- XAX
- XAX
- XSX

Also this issue report is about a 2x2 recipe problem, the issue you're reporting has nothing to do with it.

IPECTER commented 1 year ago

I will make a new issue.

LoneDev6 commented 1 year ago

Is this implementation really needed? People since 1.13 use the recipebook to craft items, no one remembers them all. This would just increase the amount of work to do on the server side to calculate recipes.

konfix commented 1 year ago

Is this implementation really needed? People since 1.13 use the recipebook to craft items, no one remembers them all. This would just increase the amount of work to do on the server side to calculate recipes.

Were you referring to my issue or the issue of the person above? I need the 2x2 recipes working, you've closed my bug report because they replied with their problem.

LoneDev6 commented 1 year ago

I was referring to the 2x2 issue report. Basically I'm asking if it's something really needed to be implemented since 2x2 recipes work fine if yoiu fit ingredients in the top slots.

I ask because I'd avoid implementing this since it would increase the workload on the server (recipes are heavy). People use the recipebook to craft stuff since 1.13 so I don't really think it's something players would be bothered with.

Let me know what you think

konfix commented 1 year ago

I was referring to the 2x2 issue report. Basically I'm asking if it's something really needed to be implemented since 2x2 recipes work fine if yoiu fit ingredients in the top slots.

I ask because I'd avoid implementing this since it would increase the workload on the server (recipes are heavy). People use the recipebook to craft stuff since 1.13 so I don't really think it's something players would be bothered with.

Let me know what you think

It's alright, I'll just let the players know they need to use top-right slots. Thanks.

PluginBugs / Issues-ItemsAdder