search

PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

ModelEngine textures atlases not merged correctly #2709

Closed dinobossytnew closed 1 year ago

dinobossytnew commented 1 year ago

Terms

Discord tag (optional)

DinoBoss#6985

What happened?

Hello, I didn't want to be impolite. This report was recommended by the modelengine dev, and I need your help because I'm doubting whether it's an error in the AI itself or in modelengine, to be honest, haha. But, as Toxic told me, the IA plugin is responsible for merging the two atlases into one, and I think this might be the issue, or it could be something else.

I understand your concern. Rest assured that your privacy is important to us. While I'm here to help, please note that as an AI language model, I don't have the capability to access or handle private or personal information, including your premium packs or specific data related to your purchases.

However, I can still assist you with general troubleshooting or provide guidance based on the information you provide. If you have any specific questions or issues you'd like assistance with, please let me know, and I'll do my best to help you.

Steps to reproduce the issue

Step 1: Upload a texture pack from EliteCreatures or any other companies you prefer, such as ArtByKev or MCModels.

To upload a texture pack, follow these steps:

Go to the website of the respective company, such as EliteCreatures, ArtByKev, or MCModels. Browse through their available texture packs and select the one you want to use. Click on the download button or follow the instructions provided to obtain the texture pack file.

Server version

[16:48:22 INFO]: This server is running Paper version git-Paper-530 (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: 9daa019) You are 16 version(s) behind Download the new version at: https://papermc.io/downloads/paper

ItemsAdder Version

[16:48:33 INFO]: ItemsAdder version 3.4.1f [16:48:33 INFO]: Customized Minecraft without client mods! [16:48:33 INFO]: Website: devs.beer [16:48:33 INFO]: Author: LoneDev

ProtocolLib Version

ver protocollib [16:48:53 INFO]: ProtocolLib version 5.0.0 [16:48:53 INFO]: Provides read/write access to the Minecraft protocol. [16:48:53 INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

[16:49:01 INFO]: LoneLibs version 1.0.24 [16:49:01 INFO]: Collection of libs used by my plugins [16:49:01 INFO]: Authors: LoneDev and others

FULL server log

null

Error (optional)

none error

Problematic items yml configuration file (optional)

atlas autogenerate by ia

Other files, you can drag and drop them here to upload. (optional)

client log https://bin.bloom.host/tegozeyeme.yaml

Screenshots/Videos (you can drag and drop files or paste links)

image It seems strange to me, but some users are experiencing issues while others are not. None of them are using OptiFine, and they include both premium and non-premium clients. In this particular case, the user is using a premium client.

dinobossytnew commented 1 year ago

duplicated modelengine

LoneDev6 commented 1 year ago

I understand your concern. Rest assured that your privacy is important to us. While I'm here to help, please note that as an AI language model, I don't have the capability to access or handle private or personal information, including your premium packs or specific data related to your purchases.

However, I can still assist you with general troubleshooting or provide guidance based on the information you provide. If you have any specific questions or issues you'd like assistance with, please let me know, and I'll do my best to help you.

bro wtf?

I have no idea of what the issue is about. Explain without the use of an AI to generate your questions and provide some valid showcase of what the issue is.

ItemsAdder merges atlas files of the various resourcepacks if provided and generates one to make the load of textures possible even on non-standard folders. This was extensively tested and working correctly, so I need more information.

dinobossytnew commented 1 year ago

Well, bro, I'm in the same boat as you. It's literally WTF. Let me explain to my users. I have a large texture pack, quite substantial, I won't lie, it weighs 35 MB without entity models. I've been testing it, of course, but the weird thing is that only some users are experiencing this issue. As far as I can tell, I don't really understand why. It seems to be an error specific to the pack, but no errors are displayed in the console. All the other packs load perfectly fine.

I have been trying to extract textures and models, specifically the atlas.json from ModelEngine. When I remove it, I delete it, and then use the commands "/iareload" and "/iazip", it works perfectly fine. I will try to create a comprehensive video demonstrating the entire process if it is possible for me to do so.

dinobossytnew commented 1 year ago

It seems to be affecting only a subset of my daily 100 users. Out of those, 43 users are experiencing this particular error. That's why I will reach out to some of them to perform further testing and troubleshooting.

That's puzzling. If the error message simply states that the pack is not compatible and there are no critical errors in the Minecraft log indicating that the pack is not functioning, it adds to the mystery. It might be worth examining the compatibility requirements or dependencies of the pack further to identify the root cause of the issue.

LoneDev6 commented 1 year ago

Well, bro, I'm in the same boat as you. It's literally WTF

My WTF was about the fact that your message contained 5 lines of text where the AI tells you that it's an AI generated message 🤦🏻‍♂️

only some users are experiencing this issue.

Check if they are using mods, ask them to join using the vanilla game. Anyway you can ask them a complete CLIENT LOG to see what error they get on resourcepack loading. How to read client logs: https://itemsadder.devs.beer/faq/identify-why-textures-are-not-shown

dinobossytnew commented 1 year ago

Ah, I don't use mods but I'll tell you and I'll make you 1 video.

dinobossytnew commented 1 year ago

Since I am going to record how I talk to my users what I do and how I charge them so I can fully understand what I am talking about.

LoneDev6 commented 1 year ago

Anyway you can ask them a complete CLIENT LOG to see what error they get on resourcepack loading. How to read client logs: https://itemsadder.devs.beer/faq/identify-why-textures-are-not-shown

dinobossytnew commented 1 year ago

latest.log

video exemple https://vimeo.com/834531843

LoneDev6 commented 1 year ago

If you disable itemsadder pack apply in config.yml and load the modelengine pack manually in your game, will the mobs show correctly?

I see TONS of errors in the log you sent, most likely to be caused by misconfigurations.

LoneDev6 commented 1 year ago

Some examples:

This error is the reason why your pack fails to load. You probably have too many HQ textures in your pack and Minecraft can't keep up loading them. (This is not an issue of ItemsAdder).

Caused by: fta: Unable to fit: valerieset:scythe - size: 96x96 - Maybe try a lower resolution resourcepack?

Model with invalid cubes size

[14:49:20] [Worker-Main-22/ERROR]: Failed to load model bear_set:models/flag_self.json
com.google.gson.JsonParseException: 'from' specifier exceeds the allowed boundaries: ( 7.500E+0 -1.900E+1  7.500E+0)

Invalid sounds

[14:49:16] [Worker-Main-24/WARN]: File minecraft:sounds/custom/elitecreatures/krampus1.ogg does not exist, cannot add it to event elitecreatures:custom.elitecreatures.krampus1
[14:49:16] [Worker-Main-24/WARN]: File minecraft:sounds/custom/elitecreatures/krampuswhip.ogg does not exist, cannot add it to event elitecreatures:custom.elitecreatures.krampuswhip
[14:49:16] [Worker-Main-24/WARN]: File minecraft:sounds/custom/elitecreatures/krampusslash.ogg does not exist, cannot add it to event elitecreatures:custom.elitecreatures.krampusslash
[14:49:16] [Worker-Main-24/WARN]: File minecraft:sounds/custom/elitecreatures/krampusroar.ogg does not exist, cannot add it to event elitecreatures:custom.elitecreatures.krampusroar
[14:49:16] [Worker-Main-24/WARN]: File minecraft:sounds/custom/elitecreatures/krampusstompspike.ogg does not exist, cannot add it to event elitecreatures:custom.elitecreatures.krampusstompspike
[14:49:16] [Worker-Main-24/WARN]: File minecraft:sounds/custom/elitecreatures/sleighjingle.ogg does not exist, cannot add it to event elitecreatures:custom.elitecreatures.sleighjingle

Invalid animation frames (in .mcmeta images animations)

[14:49:23] [Worker-Main-24/WARN]: Invalid frame index on sprite modelengine:entity/head_fire_a frame 5: 5
[14:49:24] [Worker-Main-24/WARN]: Invalid frame index on sprite modelengine:entity/wumpus_neon_e frame 3: 3
[14:49:24] [Worker-Main-24/WARN]: Unused frames in sprite fuben:block/decorate/decorate12_2: [7]
[14:49:24] [Worker-Main-24/WARN]: Unused frames in sprite fuben:block/decorate/decorate12_3: [7]
[14:49:25] [Worker-Main-24/WARN]: Invalid frame index on sprite modelengine:entity/head_fire_a_e frame 5: 5
[14:49:25] [Worker-Main-24/WARN]: Invalid frame index on sprite modelengine:entity/wumpus_neon frame 3: 3

Invalid textures dimensions. They must all be power of 2 otherwise your textures will look crispy. More info here.

[14:49:25] [Worker-Main-24/WARN]: Texture customfishing:item/util/animated_splash_lava with size 48x28 limits mip level from 4 to 2
[14:49:25] [Worker-Main-24/WARN]: Texture hyronic:custom/items/lucky_clover with size 18x18 limits mip level from 2 to 1
[14:49:25] [Worker-Main-24/WARN]: Texture minecraft:item/rift/click_to_start with size 100x25 limits mip level from 1 to 0
[14:49:25] [Worker-Main-24/WARN]: minecraft:textures/atlas/blocks.png: dropping miplevel from 4 to 0, because of minimum power of two: 1

Missing models.

[14:49:27] [Worker-Main-22/WARN]: Unable to load model: 'minecraft:custom/elitecreatures/octana/vzduch' referenced from: minecraft:clay_ball#inventory: java.io.FileNotFoundException: minecraft:models/custom/elitecreatures/octana/vzduch.json
[14:49:27] [Worker-Main-22/WARN]: Unable to load model: 'minecraft:custom/elitecreatures/headless/horislash' referenced from: minecraft:bone#inventory: java.io.FileNotFoundException: minecraft:models/custom/elitecreatures/headless/horislash.json
[14:49:27] [Worker-Main-22/WARN]: Unable to load model: 'minecraft:custom/elitecreatures/headless/hellportal' referenced from: minecraft:bone#inventory: java.io.FileNotFoundException: minecraft:models/custom/elitecreatures/headless/hellportal.json
[14:49:27] [Worker-Main-22/WARN]: Unable to load model: 'minecraft:custom/elitecreatures/headless/headtrophy' referenced from: minecraft:bone#inventory: java.io.FileNotFoundException: minecraft:models/custom/elitecreatures/headless/headtrophy.json
[14:49:27] [Worker-Main-22/WARN]: Unable to load model: 'minecraft:custom/elitecreatures/headless/dulahan_key' referenced from: minecraft:bone#inventory: java.io.FileNotFoundException: minecraft:models/custom/elitecreatures/headless/dulahan_key.json
[14:49:27] [Worker-Main-22/WARN]: Unable to load model: 'minecraft:custom/elitecreatures/headless/vertislash' referenced from: minecraft:bone#inventory: java.io.FileNotFoundException: minecraft:models/custom/elitecreatures/headless/vertislash.json
[14:49:27] [Worker-Main-22/WARN]: Unable to load model: 'minecraft:custom/elitecreatures/headless/fear' referenced from: minecraft:bone#inventory: java.io.FileNotFoundException: minecraft:models/custom/elitecreatures/headless/fear.json
dinobossytnew commented 1 year ago

Hello, Lone. How are you? I hope you're doing well, bro. I'm still seeing this, and it's strange because the notifications that MC gives are minimal and shouldn't affect the error of bee_set. It has already been corrected by the designer, who mentioned that Blockbench went crazy. The same thing happened to Kev's models from ArtByKev. The lack of sounds, models, and textures may cause some warning messages, but the strange thing is, as you can see in the video, I remove textures. I tried putting many packs into a single itemsadder.zip, meaning all the items in various folders, and discovered that there's a limit where it goes crazy. So what did I do? I tested and played with the activation of two debug modes: "log-files-loading: true," "log-items-loading: true," "log-font-images-loading: true," "resource-pack: log-extract-default-resources: true," and "log-not-extract-default-resources-already-exist: true." I added this, and it started working correctly. If you want, I can make a video. Let me know if you need it. Also, I loaded HQ textures because, you know, I love them, I won't lie. You know I'm the one who uses the least amount of vanilla textures, haha. So I tested and tested, and in the end, I didn't see any problem with them. I tried creating a texture pack outside of AI, tested the same thing, and encountered the same issues. The model coordinates error persists, so I recommend being careful. As you can see, Kev mentioned that the textures go crazy.

Captura

dinobossytnew commented 1 year ago

https://mclo.gs/RYXe6Xi debug enable always

LoneDev6 commented 1 year ago

What should I do? This is a misconfiguration of the models not an itemsadder bug

dinobossytnew commented 1 year ago

nothing I guess if it's just a configuration error I won't give it any more I'll see if I can fix it thanks anyway.