`movementSpeed` attribute (and all attributes other than `attackSpeed` and `attackDamage`) not showing up in lore

yorik100 commented 1 year ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

yorik100#5011

What happened?

If you have a weapon with attackdamage, attackspeed and speed, speed wont be shown in lore

Steps to reproduce the issue

Create a weapon with attakdamage, attackspeed and speed
Hover your cursor over that weapon
Speed attribute doesn't show

Server version

Paper version git-Paper-546 (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT)

ItemsAdder Version

3.4.1f2

ProtocolLib Version

5.1.0

LoneLibs Version

1.0.24

FULL server log

Not needed

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

In game : In settings :

Speed boost is getting applied, it's just not showing up in lore

LoneDev6 commented 1 year ago

Yes this is normal, for now you have to set it in the lore manually. I'll try to see if I can code a fix for that but could be tricky.

Thanks

yorik100 commented 1 year ago

Yes this is normal, for now you have to set it in the lore manually. I'll try to see if I can code a fix for that but could be tricky.

Thanks

Remember that other attributes exist, including knockback resistance and bonus health

LoneDev6 commented 11 months ago

More info here: https://github.com/PluginBugs/Issues-ItemsAdder/issues/448#issuecomment-792871597

You have to disable this in config.yml of ItemsAdder. fix-show-attack-and-damage-as-lore: false

ItemsAdder has to do some tricks to show the correct value for damage and speed of weapons because the game uses a stupid calculation and would show slightly imprecise values (+4 for speed and +1 for damage).

To do that ItemsAdder hides the vanilla information using the item flag HIDE_ATTRIBUTES, but the downside is that it hides all attributes not only speed and damage. So I have to manually write these in the lore, but I prefer not to write ALL possible attributes for performance reasons. If you have more than speed and damage attributes you can write them on your own using the lore attribute of the ItemsAdder item.

Let me know if the solution is good or not.

PluginBugs / Issues-ItemsAdder