Infinite mining/drinking `REAL_TRANSPARENT` blocks

yorik100 commented 1 year ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

yorik100#5011

What happened?

Sometimes, when you mine something from IA, the block never gets broken ever until you stop mining and start mining again, this is not a TPS issue as my server is running on 20 TPS permanently. This also happens when drinking something from IA.

Steps to reproduce the issue

No steps to reproduce, happens semi-frequently, easy to notice when breaking a tree because sometimes you'll get stuck mining one leaves block until you stop mining and start mining again, again, this is not a TPS issue as mobs can attack me in the meantime and mobs around me move without any lag at all. Note that if I go through the approx 1 minute of trying to break a block in this state, the block will instantly reappear back and will stay impossible to break until I stop and start breaking again.

Server version

git-Purpur-1982 (MC: 1.19.4)

ItemsAdder Version

3.4.1f2

ProtocolLib Version

5.1.0-SNAPSHOT-645

LoneLibs Version

1.0.24

FULL server log

https://pastebin.com/hKrHXrN9

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

yorik100 commented 1 year ago

Here's me reproducing the issue with a 100% 1.19.4 vanilla client https://streamable.com/g7ji4e You can see me throw snowballs while the bug happens which means that the server was not lagging at all

LoneDev6 commented 1 year ago

This can be reproduced only using axe, right?

yorik100 commented 1 year ago

This can be reproduced only using axe, right?

Also happens when mining with hand

yorik100 commented 1 year ago

This can be reproduced only using axe, right?

I have found a way to replicate it 99% of the time, start mining, move your cursor away and back to the block while still holding the click This footage shows me reproducing it, F3 enabled so you can see that I'm on vanilla, I'm also throwing snowballs at some point of the vid so you know that server TPS is fine https://streamable.com/hpw1tc

yorik100 commented 1 year ago

Footage of me reproducing both infinite mining and infinite drinking https://streamable.com/8jb7td Infinite drinking is made by trying to drink while aiming at a block

Just infinite drinking footage https://streamable.com/sfte8g

Settings of that potion https://pastebin.com/PJuRVHWA I suppose it's due to interact right cancel but it shouldn't cancel the drinking itself

LoneDev6 commented 1 year ago

I'll do some tests and see if it can be fixed. I'm not sure since I have little control over client predictions.

the vid so you know that server TPS is fine https://streamable.com/hpw1tc

Never said it has to do with TPS by the way.

yorik100 commented 1 year ago

I'll do some tests and see if it can be fixed. I'm not sure since I have little control over client predictions.

the vid so you know that server TPS is fine https://streamable.com/hpw1tc

Never said it has to do with TPS by the way.

I can't read your mind but it isn't uncommon for people to think that an issue like that could be linked to TPS as a server lag would have had the same effect, just making it clear that it's not the issue in this case. I was able to fix the drink issue on my end by removing the cancel interact right and setting the potion as "SPEED" so that you can't transform dirt into mud by mistake while trying to drink it.

The big issue is the infinite mining issue and I'm 100% sure that this one is fixable

yorik100 commented 1 year ago

@LoneDev6 The mining bug is very annoying and happens with every block types, it's anytime you start breaking, stop breaking and start breaking the same block, it happens 2-3 times at least when someone tries to break a tree, very very annoying

LoneDev6 commented 1 year ago

This will be looked on as soon as possible, I hope to be able to implement a solution for this since the game is very limited when it comes to this kind of tasks.

yorik100 commented 1 year ago

This will be looked on as soon as possible, I hope to be able to implement a solution for this since the game is very limited when it comes to this kind of tasks.

Player sends an abort break packet when it happens, when they stop mining

PluginBugs / Issues-ItemsAdder