PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
52 stars 21 forks source link

EcoEnchants and ItemsAdder Anvil Bug #2969

Closed SuperWan08 closed 1 year ago

SuperWan08 commented 1 year ago

Terms

Discord tag (optional)

sw08

What happened?

EcoEnchants disappear when combining two custom items in an anvil but the vanilla ones stay

Steps to reproduce the issue

  1. Install EcoEnchants
  2. Take an itemsadder item
  3. Apply some custom enchants to it with a book
  4. Combine two EcoEnchanted items in an anvil
  5. All of the EcoEnchants have disappeared but the vanilla ones stay

Server version

This server is running Paper version git-Paper-126 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: a73ed95) You are 6 version(s) behind Download the new version at: https://papermc.io/downloads/paper Previous version: git-Paper-101 (MC: 1.20.1)

ItemsAdder Version

ItemsAdder Version 3.5.0c-r4

ProtocolLib Version

ProtocolLib Version 5.1.0-SNAPSHOT-654

LoneLibs Version

LoneLibs Version 1.0.25

FULL server log

[14:07:23] [ServerMain/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD' [14:07:25] [ServerMain/INFO]: Loaded 7 recipes [14:07:25] [Server thread/INFO]: Starting minecraft server version 1.20.1 [14:07:25] [Server thread/INFO]: Loading properties [14:07:25] [Server thread/INFO]: This server is running Paper version git-Paper-126 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: a73ed95) [14:07:25] [Server thread/INFO]: Server Ping Player Sample Count: 12 [14:07:25] [Server thread/INFO]: Using 4 threads for Netty based IO [14:07:26] [Server thread/WARN]: [!] The timings profiler has been enabled but has been scheduled for removal from Paper in the future. We recommend installing the spark profiler as a replacement: https://spark.lucko.me/ For more information please visit: https://github.com/PaperMC/Paper/issues/8948 [14:07:26] [Server thread/INFO]: [ChunkTaskScheduler] Chunk system is using 1 I/O threads, 3 worker threads, and gen parallelism of 3 threads [14:07:26] [Server thread/INFO]: Default game type: SURVIVAL [14:07:26] [Server thread/INFO]: Generating keypair [14:07:26] [Server thread/INFO]: Starting Minecraft server on *:25565 [14:07:26] [Server thread/INFO]: Using default channel type [14:07:26] [Server thread/INFO]: Paper: Using Java compression from Velocity. [14:07:26] [Server thread/INFO]: Paper: Using Java cipher from Velocity. [14:07:27] [Server thread/INFO]: [eco] Initializing eco [14:07:27] [Server thread/INFO]: [EcoEnchants] Initializing EcoEnchants [14:07:27] [Server thread/INFO]: [LuckPerms] Loading server plugin LuckPerms v5.4.71 [14:07:27] [Server thread/INFO]: [ProtocolLib] Loading server plugin ProtocolLib v5.1.0-SNAPSHOT-654 [14:07:27] [Server thread/WARN]: [ProtocolLib] Version (MC: 1.20.1) has not yet been tested! Proceed with caution. [14:07:28] [Server thread/INFO]: [PlaceholderAPI] Loading server plugin PlaceholderAPI v2.11.3 [14:07:28] [Server thread/INFO]: [LoneLibs] Loading server plugin LoneLibs v1.0.25 [14:07:28] [Server thread/INFO]: [Vault] Loading server plugin Vault v1.7.3-b131 [14:07:28] [Server thread/INFO]: [ItemsAdder] Loading server plugin ItemsAdder v3.5.0c-r4 [14:07:28] [Server thread/INFO]: [eco] Loading server plugin eco v6.65.4 [14:07:28] [Server thread/INFO]: [TAB] Loading server plugin TAB v4.0.3 [14:07:28] [Server thread/INFO]: [Multiverse-Core] Loading server plugin Multiverse-Core v4.3.1-b861 [14:07:28] [Server thread/INFO]: [MiniMOTD] Loading server plugin MiniMOTD v2.0.10 [14:07:28] [Server thread/INFO]: [HyanseItemSkins] Loading server plugin HyanseItemSkins v1.13 [14:07:28] [Server thread/INFO]: [EcoEnchants] Loading server plugin EcoEnchants v10.31.0 [14:07:28] [Server thread/INFO]: [libreforge] Initializing libreforge [14:07:29] [Server thread/INFO]: [libreforge] Loading server plugin libreforge v4.29.0 [14:07:29] [Server thread/INFO]: Server permissions file permissions.yml is empty, ignoring it [14:07:29] [Server thread/INFO]: [LuckPerms] Enabling LuckPerms v5.4.71

[14:07:30] [Server thread/INFO]: | |__) LuckPerms v5.4.71 [14:07:30] [Server thread/INFO]: |___ | Running on Bukkit - Paper [14:07:30] [Server thread/INFO]: [14:07:30] [Server thread/INFO]: [LuckPerms] Loading configuration... [14:07:30] [Server thread/INFO]: [LuckPerms] Loading storage provider... [H2] [14:07:30] [Server thread/INFO]: [LuckPerms] Loading internal permission managers... [14:07:30] [Server thread/INFO]: [LuckPerms] Performing initial data load... [14:07:31] [Server thread/INFO]: [LuckPerms] Successfully enabled. (took 1347ms) [14:07:31] [Server thread/INFO]: [ProtocolLib] Enabling ProtocolLib v5.1.0-SNAPSHOT-654 [14:07:31] [Server thread/INFO]: [LoneLibs] Enabling LoneLibs v1.0.25 [14:07:31] [Server thread/INFO]: [Vault] Enabling Vault v1.7.3-b131 [14:07:31] [Server thread/INFO]: [Vault] [Permission] SuperPermissions loaded as backup permission system. [14:07:31] [Server thread/INFO]: [Vault] Enabled Version 1.7.3-b131 [14:07:31] [Server thread/INFO]: [LuckPerms] Registered Vault permission & chat hook. [14:07:31] [Server thread/INFO]: [eco] Enabling eco v6.65.4 [14:07:31] [Server thread/INFO]: [eco] Loading eco [14:07:31] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: eco [6.65.4] [14:07:31] [Server thread/INFO]: [eco] Loaded integrations: Vault, PlaceholderAPI, ItemsAdder [14:07:31] [Server thread/INFO]: [eco] Scanning for conflicts... [14:07:31] [Server thread/INFO]: [eco] No conflicts found! [14:07:31] [Server thread/INFO]: [EcoEnchants] Enabling EcoEnchants v10.31.0 [14:07:31] [Server thread/INFO]: [EcoEnchants] Loading EcoEnchants [14:07:31] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: ecoenchants [10.31.0] [14:07:31] [Server thread/INFO]: Preparing level "world" [14:07:32] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld [14:07:32] [Server thread/INFO]: Time elapsed: 194 ms [14:07:32] [Server thread/INFO]: Preparing start region for dimension minecraft:the_nether [14:07:32] [Server thread/INFO]: Time elapsed: 32 ms [14:07:32] [Server thread/INFO]: Preparing start region for dimension minecraft:the_end [14:07:32] [Server thread/INFO]: Time elapsed: 25 ms [14:07:32] [Server thread/INFO]: [PlaceholderAPI] Enabling PlaceholderAPI v2.11.3 [14:07:32] [Server thread/INFO]: [PlaceholderAPI] Fetching available expansion information... [14:07:32] [Server thread/INFO]: [ItemsAdder] Enabling ItemsAdder v3.5.0c-r4 [14:07:32] [Server thread/INFO]: [NBTAPI] [NBTAPI] Found Spigot: v1_20_R1! Trying to find NMS support [14:07:32] [Server thread/INFO]: [NBTAPI] [NBTAPI] NMS support 'MC1_20_R1' loaded! [14:07:32] [Server thread/INFO]: [NBTAPI] [NBTAPI] Found Gson: class com.google.gson.Gson

ItemsAdder 3.5.0c-r4 | | | |\/| /` /\ | \ | \ | |) LoneLibs 1.0.25 | | | | | ./ /--\ |/ |__/ |___ | \ Paper git-Paper-126 (MC: 1.20.1)

[14:07:33] [Server thread/INFO]: [TAB] Enabling TAB v4.0.3 [14:07:33] [Server thread/INFO]: [TAB] Server version: 1.20.1 (v1_20_R1) [14:07:33] [Server thread/INFO]: [TAB] Loaded NMS hook in 70ms [14:07:33] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: tab [4.0.3] [14:07:33] [Server thread/INFO]: [TAB] [WARN] Invalid refresh interval configured for %bungee_lobby% (10). Value must be divisible by 50. [14:07:33] [Server thread/INFO]: [TAB] [WARN] Invalid refresh interval configured for %bungee_survival% (10). Value must be divisible by 50. [14:07:33] [Server thread/INFO]: [TAB] [WARN] Invalid refresh interval configured for %bungee_skyblock% (10). Value must be divisible by 50. [14:07:34] [Server thread/INFO]: [TAB] Found a total of 3 issues. [14:07:34] [Server thread/INFO]: [TAB] Enabled in 265ms [14:07:34] [Server thread/INFO]: [Multiverse-Core] Enabling Multiverse-Core v4.3.1-b861 [14:07:34] [Server thread/WARN]: [Multiverse-Core] "Multiverse-Core v4.3.1-b861" has registered a listener for org.bukkit.event.entity.EntityCreatePortalEvent on method "public void com.onarandombox.MultiverseCore.listeners.MVPortalListener.entityPortalCreate(org.bukkit.event.entity.EntityCreatePortalEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [dumptruckman, Rigby, fernferret, lithium3141, main--]. [14:07:34] [Server thread/INFO]: [Multiverse-Core] §aWe are aware of the warning about the deprecated event. There is no alternative that allows us to do what we need to do and performance impact is negligible. It is safe to ignore. [14:07:34] [Server thread/INFO]: Could not set generator for world 'Test': Plugin 'Stratos' does not exist [14:07:34] [Server thread/WARN]: [Multiverse-Core] WorldManager: Can't load this world because the folder was deleted/moved: Test [14:07:34] [Server thread/WARN]: [Multiverse-Core] Use '/mv remove' to remove it from the config! [14:07:34] [Server thread/INFO]: [Multiverse-Core] 3 - World(s) loaded. [14:07:34] [Server thread/WARN]: [Multiverse-Core] Buscript failed to load! The script command will be disabled! If you would like not to see this message, use /mv conf enablebuscript false to disable Buscript from loading. [14:07:34] [Server thread/INFO]: [Multiverse-Core] Version 4.3.1-b861 (API v24) Enabled - By dumptruckman, Rigby, fernferret, lithium3141 and main-- [14:07:34] [Server thread/INFO]: [MiniMOTD] Enabling MiniMOTD v2.0.10 [14:07:34] [Server thread/INFO]: [HyanseItemSkins] Enabling HyanseItemSkins v1.13 [14:07:34] [Server thread/INFO]: [ItemSkins] Found version v1_20_R1, trying to load desired classes [14:07:34] [Server thread/INFO]: [ItemSkins] Starting to load all skins... [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_axe.yml' skins (from 'darkmagic' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_bow.yml' skins (from 'darkmagic' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_crossbow.yml' skins (from 'darkmagic' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_hoe.yml' skins (from 'darkmagic' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_pickaxe.yml' skins (from 'darkmagic' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_shovel.yml' skins (from 'darkmagic' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_sword.yml' skins (from 'darkmagic' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'darksaber.yml' skins (from 'skins' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'doomhammer.yml' skins (from 'skins' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] Loading 'sword.yml' skins (from 'skins' directory) [14:07:34] [Server thread/INFO]: [ItemSkins] All skins are successfully loaded (took 71ms) [14:07:34] [Server thread/INFO]: [HyanseItemSkins] ItemsAdder detected, trying to hook into it [14:07:34] [Server thread/INFO]: [libreforge] Enabling libreforge v4.29.0 [14:07:34] [Server thread/INFO]: [libreforge] Loading libreforge [14:07:34] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: libreforge [4.29.0] [14:07:34] [Server thread/INFO]: [libreforge] Loaded integrations: Vault

[14:07:35] [Server thread/INFO]: [libreforge] Hey, what's this plugin doing here? I didn't install it! [14:07:35] [Server thread/INFO]: [libreforge] libreforge is the effects system for plugins like EcoEnchants, [14:07:35] [Server thread/INFO]: [libreforge] EcoJobs, EcoItems, etc. If you're looking for config options for [14:07:35] [Server thread/INFO]: [libreforge] things like cooldown messages, lrcdb, and stuff like that, you'll [14:07:35] [Server thread/INFO]: [libreforge] find it under /plugins/libreforge

[14:07:35] [Server thread/INFO]: [libreforge] Don't worry about updating libreforge, it's handled automatically!

[14:07:35] [Server thread/INFO]: [PlaceholderAPI] Placeholder expansion registration initializing... [14:07:35] [Server thread/INFO]: Running delayed init tasks [14:07:35] [Server thread/INFO]: [ItemsAdder] [Pack] Extracting internal contents from .jar [14:07:35] [Craft Scheduler Thread - 4 - ItemsAdder/INFO]: [ItemsAdder] [License] Store product licensed to: SuperWan08 (17618) [14:07:35] [Craft Scheduler Thread - 8 - Vault/INFO]: [Vault] Checking for Updates ... [14:07:35] [ForkJoinPool.commonPool-worker-5/INFO]: [ItemSkins] Your version of ItemSkins (1.13) is up to date! [14:07:35] [Craft Scheduler Thread - 8 - Vault/INFO]: [Vault] No new version available [14:07:35] [Server thread/INFO]: [ItemsAdder] [Pack] DONE extracting internal contents from .jar [14:07:35] [Server thread/WARN]: [ItemsAdder] Detected legacy ItemsAdder pack (pre 3.3.0). [14:07:35] [Server thread/WARN]: [ItemsAdder] Trying to load files, unexpected results might occur. [14:07:35] [Server thread/WARN]: [ItemsAdder] It's adviced to follow the new guidelines: https://a.devs.beer/ia-new-guidelines-330 [14:07:35] [Craft Scheduler Thread - 6 - MiniMOTD/INFO]: [MiniMOTD] There is an update available for MiniMOTD! [14:07:35] [Craft Scheduler Thread - 6 - MiniMOTD/INFO]: [MiniMOTD] This server is running version v2.0.10, which is 3 versions outdated. [14:07:35] [Craft Scheduler Thread - 6 - MiniMOTD/INFO]: [MiniMOTD] Download the latest version, v2.0.13 from GitHub at the link below: [14:07:35] [Craft Scheduler Thread - 6 - MiniMOTD/INFO]: [MiniMOTD] https://github.com/jpenilla/MiniMOTD/releases/tag/v2.0.13 [14:07:35] [Craft Scheduler Thread - 1 - EcoEnchants/WARN]: [EcoEnchants] EcoEnchants is out of date! (Version 10.31.0) [14:07:35] [Craft Scheduler Thread - 1 - EcoEnchants/WARN]: [EcoEnchants] The newest version is 10.31.1 [14:07:35] [Craft Scheduler Thread - 1 - EcoEnchants/WARN]: [EcoEnchants] Download the new version! [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: changeoutput [1.2.2] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: checkitem [2.6.8] [14:07:36] [Server thread/WARN]: [PlaceholderAPI] Cannot load expansion griefprevention due to a missing plugin: GriefPrevention [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: localtime [1.2] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: luckperms [5.4-R2] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: math [2.0.1] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: multiverse [1.0.1] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: player [2.0.5] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: plugin [1.1.0] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: server [2.6.2] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: statistic [2.0.1] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: vault [1.8.1] [14:07:36] [Server thread/WARN]: [PlaceholderAPI] Cannot load expansion worldguard due to an unknown issue. [14:07:36] [Server thread/INFO]: 11 placeholder hook(s) registered! 3 placeholder hook(s) have an update available.

[14:07:36] [Server thread/INFO]: Timings Reset [14:07:36] [Craft Scheduler Thread - 1 - ItemsAdder/INFO]: [ItemsAdder] Loaded 21 items [14:07:36] [Server thread/INFO]: [eco] Loaded eco [14:07:36] [Craft Scheduler Thread - 1 - ItemsAdder/INFO]: [ItemsAdder] Used 0/188 REAL block IDs [14:07:36] [Craft Scheduler Thread - 1 - ItemsAdder/INFO]: [ItemsAdder] Used 2/750 REAL_NOTE block IDs [14:07:36] [Craft Scheduler Thread - 1 - ItemsAdder/INFO]: [ItemsAdder] Used 0/63 REAL_TRANSPARENT block IDs [14:07:36] [Craft Scheduler Thread - 1 - ItemsAdder/INFO]: [ItemsAdder] Used 0/127 REAL_WIRE block IDs [14:07:36] [Craft Scheduler Thread - 1 - ItemsAdder/INFO]: [ItemsAdder] Used 0/14 FIRE block IDs [14:07:36] [Craft Scheduler Thread - 1 - ItemsAdder/INFO]: [ItemsAdder] Used 244/6608 font_images [14:07:36] [Craft Scheduler Thread - 1 - ItemsAdder/INFO]: [ItemsAdder] [Init] Loaded 1 categories [14:07:36] [Craft Scheduler Thread - 1 - ItemsAdder/INFO]: [ItemsAdder] [Init] Loaded successfully. [14:07:36] [Server thread/INFO]: [EcoEnchants] Loaded EcoEnchants [14:07:36] [Server thread/INFO]: [libreforge] Loaded libreforge [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: img [1.0.1] [14:07:36] [Server thread/INFO]: [PlaceholderAPI] Successfully registered expansion: iaplayerstat [1.0.1] [14:07:36] [Server thread/INFO]: [ItemSkins] Found version v1_20_R1, trying to load desired classes [14:07:36] [Server thread/INFO]: [ItemSkins] Starting to load all skins... [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_axe.yml' skins (from 'darkmagic' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_bow.yml' skins (from 'darkmagic' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_crossbow.yml' skins (from 'darkmagic' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_hoe.yml' skins (from 'darkmagic' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_pickaxe.yml' skins (from 'darkmagic' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_shovel.yml' skins (from 'darkmagic' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'darkmagic_sword.yml' skins (from 'darkmagic' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'darksaber.yml' skins (from 'skins' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'doomhammer.yml' skins (from 'skins' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] Loading 'sword.yml' skins (from 'skins' directory) [14:07:36] [Server thread/INFO]: [ItemSkins] All skins are successfully loaded (took 20ms) [14:07:51] [Craft Scheduler Thread - 6 - ItemsAdder/INFO]: [ItemsAdder] [Pack] Resourcepack URL is valid (auto-external-host), LastEdit: 2023-08-20_12-01. Url: http://resourcepack.host/dl/IcCHVORoiPqEMqfESgtOk4sCBSYKrZ8h/pack.zip [14:11:30] [User Authenticator #0/INFO]: UUID of player SuperWan08 is 834cc2e8-7430-4bd8-9ddc-817aa3f48d2a [14:11:30] [Server thread/INFO]: SuperWan08 joined the game [14:11:30] [Server thread/INFO]: SuperWan08[/127.0.0.1:54281] logged in with entity id 170 at ([world]785.4583501041383, 91.0, 41.31959247768631) [14:12:50] [Server thread/INFO]: SuperWan08 issued server command: /gamemode creative [14:12:50] [Server thread/INFO]: [SuperWan08: Set own game mode to Creative Mode]

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

image image image

LoneDev6 commented 1 year ago

Hello, Your report will be looked into as soon as possible, I'm just back from the summer break and I finally have access to my PC. Rest assured that your questions won't be ignored. Thanks a lot for the patience!

LoneDev6 commented 1 year ago

Note for me: For some reason PrepareAnvilEvent event is not porting the custom enchants into the result item. The cause is that EcoEnchants is waiting 1 tick before setting the item enchants, so I too have to wait 1 tick. Code reference: https://github.com/Auxilor/EcoEnchants/blob/3451c1d49802310cfa989904092ff71421705439/eco-core/core-plugin/src/main/kotlin/com/willfp/ecoenchants/mechanics/AnvilSupport.kt#L70

LoneDev6 commented 1 year ago

Note: for some reason EcoEnchants repairs the item completely setting its durability to max. Removing EcoEnchants doesn't trigger this behaviour so I'm sure it's an EcoEnchant bug. Contact its developer of this is not intended.