PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
52 stars 21 forks source link

ItemsAdder does not respect Cooking Recipe Machine Type #2984

Closed MinecraftCitiesNetwork closed 1 year ago

MinecraftCitiesNetwork commented 1 year ago

Terms

Discord tag (optional)

technofied

What happened?

I tried to make a faster sand smelting recipe for a specific group of players, that is unique to blast furnaces. Here is the recipe I used: mason_1: #1 sand -> 1 glass (blast furnace; 100 ticks, 0.1 exp) permission: miner.recipes ingredient: item: sand machines:

Unfortunately, it applies to both Smokers and Furnaces. As a result, it overrides the default Furnace smelting recipe and doesn't allow regular players without permission to use the Minecraft furnace smelting recipe.

To fix this, have "machines:" respect which machines are specified.

Steps to reproduce the issue

See above recipe. Try and smelt sand in a regular furnace with that recipe loaded and without the permission node. You are unable to smelt the sand, no permission.

Server version

[15:27:20 INFO]: This server is running Paper version git-Paper-169 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: b4e3b3d) You are running the latest version

ItemsAdder Version

[15:27:45 INFO]: ItemsAdder version 3.5.0c-r4 [15:27:45 INFO]: Customized Minecraft without client mods! [15:27:45 INFO]: Website: devs.beer [15:27:45 INFO]: Author: LoneDev

ProtocolLib Version

[15:28:00 INFO]: ProtocolLib version 5.1.1-SNAPSHOT-665 [15:28:00 INFO]: Provides read/write access to the Minecraft protocol. [15:28:00 INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

[15:28:00 INFO]: ProtocolLib version 5.1.1-SNAPSHOT-665 [15:28:00 INFO]: Provides read/write access to the Minecraft protocol. [15:28:00 INFO]: Authors: dmulloy2 and comphenix

FULL server log

I can provide this if needed, but otherwise I choose to withhold it at this time if that's ok.

Error (optional)

No response

Problematic items yml configuration file (optional)

info:
  namespace: jobs
recipes:
  cooking:
    mason_1: #1 sand -> 1 glass (blast furnace; 100 ticks, 0.1 exp)
      permission: miner.recipes
      ingredient:
        item: sand
      machines:
      - BLAST_FURNACE
      exp: 0.1
      cook_time: 100
      result:
        item: glass
        amount: 1

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

LoneDev6 commented 1 year ago

Did you try to restart the server? You might have created a recipe before which included all machines, then removed the recipe and the game might still have it loaded. A server restart will fix this if that's the case.

Let me know!

MinecraftCitiesNetwork commented 1 year ago

Did you try to restart the server? You might have created a recipe before which included all machines, then removed the recipe and the game might still have it loaded. A server restart will fix this if that's the case.

Let me know!

Hiya! We tried restarting but unfortunately the problem was not resolved. :(

LoneDev6 commented 1 year ago

Fixed in the upcoming update, thanks for the report

MinecraftCitiesNetwork commented 1 year ago

Hugely appreciated!