PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
52 stars 21 forks source link

resourecepack animations low fps #3019

Closed SrMonsterYT closed 1 year ago

SrMonsterYT commented 1 year ago

Terms

Discord tag (optional)

mauriciooficial

What happened?

I have armor and tools with animation, that's a total of 40 kits, and it's causing lag, and the strange thing is that I don't even have it on hand or near me and it's causing big fps drops

itemadder: https://prnt.sc/DUTDNNEvT1mV

no itemadder: https://prnt.sc/auJgGhITDQrb

when i remove the items from the contents the fps returns to normal, but they are simple armors nothing much, i even removed all the glows from the armors, i did a test in another oraxen plugin and i didn't get this problem, isn't there some way to make the animation not load until the player takes the item in his hand or vision?

i'm using optifine and i managed to gain a little fps by activating the option. Esc -> Options -> settings video -> performance -> smart animations: true

Steps to reproduce the issue

activating resourcepacks with more than 40 animated items in the contents folder

Server version

This server is running Paper version git-Paper-182 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 29d1c7b

ItemsAdder Version

3.5.0c-r5b

ProtocolLib Version

5.1.0-SNAPSHOT-660

LoneLibs Version

1.0.25

FULL server log

metrics: true update-checker: true disable-plugin-loading-messages_DONT_ASK_ME_FOR_SUPPORT_IF_YOU_SET_TRUE__THANKS: false ignore-server-compatibility-check: false resource-pack: hosting: no-host: enabled: false auto-external-host: enabled: true self-host: enabled: false server-ip: 127.0.0.1 pack-port: 8163 external-host: enabled: false url: '' skip-url-file-type-check___DONT_ASK_HELP_IF_SET_TRUE: false apply-on-join: true kick-player-on-decline: true kick-player-on-fail: false delay-ticks: 1 notify-other-plugins-interfering: true title: enabled: true 1_19_3_atlas_support: true fix_force_unicode_font_images: true protect-player: black-screen: true hide-hud: true cancel-movement: true lock-player: true command: usage-cooldown-seconds: 60 custom-font: enabled: false name: ipaexg.ttf shift: '[0,0]' size: 11.0 oversample: 2.0 thin-font: enabled: false zip: protect-file-from-unzip: protection_1: true protection_2: true compress-png-files: true compress-json-files: true generate-custom-armors-textures: vanilla_1_17: true optifine: true disable-overwrite-leather-armor-layers-textures: false fix_transparent_noteblocks: false ignore-files-ext:

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

I have more than 80 mobs of models, and 80% of them have glows and they don't cause me any lag, this only happens with itemadder

Screenshots/Videos (you can drag and drop files or paste links)

No response

github-actions[bot] commented 1 year ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

LoneDev6 commented 1 year ago

I already explained on Discord this is due to an abuse of the resourcepack which contains too big textures and causes the game to have to process too much stuff. There is no way to fix that on my side other than you stop to use too complex animations in your pack. It's a limitation of how the game works not on how ItemsAdder works.

SrMonsterYT commented 1 year ago

I already explained on Discord this is due to an abuse of the resourcepack which contains too big textures and causes the game to have to process too much stuff. There is no way to fix that on my side other than you stop to use too complex animations in your pack. It's a limitation of how the game works not on how ItemsAdder works.

what if itemadder loads the animations?

LoneDev6 commented 12 months ago

what if itemadder loads the animations?

ItemsAdder doesn't, I don't know what you are referring to. ItemsAdder is not a clientside mod. The game does the work and ItemsAdder has no role in the animations loading on the client.