search

PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

AdvancedEnchantment Plugin Ability is not compatible with IA items #3021

Open MoGGaming opened 1 year ago

MoGGaming commented 1 year ago

Terms

Discord tag (optional)

mog.gaming

What happened?

According to the IA wiki about AE I have added enchants in IA items like in any armor and ability was Soulbound. so when players die the armor is getting duped.

Steps to reproduce the issue

  1. Add Ae soulbound enchants in armors through config or ingame
  2. wear the armor and die
  3. you will respawn with duped items

Server version

[13:54:49] [Server thread/INFO]: Checking version, please wait... [13:54:51] [Thread-10/INFO]: This server is running Paper version git-Paper-182 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 29d1c7b) You are 12 version(s) behind Download the new version at: https://papermc.io/downloads/paper

ItemsAdder Version

[13:55:43] [Server thread/INFO]: ItemsAdder version 3.5.0c-r4b [13:55:43] [Server thread/INFO]: Customized Minecraft without client mods! [13:55:43] [Server thread/INFO]: Website: devs.beer [13:55:43] [Server thread/INFO]: Author: LoneDev

ProtocolLib Version

[13:56:58] [Server thread/INFO]: ProtocolLib version 5.1.0 [13:56:58] [Server thread/INFO]: Provides read/write access to the Minecraft protocol. [13:56:58] [Server thread/INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

[13:57:23] [Server thread/INFO]: LoneLibs version 1.0.25 [13:57:23] [Server thread/INFO]: Collection of libs used by my plugins [13:57:23] [Server thread/INFO]: Authors: LoneDev and others

FULL server log

No response

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

github-actions[bot] commented 1 year ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

LoneDev6 commented 1 year ago

Please provide a valid IA and AE configuration for me to reproduce the issue

MoGGaming commented 1 year ago

IA config : https://paste.helpch.at/aladodiqoj.yaml

info:
  namespace: elitecreatures
armors_rendering:
  skeleton_overlord_animated_weapon_set:
    color: '#8c196c'
    layer_1: skeleton_overlord_animated_weapon_set/skeletonoverlord_armor_layer_1
    layer_2: skeleton_overlord_animated_weapon_set/skeletonoverlord_armor_layer_2
    use_color: false
items:
  skeleton_overlord_animated_weapon_set_helmet:
    display_name: Skeleton Overlord Helmet
    resource:
      generate: true
      textures:
      - skeleton_overlord_animated_weapon_set/skeletonoverlord_helmet.png
    specific_properties:
      armor:
        slot: head
        custom_armor: skeleton_overlord_animated_weapon_set
    enchants:
    - soulbound:1

AE Config : https://paste.md-5.net/xavehufiqi.shell

# << Example configuration >>
# lastchance:    <-- Enchantment name
#  display: "%group-color%Last Chance"    <-- Display in item lore
#  description: "Has a chance to heal when on low hearts"    <-- Enchantment Description
#  applies-to: "Chestplate"    <-- What applies to (display purposes)
#  type: "DEFENSE"    <-- Enchantment type (controls when enchantment activates)
#  group: "COMMON"    <-- Enchantment group (For enchanter and right-click random books)
#  settings:
#    required-enchants:
#      - "springs:1" # Can require specific level
#      - "gears"
#    not-applyable-with:
#      - "frozen"
#  applies:    <-- List of items that it applies
#    - ALL_CHESTPLATE    <-- Item(s) list
#  levels:    < -- All Levels are under here
#    1:     <-- Level indicator
#      chance: 30    <-- Chance for enchantment to activate
#      conditions: "%victim health% > 5 : %stop%"    <-- Condition (read more about it at Conditions)
#      effects:    <-- All enchantment effects
#        - "ADD_HEALTH:2 %victim%"    <-- Effect(s) list

#  Display (String) (No spaces or enchantment will break)
#    Determines how will enchantment look in item lore

#  Applies-to (String)
#    Display used in Custom Enchantment books for %description% variable

#  Group (Setting)
#    INFO: Create enchantment groups in config.yml under enchanter configuration.
#   Enchantment groups are used for enchanter, to sell specific type books. You can group them
#   and add a group-wide color, then obtain it with variable %group-color% (shown in example enchantments below).

#  Enchantment Types List: https://ae.advancedplugins.net/enchantments/creating-enchantments/type-list

#  Applies (Material)
#    Determines which items will have the effects
#    The Latest Materials list: https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Material.html
#    NOTICE: You can use "LEATHER_ARMOR, IRON_ARMOR, CHAIN_ARMOR, GOLD_ARMOR or DIAMOND_ARMOR" to
#    instantly add availability for all specific armor type pieces.
#    Use "ALL_ARMOR" to add all armor pieces.
#    Use "ALL_HELMET" to add all helmets.
#    Use "ALL_CHESTPLATE" to add all chestplates.
#    Use "ALL_BOOTS" to add all boots.
#    Use "ALL_SWORD" to add all swords.
#    Use "ALL_PICKAXE" to add all pickaxes.
#    Use "ALL_AXE" to add all axes.
#    Use "ALL_EDIBLE" to add all foods.
#    And so on, but make sure to use non-plural names of items!

#  Levels (Numbers)
#    Effects for each level, use as display in examples.

#  Enchantment Effect List: https://ae.advancedplugins.net/enchantments/creating-enchantments/effect-list

#        # You can use tags <random word>word1,word2,word3</random word>, it will get a random word from listed words.
#        # You can use tags <random number>x-y</random number> while x < y, it will generate a random number between two given integers.
#        # e.g.: "STEAL_MONEY:<random number>10000-50000</random number>"
#        # Use <chance>x</chance> to set per-effect chance, x being a chance percentage.
#        # e.g.: "POTION:SPEED:1:100 %attacker% <chance>25</chance>"

#        # You also may use %victim% or %attacker% flag to give effects to different players (in ATTACK, BOW, DEATH, KILL_PLAYER and DEFENSE types).
#        # Example usage: - "POTION:POISON:1:50 %attacker%', this will give Level 2 POISON potion effect to the player who attacked.
#        # If none is provided, effects will be given to the player who had custom enchanted item.
#        # You can add %combo% instead of numbers, to use number of combo's player has (eg. to limit combo number: "%combo% > 0 && %combo% < 5 : %continue%')
#        # You can add %damage% instead of numbers, to use number of damage has been done (for ATTACK and DEFENSE)

#  Area of effect: https://ae.advancedplugins.net/enchantments/radius-of-effect-enchantments
#  Conditions:  https://ae.advancedplugins.net/enchantments/enchantment-conditions

# Settings for enchantments
# *** This is not a required configuration section and each enchantment doesn't need to have it ***
#  settings:
#    required-enchants:
#      - "springs"
#    not-applyable-with:
#      - "frozen"
#    removeable: false # Makes enchantment non-removeable with blackscrolls
#    disable-in-enchanter: true # Players can no longer obtain enchantment from Enchanter
#    disabled-worlds: # List worlds in which enchantment will not work (cAsE sEnSiTiVe)
#      - "My_World"
soulbound:
  display: '%group-color%Soulbound'
  description: A chance to keep item on death.
  applies-to: Weapons + Tools + Bows
  type: DEATH;PASSIVE_DEATH
  group: FABLED
  applies:
    - ALL_TOOLS
    - ALL_SWORD
    - BOW
    - CROSSBOW
    - ALL_ARMOR
  levels:
    '1':
      chance: 100
      cooldown: 0
      effects:
        - KEEP_ON_DEATH

Video link : https://youtu.be/wiVI0iGzRoA

MoGGaming commented 1 year ago

same issue with EcoEnchants