PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

Custom Blocks bug #3158

Closed ChefJisoo closed 5 months ago

ChefJisoo commented 11 months ago

Terms

Discord tag (optional)

No response

What happened?

Our custom blocks are randomly turning into chorus fruit + brown mushrooms without anyone touching them.

Steps to reproduce the issue

Make custom blocks. Watch them change.

Server version

Paper 1.20.1

ItemsAdder Version

Version 3.6.2-beta-r3

ProtocolLib Version

The command given doesn't work, but its the latest from the website as of 16/11/23

LoneLibs Version

The command given doesn't work, but its the latest from the website as of 16/11/23

FULL server log

latest (5).log

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

github-actions[bot] commented 11 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

LoneDev6 commented 11 months ago

I cannot reproduce the issue nor find the cause. Custom blocks are not losing textures just by watching them. Also the plugin is being used by more than 5400 servers, so i'm sure that the issue is related only to some very few servers, we just need to find out the cause which unites these different setups.

This can happen:

Might be to be a duplicate of this #2403 and no one find out a proper way to reproduce the issue. The only identical condition is that the servers are using CustomCrops plugin (not made by me), which might be the cause of the issue. Please let me know.

ChefJisoo commented 11 months ago

I cannot reproduce the issue nor find the cause. Custom blocks are not losing textures just by watching them. Also the plugin is being used by more than 5400 servers, so i'm sure that the issue is related only to some very few servers, we just need to find out the cause which unites these different setups.

This can happen:

  • the server was killed and it couldn't save the chunks in time
  • itemsadder folder was deleted from the world folder

Might be to be a duplicate of this #2403 and no one find out a proper way to reproduce the issue. The only identical condition is that the servers are using CustomCrops plugin (not made by me), which might be the cause of the issue. Please let me know.

hello, thankyou for such a fast response! neither of the two things mentioned happened so I don't think it could be that. I also do not use the crops plugin mentioned so it's strange 🤔 I could later in the day attach the config I've set up for the blocks just incase I've done something wrong there?

LoneDev6 commented 11 months ago

The other thing these servers have in common is the fact that they have a plugin which uses ItemsAdder API to manipulate blocks in the world. Do you have any? Maybe a custom made one?

Can you attach a video of when the issue happens? As you said

Make custom blocks. Watch them change.

seems to be something happening right after you place a block.

ChefJisoo commented 11 months ago

The other thing these servers have in common is the fact that they have a plugin which uses ItemsAdder API to manipulate blocks in the world. Do you have any? Maybe a custom made one?

Can you attach a video of when the issue happens? As you said

Make custom blocks. Watch them change.

seems to be something happening right after you place a block.

Hi! Yes it does sometimes happen right after placing one, but it also happens over the course of several hours itll just change, hence its impossible to get a video of that, but i can get a video of them changing right after placing. we also do not use any plugins that manipulate other blocks to my knowledge, certainly not the IA API

ChefJisoo commented 11 months ago

The other thing these servers have in common is the fact that they have a plugin which uses ItemsAdder API to manipulate blocks in the world. Do you have any? Maybe a custom made one?

Can you attach a video of when the issue happens? As you said

Make custom blocks. Watch them change.

seems to be something happening right after you place a block.

could i adjust anything here (from config):

blocks: -- 215 | log-save-load: 216 | enabled: false 217 | min-ms: 0 218 | log-mined-unknown-blocks: true 219 | log-convert-vanilla-blocks: false 220 | log-fix-bugged-blocks: false 221 | log-unusual-block-break: false
LoneDev6 commented 11 months ago

Yes you can enable them, but it's hard to identify this issue since I don't have a clear step-by-step way to reproduce it also on my test server. We have to find out what is wrong in your server which is causing that.

How many players are playing while this happens? Does it happens very frequently or rarely?

potapenchikov commented 9 months ago

I have noticed that this happens when the user block comes into contact with water, lava and sand physics

LoneDev6 commented 9 months ago

Did they get the custom texture back if you interact with them? Also what do you see in chat when running /iablock command while targetting them?

100petr commented 9 months ago

this also happened on my server, but I don't know exactly how. but the answer to the last question: 2024-01-29_19 00 32 2024-01-29_19 00 36 if there is an interaction with it (some building/destroying of a block), a couple of blocks will be fixed. what I found quickly, but I have reports that blocks from blockus do it too https://www.spigotmc.org/resources/blocks-blockus-reimagined-itemsadder-addon.83918/ I don't know where the players have it from blockus, I'll add it when I find it

sometimes the trees are normal, sometimes there is this

LoneDev6 commented 9 months ago

This is quite strange since the plugin already handles these situations.

  fix-glitched-blocks:
    enabled: true
    only-new-chunks: false

This basically scans the chunk on load and fixes the blocks textures if they are wrong.

100petr commented 9 months ago

That's what I have right now. Next, I probably have all the biomes listed. Screenshot_20240130_131111_Samsung Internet Screenshot_20240130_131134_Samsung Internet

LoneDev6 commented 9 months ago

search-also-in-these-biomes can be completely removed as it's not available since 3.2.3i. ItemsAdder will search glitched block states in any biome.

100petr commented 9 months ago

The player wrote to me where he has the "bugged" blocks, I am sending iablock screenshots image image

He also wrote to me that it also happens to him while playing

LoneDev6 commented 9 months ago

We need a clear way to trigger this issue, without any precise way to trigger the issue I cannot fix it. It also could be related to another plugin causing block updates when not intended.

Note: if your players don't use vanilla chorus plants you can disable their physics in Paper configuration, this will allow custom blocks to avoid losing texture in any way. https://itemsadder.devs.beer/faq/blocks-minerals-issues/custom-blocks-glitch-texture/chorus-plants-real_transparent