Red Scoreboard Numbers not hidden on 1.19.3 server and 1.20+ clients

[CreationMC1]

Terms

• [X] I'm using the very latest version of ItemsAdder and its dependencies.
• [X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
• [X] I already searched on this Github page to check if the same issue was already reported.
• [X] I already searched on the plugin wiki to know if a solution is already known.
• [X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

creationmc

What happened?

The numbers on the scoreboard appear even when disabled within the configuration. Image is below as an example.

Steps to reproduce the issue

1 - Load up any scoreboard.

2 - Disable the red numbers in the items adder configuration.

3 - Watch as the numbers don't disappear.

Server version

This server is running Pufferfish version git-Pufferfish-29 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT)

ItemsAdder Version

3.6.2c

ProtocolLib Version

5.1.1-SNAPSHOT-673

LoneLibs Version

1.0.31

FULL server log

N/A

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

Image: https://i.imgur.com/tVsaPBI.png

[github-actions[bot]]

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

[LoneDev6]

Did you regenerate your resourcepack? It's important to regenerate it to enable/disable the feature.

[CreationMC1]

Yes, I did @LoneDev6 and the issue persisted.

Minecraft Versions: 1.20, 1.20.1, and 1.20.2 all work fine with the latest version (the numbers are not visible). On versions 1.20.3 and 1.20.4 - The numbers are visible.

[LoneDev6]

You might have another plugin or pack interfering with text shaders used by ItemsAdder to hide the numbers. Anyway 1.20.4 introduces a new way to hide scoreboard numbers and will be available in the next ItemsAdder update. https://github.com/PluginBugs/Issues-ItemsAdder/issues/3205

[ColorsASD]

Also, take into consideration that if the server itself is version 1.19.3 but, for example, it can connect with ViaVersion using version 1.20.4 or 1.20.3, then it will still display the numbers because this setting doesn't actually exist on 1.19.3.

effects:
  hide-scoreboard-numbers: true # No /iazip and supports 1.20.3+ clients SERVER-SIDE
  hide-scoreboard-numbers-new-clients-with-shaders: true # Requires /iazip to apply and supports 1.20.3 and high clients from old servers CLIENT-SIDE
  hide-scoreboard-numbers-old-clients: true # Requires /iazip to apply and supports 1.20.2 and lower clients CLIENT-SIDE

[LoneDev6]

I confirm that the new option hide-scoreboard-numbers is not working because 1.19.4 doesn't implement a packet used by ItemsAdder in 1.20.4 to remove the numbers from the scoreboard without using shaders.

In the next update I will fix the shader to support for 1.20.4 too.

NOTE: hide-scoreboard-numbers-old-clients won't work because you probably disabled text effects. I will work on new options to allow disabling text effects but keep the disable scoreboard options.

---

Tests

1.19.4 server and client

hide-scoreboard-numbers: false
hide-scoreboard-numbers-old-clients: true

Then run /iazip Uses shaders to do that.

1.20.4 server and client

hide-scoreboard-numbers: true
hide-scoreboard-numbers-old-clients: false

Doesn't use shaders to do that. No need to run /iazip.

1.20.4 server and 1.19.4 client

hide-scoreboard-numbers: true # Doesn't matter true/false
hide-scoreboard-numbers-old-clients: true

[LoneDev6]

Some tests with the new upcoming version

The new code shader works and still doesn't interfere with other game elements with the same color.

[ColorsASD]

Thank you for listening and that you will fix it in the near future. <3

[ColorsASD]

Clearly, the reference to text-effect is because it influences scoreboard-numbers. If you wish, you could add an additional setting related to text-effect, specifically one that removes the shadow from the text. This can also be achieved using color codes.

On Discord, you can find a solution, but some users complained that they don't understand why they need to disable text-effect, so adding a setting for it could address this concern.

Extremely useful for HUDs as it eliminates the shadow, making it look more aesthetically pleasing. You can supplement this setting.

  force_color:
    enabled: true
    color: '#FFFEFD'

(To my knowledge, this setting was created upon a user's request, as they also wanted to remove shadows.)

Discord link...

[LoneDev6]

text-effect: true is not required anymore to make hide-scoreboard-numbers-old-clients: true actually extract the needed shader. You can now disable text effects and hide the scoreboard numbers as I made a new shader for that only.

About the hide shadow suggestion, please open a new issue report and explain exactly what you want to achieve, I will take into consideration to bundle the suggested shader.

Thanks!

[xiaozhangup]

I would like to know how this is implemented in 1.20.3+, is there any documentation or other helpful information? Much appreciated!