PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
52 stars 21 forks source link

ItemsAdder and nChat Bug #3197

Open SrMonsterYT opened 9 months ago

SrMonsterYT commented 9 months ago

Terms

Discord tag (optional)

mauriciooficial

What happened?

video: https://www.youtube.com/watch?v=wQKjWYukA5Y

has an itemadder conflict with nchat, when typing in chat [item] when I type [item] it shows the item I have in my inventory

Steps to reproduce the issue

video: https://www.youtube.com/watch?v=wQKjWYukA5Y

Server version

Pufferfish version git-Pufferfish-27 (MC: 1.20.1)

ItemsAdder Version

ItemsAdder_3.6.2c

ProtocolLib Version

5.1.1-SNAPSHOT-673

LoneLibs Version

LoneLibs 1.0.31

FULL server log

no error

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

github-actions[bot] commented 9 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

LoneDev6 commented 8 months ago

It's related to this issue, I am waiting the Adventure API team to answer: https://github.com/KyoriPowered/adventure/issues/1025

It's basically caused by the fact that for some reason nChat is sending legacy hover raw messages to 1.16+ clients (it should not do that btw) and Adventure can't convert them for some reason.

SrMonsterYT commented 8 months ago

@LoneDev6 i updated itemadder to version 3.6.3-beta-7 and it bugged out again, do i have to stay on that version until it's fixed?

in version 3.6.2c.jar just do this and [item] works:

font_images: replace-in-customitems-name-and-lore: true chat: enabled: false add-hover-suggestion: false tab-autocompletion_1_19_1_plus: true

LoneDev6 commented 8 months ago

It's basically caused by the fact that for some reason nChat is sending legacy hover raw messages to 1.16+ clients (it should not do that btw) and Adventure can't convert them for some reason.

This is is basically a bug of nChat since they are using legacy hover event JSON components. Ask its developer to migrate to the modern version. I can't do anything against that. The only other solution is to wait the Adventure team to fix that in their API, but I doubt as legacy components are unsupported and should never be used anymore.