Unintended Tool Efficiency and Block Drop Behavior

Spike5032 commented 11 months ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

spike#5032

What happened?

I've encountered an unexpected behavior in our Minecraft mod configuration that affects the mechanics of block breaking and item drops. This issue manifests in two primary ways:

Tool Efficiency Anomaly: Tools, irrespective of their intended use, are able to break blocks instantaneously. For example, tools not typically used for breaking certain blocks (like dirt) are now able to do so with abnormal speed.
Unconventional Item Drops: When breaking blocks that wouldn't normally yield items in vanilla Minecraft, such as a stone wall with a shovel, the blocks now drop items. This is contrary to the expected behavior in the standard game mode.

This anomaly seems to be linked to the following script configuration:

events:
  block_break:
    multiple_break:
      keep_ores: false
      drop_all_blocks:
        enabled: true
        need_silk_touch: false
      size: 3

Impact The current configuration diminishes the necessity and uniqueness of various tools, as a single pickaxe becomes overly versatile and efficient. This significantly alters gameplay dynamics, making it overly easy to acquire materials. For instance, players can exploit this by placing easily breakable blocks like dirt next to harder materials like obsidian, breaking them with undue ease.

Proposed Resolution Adjust the plugin to align more closely with vanilla Minecraft's mechanics. Maybe group items by their tool meaning things like "Dirt,sand,gravel" would require a shovel to break when "Multiple-break" is on the item. Either that or allow for block blacklists on tools so that we can create one and make it where certain blocks are not affected with multiple break.

Steps to reproduce the issue

Make an wooden_shovel or any item with multiple_break Place 8 obsidian around the dirt. Break the dirt. Payday. it took you 2 seconds to mine 8 obsidian with a wooden shovel.

You can also use this to mine any block besides bedrock thats in your way without it taking into account that it cant break that item.

Server version

Purpur-2049 (MC: 1.20.1)

ItemsAdder Version

3.6.2c

ProtocolLib Version

5.1.1-Snapshot-673

LoneLibs Version

1.0.31

FULL server log

latest.log

Error (optional)

No response

Problematic items yml configuration file (optional)

info:
  namespace: oakheart
items:
  freds_digger:
    display_name: "&#6D0534F&#690530r&#65042ce&#610429d&#5d0425's
      &#54031cD&#4e0218i&#490213g&#44010Eg&#3F0109e&#3A0005r"
    permission: freds_digger
    lore:
      - ""
      - "&#e7e700◆ &#a9ff00S&#92fd00t&#7bfb00a&#64f900f&#4df700f
        &#36f500C&#1ff300o&#08f100l&#00ef00l&#00ed00e&#00eb00c&#00e900t&#00e700\
        i&#00e500o&#00e300n"
      - "&#787878&oGreat tool for digging holes for,"
      - "&#787878&ouhm, non-specific reasons.. :)"
    resource:
      material: NETHERITE_SHOVEL
      generate: true
      textures:
      - item/netherite_shovel.png
    enchants:
      - DIG_SPEED:5
      - DURABILITY:3
      - MENDING:1
    events:
      block_break:
        multiple_break:
          keep_ores: false
          drop_all_blocks:
            enabled: true
            need_silk_touch: false
          size: 3

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

A gif of the issue

github-actions[bot] commented 11 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

Spike5032 commented 10 months ago

This allows you to get alot of blocks you shouldnt be able too like budding amethyst & Reinforced deepslate.

PluginBugs / Issues-ItemsAdder