PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
53 stars 21 forks source link

Action cancel doesn't work when turn on cooldown(event_settings) #3266

Open IncludivicS opened 9 months ago

IncludivicS commented 9 months ago

Terms

Discord tag (optional)

includivics

What happened?

Action cancel doesn't work when turn on cooldown(event_settings). When I remove event_settings from config I can't open the chest when I put it back it can open the chest

Steps to reproduce the issue

add event_settings and set it cooldown that all.

Server version

This server is running Paper version git-Paper-361 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 5e978d3)

ItemsAdder Version

ItemsAdder version 3.6.3-beta-3

ProtocolLib Version

ProtocolLib version 5.2.0-SNAPSHOT-679

LoneLibs Version

LoneLibs version 1.0.42

FULL server log

latest.log

Error (optional)

No response

Problematic items yml configuration file (optional)

info: 
  namespace: harrypotter
items:
  elder_wand:
    enabled: true
    display_name: §5Elder Wand
    resource:
      material: STICK
      model_path: 'elder_wand/elder_wand'
      generate: false
    events_settings: #this line Dev
      cooldown:
        ticks: 60
        indicator: HUD
      cancel: true
    attribute_modifiers:
      mainhand:
        attackDamage: 0.1
        attackSpeed: 0.5
    all_actions_permission: wizard
    events:
      interact_mainhand:
        left:
          cancel: true
          shoot_particle:
            name: CRIT_MAGIC
            distance: 5
          damage_entity_in_sight:
            damage: 9999
            distance: 6
          play_sound_effect_failed:
            name: harrypotter:shoot01
            volume: 0.4
            pitch: 1
            flow:
              skip_if_success: damage_entity_in_sight
          play_sound:
            name: harrypotter:avada_kedavra
            volume: 0.8
            pitch: 1
            flow:
              stop_if_fail: damage_entity_in_sight
          play_sound_effect_success:
            name: harrypotter:shoot01
            volume: 0.4
            pitch: 1
            delay: 28
        right:
          cancel: true
          shoot_particle:
            name: FLAME
            distance: 9
          damage_entity_in_sight:
            damage: 11
            distance: 10
          play_sound_effect_failed:
            name: harrypotter:shoot01
            volume: 0.4
            pitch: 2
            flow:
              skip_if_success: damage_entity_in_sight
          play_sound_if_hit:
            name: harrypotter:stupefy
            volume: 0.7
            pitch: 1
            flow:
              stop_if_fail: damage_entity_in_sight
          play_sound:
            name: harrypotter:shoot01
            volume: 0.4
            pitch: 2
            delay: 15

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

github-actions[bot] commented 9 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

LoneDev6 commented 9 months ago

What are you trying to create? Sorry I don't understand.

Please write:

IncludivicS commented 9 months ago

When I use left click to the wheat on farm land it suppose to cancel that event but it not when I turn on the cooldown. Im sorry too. I gave you less information.

LoneDev6 commented 9 months ago

Because cancel doesn't exists in events_settings, no idea where you got that property.

    events_settings:
      cooldown:
        ticks: 60
        indicator: HUD
      cancel: true # Doesn't exists.

Basically your request is to add a way to avoid the player to interact with farmland when interacting while the cooldown is activated? Because in this case this other suggestion might be related: https://github.com/PluginBugs/Issues-ItemsAdder/issues/3062

IncludivicS commented 9 months ago

Because cancel doesn't exists in events_settings, no idea where you got that property.

    events_settings:
      cooldown:
        ticks: 60
        indicator: HUD
      cancel: true # Doesn't exists.

Basically your request is to add a way to avoid the player to interact with farmland when interacting while the cooldown is activated? Because in this case this other suggestion might be related: #3062

I just tried to add it every section but it still possible to break the farm land , open the door, etc...

LoneDev6 commented 9 months ago

But why do you want the farmland to not be destroyed if cooldown is going on? I don't see an actual gameplay logic in this. Please explain in detail why and what you want to do. Thanks

Also you didn't answer if the other feature request would satisfy your request or not: https://github.com/PluginBugs/Issues-ItemsAdder/issues/3266#issuecomment-1877204484

IncludivicS commented 9 months ago

for example the wizard fight each other with wand but when he right click to the door it open the door and shoot spell at the same time i want to prevent them to do that for fair situation.

LoneDev6 commented 9 months ago

Oh okay I see! Then the other suggestion will fix your issue once implemented.

3062