Scattered blocks instead of veins in world populators

cm4500 commented 5 months ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

cm4500

What happened?

When using world populators, the custom blocks do not generate as contiguous veins but instead a collection of blocks near each other.

I am wanting to create veins in a smaller but comparable size to that of perhaps diorite, granite, and andesite. But despite with tinkering with the "vein_blocks" and "chunk_veins" in the configs, I usually get "veins" with little to no actual blocks connected to each other. A picture is included below.

This problem has existed since I started using ItemsAdder with 1.20.1, and plugin version ItemsAdder_3.6.2c. Though below, you'll see the current versions I am using.

Steps to reproduce the issue

Use the world populator template provided on the ItemsAdder wiki. Replace the placeholders there with an actual block included in your pack, then adjust the values in "vein_blocks" and "chunk_veins" to your liking. My exact values are included in their own yml file below as a reference.

Server version

This server is running Paper version git-Paper-"a80d31b" (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: a80d31b) You are running the latest version Previous version: git-Paper-196 (MC: 1.20.1)

ItemsAdder Version

ItemsAdder version 3.6.3-beta-7

ProtocolLib Version

5.2.0-SNAPSHOT-679

LoneLibs Version

1.0.45

FULL server log

No response

Error (optional)

No response

Problematic items yml configuration file (optional)

info:
  namespace: blocks
  enabled: true
worlds_populators:
  fuchsite_6080:
    block: blocks:fuchsite
    worlds:
      - world
    replaceable_blocks:
      - STONE
      - DIRT
      - ANDESITE
      - GRANITE
      - COBBLESTONE
      - GRAVEL
      - DEEPSLATE
      - COBBLED_DEEPSLATE
      - CALCITE
      - TUFF
    chunk_chance: 50
    max_height: 80
    min_height: 60
    vein_blocks: 20
    chunk_veins: 1

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

2024-01-12_00 41 34

github-actions[bot] commented 5 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

LoneDev6 commented 5 months ago

Can you travel to the same place you made the screenshot and press F3+G to show the chunk borders? Thanks

cm4500 commented 5 months ago

Yes, attached are two screenshots of the same chunk as above. Now I have worldedited out the stone and gravel surrounding it so it is easier to see the entire vein from two different angles.

2024-01-15_12 30 21 2024-01-15_12 30 29

LoneDev6 commented 5 months ago

Will be checked, thank you. This is very strange as during testing this didn't happen (long time ago).

cm4500 commented 5 months ago

What is sort of interesting is that the surface decorators do not appear to have this problem. I am primarily using surface decorators for generating custom flowers across the world. And they all generate in contiguous veins. With ores generating scattered, it makes me wonder if these generating styles were swapped by mistake? If anything, both have their benefits.

Is it possible to actual keep both generation styles and have it be configurable for each populator? For example, the setting can be "connected_vein: true" which will have the veins all connected like you'd like expect from vanilla ores. Whereas if it is false, it will scatter in the manner of the original post - this how vanilla flowers tend to generate anyway. Just an idea!

Thanks so much for a great plugin.

LoneDev6 commented 5 months ago

it makes me wonder if these generating styles were swapped by mistake? If anything, both have their benefits.

Impossible as they use a completely different code.

Is it possible to actual keep both generation styles and have it be configurable for each populator? For example, the setting can be "connected_vein: true" ...

Well, this might be related to this other suggestion: #2435 (please ignore the customer being rude, this guy is known to harass me for years).

I will probably have to keep compatibility with the current ores generator to avoid old packs to have invalid generation values, because a new generation code might increase the number of blocks causing an unbalancement of the gameplay.

So the idea is to add a new property like vein_type which is defaulted to LEGACY and will access values like CONNECTED, SCATTERED or something similar. This page is also related: #1280

I will do some tests and provide actual examples and proofs of concept for these new ideas.

Note that the current ores generation was tested extensively during a period of a few months during the default pack rebalancement process. This process involved me and some other players testing the gameplay to see if ores were hard or easy to find, to rebalance the gameplay and the result was satisfying, so this issue report confuses me a little.

Here is more details about that:

Vanilla generation

My custom generation

As you can see, based on my tests, they look very similar to vanilla generated veins.

PluginBugs / Issues-ItemsAdder