When playing an emote while in another emote animation near other player(s), equipment will be returned before the new emote ends.

glutaminus commented 10 months ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

No response

What happened?

when I use emote without other players near me, everything seems fine. but when i play emote near player, my equipments aren't being hidden properly. (in video example I used left click for attack animation so I didn't /iaemote)

Steps to reproduce the issue

play iaemote somewhere around friends
some of equipment aren't hided properly (head,offhand,mainhand etc.)

Server version

git-Purpur-1985

ItemsAdder Version

3.6.3-beta-9

ProtocolLib Version

5.1.1-SNAPSHOT-673

LoneLibs Version

1.0.45

FULL server log

No response

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

https://www.dropbox.com/scl/fi/y2mdsxv2mq207uh5h875l/Minecraft_-1.19.4-Multiplayer-3rd-party-Server-2024-01-30-00-32-57.mp4?rlkey=lgjar179k1s2yth8yhi1ami4d&dl=0

github-actions[bot] commented 10 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

glutaminus commented 10 months ago

from the video, you can clearly see that after I tp'd to my friend and play emote while holding the sword. the sword is not disappear from slot like the first tried.

LoneDev6 commented 10 months ago

Interesting. I will do some tests to see if I can reproduce it on a clean environment.

glutaminus commented 6 months ago

@LoneDev6 sorry for the ping! could you explain what is happening and the big mystery for me is why is it only happen when there're 2+ players? And it seems to happen when emotes are playing next to each others.. So I doubt that it might be about emote's on start/on end problem. Is there any solution for this? this is really a big problem, so I desperately hope it's not stalled..

glutaminus commented 6 months ago

here's a clearer test, It's easier to notice when we use Looping emote and bigger assessories (hence why it was a big problem)

having another account near
/iaemote death_3
/iaemote death_3
keep repeating until your hand/off hand/head item are being returned even though the new emote wasn't ended (its happens easily)

https://github.com/PluginBugs/Issues-ItemsAdder/assets/90768288/96b11eae-7a8e-4d54-b9bb-4c1c5e53bb4b

It's not about the speed too. Even if I waited for seconds, then play another emote it's still gonna bug

ps. sometimes items are hidden in self perspective, but not in other players' perspective, and sometimes items are hidden only in other players' perspective.

glutaminus commented 6 months ago

https://github.com/PluginBugs/Issues-ItemsAdder/assets/90768288/9a3a7310-7e3d-48bc-8df6-7a98b44e3de0

here's example on both screen, sometimes it hide only for others and sometimes it's only for self.

glutaminus commented 6 months ago

@LoneDev6 Sorry again! I don't wanna be annoying, (but please understand me that I've been waiting for 4 months.) I need your notice and need confirmation if this is fixable, it's totally fine if you don't take this as main priority! as emote was just one aspect of your plugin, but since you put this issue to stalled section, I just need to know so I can continue with my plans on my server. (IA emote system play a very big part on it)

Pizza1150 commented 5 months ago

bump

glutaminus commented 5 months ago

I've heard about stop supporting lower versions minecraft in IA 4.0+? If you do, when you (could) fix this bug, can you also fix it in 3.6+ I think emote system should use same logic in 4.0+ too, right? I'm still not ready to move to 1.20.6 yet, and many other plugins are still not supporting 1.20.6 to be honest, all I need was this emote bug to be fixed before you discontinue this version, since it's the biggest gameplay graphic breaking afaik for emote system. (Sorry, I know it's messy for you to update 2 builds at same time)

PluginBugs / Issues-ItemsAdder