Player emotes bug out for third part viewers when they are further away

Bambizo commented 7 months ago

Terms

[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

bambizo

What happened?

Emotes function properly, but we've noticed a visual issue when players are at a greater distance from each other. If a player observes another executing an emote from afar, the distant player's model appears significantly distorted. This includes misaligned joints and overall abnormal body configurations. However, this ins't an issue when the observing player is in closer proximity; the emotes display perfectly at a shorter distance. The anomaly seems exclusive to situations where there's considerable space between players.

Link to the image regarding to bug: https://imgur.com/a/F8LH3VX

Steps to reproduce the issue

Have two players to begin with;
Be at least 50 or more blocks away from each other;
Let one player perform one of the emotes (I tested death animations 1 & 2);
When the player is in that emote state, have the other player come closer and observe.

Server version

This server is running Paper version git-Paper-280 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 4675152)

ItemsAdder Version

ItemsAdder version 3.6.2c

ProtocolLib Version

ProtocolLib version 5.1.1-SNAPSHOT-673

LoneLibs Version

LoneLibs version 1.0.31

FULL server log

[00:05:47] [Craft Scheduler Thread - 4000 - Vault/INFO]: [Vault] Checking for Updates ... [00:05:47] [Craft Scheduler Thread - 4000 - Vault/INFO]: [Vault] No new version available [04:21:31] [Server thread/INFO]: Unknown command. Type "/help" for help. [04:21:38] [Server thread/INFO]: Checking version, please wait... [04:21:38] [Thread-586/INFO]: This server is running Paper version git-Paper-280 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 4675152) You are 38 version(s) behind Download the new version at: https://papermc.io/downloads/paper Previous version: git-Paper-550 (MC: 1.19.4) [04:22:10] [Server thread/INFO]: ItemsAdder version 3.6.2c [04:22:10] [Server thread/INFO]: Customized Minecraft without client mods! [04:22:10] [Server thread/INFO]: Website: devs.beer [04:22:10] [Server thread/INFO]: Author: LoneDev [04:22:36] [Server thread/INFO]: ProtocolLib version 5.1.1-SNAPSHOT-673 [04:22:36] [Server thread/INFO]: Provides read/write access to the Minecraft protocol. [04:22:36] [Server thread/INFO]: Authors: dmulloy2 and comphenix [04:22:55] [Server thread/INFO]: LoneLibs version 1.0.31 [04:22:55] [Server thread/INFO]: Collection of libs used by my plugins [04:22:55] [Server thread/INFO]: Authors: LoneDev and others

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

github-actions[bot] commented 7 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

LoneDev6 commented 7 months ago

It's probably related to the packets optimization. Not all packets are sent when players are very far, to avoid useless processing. I will do some testing to see if this can be mitigated without introducing overhead.

Bambizo commented 7 months ago

It's probably related to the packets optimization. Not all packets are sent when players are very far, to avoid useless processing. I will do some testing to see if this can be mitigated without introducing overhead.

Is the issue resolved?

PluginBugs / Issues-ItemsAdder