music_disc behaviour not behaving like a music_disc

Tizooo commented 5 months ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

Tizooo

What happened?

if creating a music_disk sound like shown in the wiki and putting it into a jukebox there are several issues that appear.

if you run/tp away from the jukebox you still hear the custom sound and it does not have a volume range if going away from the jukebox.
if you join while the custom jukebox sound is playing you dont hear the music (also if ur not in range of the jukebox when it started)
if the jukebox is in a specific place it cant play custom music disks but vanilla ones.

Steps to reproduce the issue

make a custom sound make the sound a custom music disk put it into a jukebox and for example fly away from it see that the range is infinite

Server version

This server is running Pufferfish version git-Pufferfish-32 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: cba8555 on HEAD) You are running 12 versions beyond. Please update your server when possible to maintain stability, security, and receive the latest optimizations. Previous version: git-Pufferfish-29 (MC: 1.20.2)

ItemsAdder Version

3.6.3-beta-11

ProtocolLib Version

5.1.1-SNAPSHOT

LoneLibs Version

1.0.45

FULL server log

No response

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

my_sounds.zip

Screenshots/Videos (you can drag and drop files or paste links)

No response

github-actions[bot] commented 5 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

LoneDev6 commented 5 months ago

if you run/tp away from the jukebox you still hear the custom sound and it does not have a volume range if going away from the jukebox.

This is probably caused by the fact that your OGG music is stereo. You must set it as mono, or the game bugs out and you hear the music anywhere. https://itemsadder.devs.beer/plugin-usage/adding-content/sounds/convert-mp3-to-ogg Caused by this Minecraft bug: https://bugs.mojang.com/browse/MC-146721

if you join while the custom jukebox sound is playing you dont hear the music (also if ur not in range of the jukebox when it started)

This is normal, I currently have no easy way to implement support for that particular case without causing overhead. I might find a solution in the future.

if the jukebox is in a specific place it cant play custom music disks but vanilla ones.

I don't understand

Tizooo commented 5 months ago

u dont hear the direction the music comes from. i think you maybe just made it so the sound plays for everyone in range on start. insted you could maybe make it play at the position at the jukebox and make a sound range?

LoneDev6 commented 5 months ago

Should already be like that, I'll do some testing and let you know, but the sound source should already be the jukebox location

Tizooo commented 5 months ago

Hey! ty for looking ito it. i made a short video which shows 2 issues. the first beeing the place of the jukebox that does not work and the 2. that the range of the custom music is way lower than the normal vanilla music.

https://medal.tv/games/minecraft/clips/1TETsNifvt06Ez/d1337RNj3jUw?invite=cr-MSxJeDYsMTI4NzE2OTcs

LoneDev6 commented 4 months ago

okay so basically the issues are two:

jukebox won't play anything if it's under the player and surrounded by loom?
jukebox play range is low compared to vanilla

Correct?

Tizooo commented 4 months ago

issue idk exactly why.
issue yes its way lower than vanilla music range

PluginBugs / Issues-ItemsAdder