Open P5ina opened 5 months ago
Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.
Thanks a lot for your patience.
I fixed "end of file error" by updating field server-ip
to http://hrizolight.ru
, but still, issue is presented
Okey, I found the issue, storage
folder was unsynchronized, closing the issue
Nah, it appeared again
There's more info, when transitioning from server to server, resourcepack doesn't unloads
Okey, I found the issue, storage folder was unsynchronized, closing the issue
So it wasn't the issue?
There's more info, when transitioning from server to server, resourcepack doesn't unloads
It's how Minecraft 1.20.4+ works now, it's a "feature". Basically the pack doesn't get removed during servers changes (proxy like Bungeecord and Velocity). It might be worth adding a setting in the ItemsAdder configuration to force the client to unload the pack on server change, but idk if this might cause more confusion.
So it wasn't the issue?
Yes, that's not the problem. The problem is that when plugin tries to load the resource pack again, itemsadder thinks that it is not loaded, but in fact it has already been loaded from the previous server
Is it possible to receive resource packs loaded on the client? Then the fix would simply be to check before loading the resource pack whether it is loaded
The reason might be because you have two packs with two different URLs. The plugin can differentiate packs by their URL and unique id.
The reason might be because you have two packs with two different URLs.
The plugin can differentiate packs by their URL and unique id.
But as you can see in configs URLs are the same.
Can you try with the latest beta 13?
Can you try with the latest beta 13?
Still the same issue
Thanks a lot for the patience, I will setup a proxy and test the issue as soon as I can. In the meantime set no-host on the other server to avoid the player to get stuck. They will still have the resourcepack installed because they joined the first server.
Ok, thanks, I'll wait.
I can confirm this as an issue. It was working normally (tested on velocity 3.2.0-SNAPSHOT). With the newest velocity it doesn't work - the resourcepack is not sent which makes player stuck at loading screen (/iatexture does nothing)
This issue is quite strange, @MsMaciek123 can you tell me which velocity version has no issue and which has the issue? So that I can check their recent code changes and see why this happens. Thanks
paper server (1.20.4) plugins: ItemsAdder, LoneLibs, ProtocolLib, ViaBackwards, ViaVersion
client 1.20.4 - newest velocity, works client 1.20.2 - newest velocity, stuck at applying resourcepack (it doesn't even start to load)
Velocity version where it stops working: velocity-3.3.0-SNAPSHOT-358 https://github.com/PaperMC/velocity/commit/ef861819e336b0466e4f5138d597223c3de8c5e4
However I'm not sure who should fix the issue (velocity, viaversion or itemsadder).
Terms
Discord tag (optional)
p5ina
What happened?
Resource pack doesn't download if you using external hosting and link to other self-hosted itemsadder resource pack. My servers connected using velocity, and resource pack works perfectly fine only on "self-hosted" server. I'm running proxy and both servers in docker, maybe that's the issue?
Also, when "external host" server is booting, it says that "Unexpected end of file from server" and if you run![CleanShot 2024-02-18 at 14 26 28@2x](https://github.com/PluginBugs/Issues-ItemsAdder/assets/44378225/f51c0f80-de48-4ccf-989f-1cfd4a28acf1)
/iazip
on self-hosted server it gives you very strange path:Steps to reproduce the issue
Server version
Current: git-Purpur-2143 (MC: 1.20.4)*
ItemsAdder Version
ItemsAdder version 3.6.3-beta-12
ProtocolLib Version
ProtocolLib version 5.2.0-SNAPSHOT-679
LoneLibs Version
LoneLibs version 1.0.45
FULL server log
"External host" server logs
Error (optional)
Problematic items yml configuration file (optional)
Other files, you can drag and drop them here to upload. (optional)
"Self hosted" server configuration:
Screenshots/Videos (you can drag and drop files or paste links)
In this example lobby is "self-hosted" server and general is "external host"
https://github.com/PluginBugs/Issues-ItemsAdder/assets/44378225/d71265a0-427f-43ec-a242-e6e1b4052956