Item frame furniture can be stacked in one place

Dogg123 commented 8 months ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

No response

What happened?

I have searched everywhere for the solution, but couldn't find any. I want to make a vine block, but got stuck on an issue, where multiple fiurniture blocks can be placed on the same location

Steps to reproduce the issue

Create an item frame furniture
Place it down 3 Place the furniture on the edge of the block

Server version

1.19.4

ItemsAdder Version

3.6.3-beta-13

ProtocolLib Version

5.1.0

LoneLibs Version

1.0.45

FULL server log

No response

Error (optional)

No response

Problematic items yml configuration file (optional)

  hedera_placed:
    display_name: "Hedera"
    resource:
      material: PAPER
      generate: false
      model_path: block/hedera_placed
    behaviours:
      furniture:
        shift_interact_rotate: false
        entity: item_frame
        solid: false
        fixed_rotation: true
        cancel_drop: true
        placeable_on:
          floor: true
          ceiling: true
          walls: true
        hitbox:
          length: 1
          width: 1
          height: 0.15
        sound:
          place:
            name: block.azalea.place
          break:
            name: block.azalea.break
    events:
      placed_itemframe:
        interact:
            place_block:
              furniture: pebbles_placed
        break:
          drop_item:
            item: hedera
  hedera:
    display_name: Wall hedera vines
    lore:
     - 'none'
    resource:
      material: PAPER
      generate: true
      textures:
      - item/hedera
    events:
      interact:
        right:
          place_furniture:
            furniture: hedera_placed
            decrement_amount: true
        right_shift:
          place_furniture:
            furniture: hedera_placed
            decrement_amount: true

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

place it down hover on the edge of the block place

github-actions[bot] commented 8 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

Dogg123 commented 8 months ago

The same issue was mentioned in here: https://github.com/PluginBugs/Issues-ItemsAdder/issues/3014 But I was still able to replicate the problem

potapenchikov commented 8 months ago

Yes, it's harder to do now, but it's still possible. I noticed this completely by accident and I tracked the position from the very edge of the block where the next face begins. I thought this could be fixed by increasing the hitbox by 0.1, but this does not solve the problem. It's pretty frustrating if players can use the entire furniture limit on one block and close another block on top, you'll just never know where all this furniture is

potapenchikov commented 8 months ago

It would also be good to prohibit putting any blocks on top of furniture using ITEM_FRAME

PluginBugs / Issues-ItemsAdder