Tree generator will not use custom blocks for certain tree types at all

ofunny commented 4 months ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I already searched on this Github page to check if the same issue was already reported.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.

Discord tag (optional)

ofunny

What happened?

According to https://itemsadder.devs.beer/plugin-usage/adding-content/trees-populators/populator the regular Spigot API enum TreeType represents all trees the attribute tree_type would except, also there is a note

Vanilla trees bug
Sometimes trees will spawn with vanilla leaves, this is a known issue and I have no solution for this. Seems to be a Minecraft/Spigot bug, seems an event used by IA sometimes is not triggered.

However, for certain types like CHERRY, AZALEA, CHORUS_PLANT, RED_MUSHROOM, etc. (have not tested all of them) this does not work at all, not just sometimes, it will always spawn with the default blocks.

And two more questions

Is it possible to get a variety into the leave blocks a tree will use, so it would mix it a bit (e.g. one with fruits and one without)?
Is it normal that trees instantly grow up when one places a sapling, that is what happens to me at least at the moment?

And a suggestion

Wouldn't it be nice if you could define your own tree presets?

Thanks in advance

Steps to reproduce the issue

Add trees to a tree populator with custom leaves and logs of type CHERRY, AZALEA, CHORUS_PLANT, RED_MUSHROOM, etc.
Update config and pack
Spawn the trees via sapling

Server version

No response

ItemsAdder Version

ItemsAdder version 3.6.3-beta-13

ProtocolLib Version

ProtocolLib version 5.2.0

LoneLibs Version

LoneLibs version 1.0.45

FULL server log

On request only

Error (optional)

none

Problematic items yml configuration file (optional)

info:
  namespace: forestry
trees_populators:
  avocado_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    ##chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: AZALEA
    log: forestry:avocado_tree_log
    leaves: forestry:avocado_tree_leaves
    biomes:
    - FOREST
    - BIRCH_FOREST
    - RIVER
  #  - FOREST_HILLS
  #  - BIRCH_HILLS
    - DARK_FOREST
    - FLOWER_FOREST
    - TALL_BIRCH_FOREST
    - DARK_FOREST_HILLS    
  banana_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: CHORUS_PLANT
    log: forestry:banana_tree_log
    leaves: forestry:banana_tree_leaves
    biomes:
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
    - SAVANNA
  cherry_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: CHERRY
    log: forestry:cherry_tree_log
    leaves: forestry:cherry_tree_leaves
    biomes:
    - PLAINS
    - SUNFLOWER_PLAINS
  decaying_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: SWAMP
    log: forestry:decaying_tree_log
    leaves: forestry:decaying_tree_leaves
    biomes:
    - ICE_SPIKES
    - SWAMP
    - SWAMP_HILLS
  dragonfruit_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: RED_MUSHROOM
    log: forestry:dragonfruit_tree_log
    leaves: forestry:dragonfruit_tree_leaves
    biomes:
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
    - SAVANNA
  guava_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: ACACIA
    log: forestry:guava_tree_log
    leaves: forestry:guava_tree_leaves
    biomes:
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
    - SAVANNA
  lemon_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: AZALEA
    log: forestry:lemon_tree_log
    leaves: forestry:lemon_tree_leaves
    biomes:
    - SAVANNA
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
  lime_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: AZALEA
    log: forestry:lime_tree_log
    leaves: forestry:lime_tree_leaves
    biomes:
    - SAVANNA
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
  mango_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: AZALEA
    log: forestry:mango_tree_log
    leaves: forestry:mango_tree_leaves
    biomes:
    - SAVANNA
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
  maple_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: BIRCH
    log: forestry:maple_tree_log
    leaves: forestry:maple_tree_leaves
    biomes:
    - SNOWY_TUNDRA
    - SNOWY_TAIGA
    - SNOWY_TAIGA_MOUNTAINS
    - TAIGA
    - TAIGA_MOUNTAINS
    - GIANT_TREE_TAIGA
    - GIANT_SPRUCE_TAIGA
  nut_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: SMALL_JUNGLE
    log: forestry:nut_tree_log
    leaves: forestry:nut_tree_leaves
    biomes:
    - FOREST
    - BIRCH_FOREST
    - RIVER
#    - FOREST_HILLS
#    - BIRCH_HILLS
    - DARK_FOREST
    - FLOWER_FOREST
    - TALL_BIRCH_FOREST
    - DARK_FOREST_HILLS  
  olive_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: ACACIA
    log: forestry:olive_tree_log
    leaves: forestry:olive_tree_leaves
    biomes:
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
  orange_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: AZALEA
    log: forestry:orange_tree_log
    leaves: forestry:orange_tree_leaves
    biomes:
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
  palm_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: CHORUS_PLANT
    log: forestry:palm_tree_log
    leaves: forestry:palm_tree_leaves
    biomes:
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
    - BEACH
  passionfruit_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: JUNGLE_BUSH
    log: forestry:passionfruit_tree_log
    leaves: forestry:passionfruit_tree_leaves
    biomes:
    - SAVANNA
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
  peach_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: CHERRY
    log: forestry:peach_tree_log
    leaves: forestry:peach_tree_leaves
    biomes:
    - SAVANNA
    - JUNGLE
    - JUNGLE_EDGE
    - JUNGLE_HILLS
    - MODIFIED_JUNGLE
    - MODIFIED_JUNGLE_EDGE
  plum_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: CHERRY
    log: forestry:plum_tree_log
    leaves: forestry:plum_tree_leaves
    biomes:
    - FOREST
    - BIRCH_FOREST
    - RIVER
#    - FOREST_HILLS
#    - BIRCH_HILLS
    - DARK_FOREST
    - FLOWER_FOREST
    - TALL_BIRCH_FOREST
    - DARK_FOREST_HILLS
  prune_tree:
    worlds:
    - development
    bottom_blocks:
    - DIRT
    - GRASS_BLOCK
    - PODZOL
    #chance: 5.0
    chance: 0.0
    max_height: 200
    min_height: 50
    amount: 3
    iterations: 2
    tree_type: CHERRY
    log: forestry:prune_tree_log
    leaves: forestry:prune_tree_leaves
    biomes:
    - FOREST
    - BIRCH_FOREST
    - RIVER
#    - FOREST_HILLS
#    - BIRCH_HILLS
    - DARK_FOREST
    - FLOWER_FOREST
    - TALL_BIRCH_FOREST
    - DARK_FOREST_HILLS

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

github-actions[bot] commented 4 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

Andre601 commented 4 months ago

FULL server log

On request only

Please fill out the form properly, as leaving out parts such as the logs will also leave out crucial information we need to properly help you.

If you fear sharing logs due to privacy, I recommend using http://mclo.gs, which automatically censores IPs and other sensitive information.

ofunny commented 4 months ago

FULL server log

On request only

Please fill out the form properly, as leaving out parts such as the logs will also leave out crucial information we need to properly help you.

If you fear sharing logs due to privacy, I recommend using http://mclo.gs, which automatically censores IPs and other sensitive information.

There are no crucial information in this log and I'm not sharing my full server logs publicly. If you still want it, please get back with a way to send it privately!

Andre601 commented 4 months ago

Without sharing your logs, we can't provide you any support. Also, logs do not have any form of sensitive information, outside IPs which mclogs is censoring, that would warrant not sending them.

ofunny commented 4 months ago

Without sharing your logs, we can't provide you any support. Also, logs do not have any form of sensitive information, outside IPs which mclogs is censoring, that would warrant not sending them.

Logs reveal insides of plugins I'm using, the server itself, some config prints and player and IP names, especially player and IP names, what I'm not allowed to share with any service I have no agreement with or my players consented to under GDPR - this is indisputable. I can pass the information either privately for technical purpose, I can give you selected information from my logs, that you specifically need and as a dev I know, that all you see there is what my server version is, what other plugins I'm using and what libs getting loaded in the beginning and the initial config print of IA, nothing I could not share on request, just not a whole log paste. Especially since there are no error prints.

And again, I'm even willing to share it privately, but I won't break European law, for a problem, that has never existed before. If this is a deal breaker for fixing an obvious plugin issue, so be it.

Andre601 commented 4 months ago

Logs reveal insides of plugins I'm using, the server itself, some config prints and player and IP names, especially player and IP names, what I'm not allowed to share with any service I have no agreement with or my players consented to under GDPR - this is indisputable.

That isn't quite how the GDPR works. By the logic you give here would MC not even be allowed, given the client is providing the IP to the server too. I want to mention again that mclogs would automatically censor any IPs and folder-paths, meaning an IP like 127.0.0.1 becomes ***.*.*.*, so if the GDPR would apply here - which it doesn't - would this not be a violation of it, given the info is properly censored.

Also, there is nothing in your plugins a user here would be interested in stealing, unless you would visibly display sensitive information like database IPs and passwords, which would be a bad design decision on your end.

So, I'm asking you again to just share the logs through https://mclo.gs as we otherwsie can not and will not provide support.

ofunny commented 4 months ago

About the client to server issue, well yes, in strict terms you would have to ask your user base to process/forward personal data provided (to which user and ip belongs), otherwise the user and IP, except for technical relevant operations, has to be deleted in time and therefore can not be passed on to third parties like "mclo". Of course there is a user agreement that players first accept if they login to Minecraft itself, that however does not cover me processing data in the mentioned way with 3rd parties.

Since you refuse to ask for selected data or to take the log via a private channel, I sadly have to end the conversation here. I can not operate beyond GDPR or other laws.

LoneDev6 commented 4 months ago

Please keep the GDPR and stuff outside of this topic.

However, for certain types like CHERRY, AZALEA, CHORUS_PLANT, RED_MUSHROOM, etc. (have not tested all of them) this does not work at all, not just sometimes, it will always spawn with the default blocks.

This definitely seems to be a bug, I will check out why this happens. Strange because I use the internal game code to spawn trees, so something's wrong. Thanks for the patience!

ofunny commented 4 months ago

Thank you, really appreciate that, but it's not urgent at all, using normal TREE types for now what work fine. In case this is server version or API related, I tested it on: Paper version git-Paper-493 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT)

Please keep the GDPR and stuff outside of this topic.

Would not have started it at all, the other contributor just was not willing to get my point of not publicly sharing my whole logs, but I think it's settled now :)

PluginBugs / Issues-ItemsAdder