PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
51 stars 21 forks source link

Split resourcepack in multiple sub-resourcepacks #3606

Open Verdux opened 4 months ago

Verdux commented 4 months ago

Terms

Discord tag (optional)

Verum1

Describe the solution you'd like

As of 1.20.4, we can now send multiple resource packs to the player upon join. This allows us to bypass the 250mb pack limit and would allow to split packs across multiple servers, to make a "core" pack work better alongside others.

Is your feature request related to a problem?

Currently resource packs are limited to 250mb and hosting different packs on each server can be tedious to maintain. Having it all handled on one server and simply configure it to send upon joining X server would make the process smoother.

Describe alternatives you've considered

Only alternative would be to run multiple plugins which handle resourcepack hosting... not ideal.

Additional context

No response

github-actions[bot] commented 4 months ago

Hello, your report will be looked into as soon as possible. Please do not bump this thread and don't post it on multiple platforms.

Thanks a lot for your patience.

Andre601 commented 4 months ago

Multiple RP support would be nice, but currently suffers from one major issue: JSON files for stuff like Custom Model Data aren't merged, meaning that for one item you won't have all values applied, resulting in broken textures most likely.

LoneDev6 commented 4 months ago

250MB is enough for a pack. I would personally be very pissed to have to download more than 250MB while joining a MINECRAFT server. This idea is good, but it would introduce a ton of abuse, and we all know how people love to abuse features and then complain.

Anyway the only thing that I personally see as a good usage of this feature is that you could separate music/sounds pack from all other assets, nothing more.

Anyway I also doubt you can reference textures/models of a pack from other packs, but maybe I'm wrong. If that's true you might end up having to duplicate textures/models between packs in order to reference them.

Let me know if you think I'm tripping or not. Have a nice week!

Verdux commented 4 months ago

Honestly, just the sound example alone could be something worthwhile. An additional optional pack for sounds for those that are willing to download a beefy pack on join. Especially when it's a one time download thing and won't require someone to download another 100mb pack every time you make a small change like adding a new sword texture.

The ability to split up packs into stuff that changes often and stuff that rarely changes, to better optimise the experience for returning players, I could certainly see the benefits of splitting my packs up. I'm more likely to add some new items/pets far more often than furniture. So to let someone download a 5mb pack because I added a new pet, rather than a 25mb pack because I added a pet would make for a good improvement.

LoneDev6 commented 4 months ago

I have first to make some tests, because if splitting actually works (stating that you successfully install all required sub-packs) it's a cool feature, so people will need to download only the edited sub-pack.

An example, as you said could be:

This also needs to be somehow configurable in ItemsAdder config for an automatic generation so people won't need to bother about that.