PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
53 stars 21 forks source link

Rename plugin to "ResourcePack manager" #3789

Closed szarkans closed 3 months ago

szarkans commented 3 months ago

Terms

Discord tag (optional)

No response

What happened?

Plugin named "Items Adder" have less functionality for adding items than a plugin for custom fishing, custom crops or any other good plugin for item managment.

No custom NBT/Components support, bad furniture support, bad glyphs feature, that require set up every symbol manually for proper working and many more problems.

As is - rename this "items" "adder" plugin to what it really is - ResourcePack Manager. Or start to make it really "items" "adder" plugin.

image

Steps to reproduce the issue

  1. Download this plugin
  2. Do anything with it harder than adding display name or custommodeldata

Server version

Every

ItemsAdder Version

Every

ProtocolLib Version

Not important

LoneLibs Version

Not important

Full server log

No response

Error (optional)

No error

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

Andre601 commented 3 months ago

ItemsAdder does exactly what it says on the tin: It adds items you configure.

I can't see your problem here. All I see is you opening an issue to shit on a plugin for no justifiable reason. Please avoid such issues, thanks.

szarkans commented 3 months ago

ItemsAdder does exactly what it says on the tin: It adds items you configure.

Adding display name or attributes that hard-coded to plugin or anything is not exactly good adding items feature.

Andre601 commented 3 months ago

Also, I'll cover some of your claims and effectively debunk them, given that what you post here is basically misleading info.

Plugin named "Items Adder" have less functionality for adding items than a plugin for custom fishing, custom crops or any other good plugin for item managment.

No custom NBT/Components support, bad furniture support, bad glyphs feature, that require set up every symbol manually for proper working and many more problems.

Custom NBT is possible and has been since quite a long time already.

Furniture support is as good as it can get. I cannot see any system that would be better here outside of what ItemsAdder does right now, which is to use Armor Stands or Item Frames on v3 and Item/Block Display Entities on v4 with barrier blocks for collission boxes.

Glyphs, by which you most likely mean font images, do not require a manual setup for each character. All you do is configure them like you would with items and IA automatically applies the image to a unused unicode character that can then be referenced either with :font_image_name: or %img_font_image_name% (Uses PlaceholderAPI), which also both have the benefit that should the unicode character used change in the future, that you won't have to update it everywhere it's used.

Granted, the :emoji: pattern may not work reliably across all plugins, but that is due to ItemsAdder having to listen for packets to modify stuff accordingly, which cannot be 100% reliable, as another plugin can always listen for it at a later stage, changing stuff.

As of right now does ItemsAdder the following stuff, which others may or may not do:

As is - rename this "items" "adder" plugin to what it really is - ResourcePack Manager. Or start to make it really "items" "adder" plugin.

By that logic would plugins such as Nova, Oraxen, etc. also only be ResourcePack Manager, as they do the same things. You seem like the kind of person who got the plugin, don't understand how to configure it or why it doesn't come with a set of items and instead of checking the wiki and realizing you have to work here to make stuff function, complain about it being crap with little to no proof in the end.