PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
51 stars 21 forks source link

ItemsAdder PlayerInteractEvent causes lag #3794

Open Lia-LV opened 1 month ago

Lia-LV commented 1 month ago

Terms

Discord tag (optional)

lia_lv

What happened?

Server lag occurs from ItemsAdder PlayerInteractEvent

Steps to reproduce the issue

using ItemsAdder Rightclick (mainhand) event?

Server version

Paper version 1.20.6-148-ver/1.20.6@20f5165 (Implementing API version 1.20.6-R0.1-SNAPSHOT)

ItemsAdder Version

4.0.1-alpha-test-5

ProtocolLib Version

5.3.0-SNAPSHOT-723

LoneLibs Version

1.0.55

Full server log

No response

Error (optional)

none

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

image

Screenshots/Videos (you can drag and drop files or paste links)

No response

Andre601 commented 1 month ago

Please use a proper profiler, such as Spark from Lucko, and not the Timings API. It's bad at really showing causes of lag and Paper themself recommend using Spark instead.

Lia-LV commented 1 month ago

Please use a proper profiler, such as Spark from Lucko, and not the Timings API. It's bad at really showing causes of lag and Paper themself recommend using Spark instead.

Yea I know that, Timings isn't cool things. but I can't use Spark. idk why can't use Spark, may Paper latest version isn't installed as a default, I'll put Spark in my plugin folder next time.

Lia-LV commented 1 month ago

@Andre601 image Lag caused by ItemsAdder occurred again. This time, I profiled it with Spark, but it is not clear for me because of code obfuscation. however, lag is severe, so please fix it quickly.

https://spark.lucko.me/yLrngm9L3h

LoneDev6 commented 1 week ago

Will be fixed, thanks a lot.