search

PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
52 stars 21 forks source link

`HIDE_ATTRIBUTES` flag doesn't work when `fix-show-attack-and-damage-as-lore: true` #3811

Closed lechatdeschats closed 4 weeks ago

lechatdeschats commented 2 months ago

Terms

Discord tag (optional)

lechatdeschats

What happened?

don't hide attributes

Steps to reproduce the issue

use my version of the plugins and put my code Items Adder

Server version

[00:37:41 INFO]: This server is running Paper version git-Paper-260 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 1865625) You are 58 version(s) behind Download the new version at: https://papermc.io/downloads/paper

ItemsAdder Version

[00:38:20 INFO]: ItemsAdder version 3.6.4-release-3 [00:38:20 INFO]: Customized Minecraft without client mods! [00:38:20 INFO]: Website: devs.beer [00:38:20 INFO]: Author: LoneDev

ProtocolLib Version

[00:38:36 INFO]: ProtocolLib version 5.2.0-SNAPSHOT-679 [00:38:36 INFO]: Provides read/write access to the Minecraft protocol. [00:38:36 INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

[00:38:49 INFO]: LoneLibs version 1.0.55 [00:38:49 INFO]: Collection of libs used by my plugins [00:38:49 INFO]: Authors: LoneDev and others

Full server log

WARNING: Using incubator modules: jdk.incubator.vector Starting org.bukkit.craftbukkit.Main Warning, you've not updated in a while! Please download a new build as per instructions from https://papermc.io/downloads/paper System Info: Java 17 (Java HotSpot(TM) 64-Bit Server VM 17.0.10+11-LTS-240) Host: Windows 11 10.0 (amd64) Loading libraries, please wait... [19:02:05 INFO]: Environment: Environment[accountsHost=https://api.mojang.com, sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD] [19:02:07 INFO]: Loaded 7 recipes [19:02:08 INFO]: Starting minecraft server version 1.20.2 [19:02:08 INFO]: Loading properties [19:02:08 INFO]: This server is running Paper version git-Paper-260 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 1865625) [19:02:09 INFO]: Using 4 threads for Netty based IO [19:02:09 INFO]: Server Ping Player Sample Count: 12 [19:02:09 WARN]: [!] The timings profiler has been enabled but has been scheduled for removal from Paper in the future. We recommend installing the spark profiler as a replacement: https://spark.lucko.me/ For more information please visit: https://github.com/PaperMC/Paper/issues/8948 [19:02:09 INFO]: [ChunkTaskScheduler] Chunk system is using 1 I/O threads, 4 worker threads, and gen parallelism of 4 threads [19:02:09 INFO]: Default game type: SURVIVAL [19:02:09 INFO]: Generating keypair [19:02:09 INFO]: Starting Minecraft server on *:25565 [19:02:09 INFO]: Using default channel type [19:02:09 INFO]: Paper: Using Java compression from Velocity. [19:02:09 INFO]: Paper: Using Java cipher from Velocity. [19:02:09 INFO]: [SpigotLibraryLoader] [ItemsAdder] Loading 1 libraries... please wait [19:02:10 INFO]: [SpigotLibraryLoader] [ItemsAdder] Loaded library C:\Users\lechat\Desktop\server 1.20.1\libraries\org\apache\httpcomponents\httpmime\4.5.14\httpmime-4.5.14.jar [19:02:10 INFO]: [SpigotLibraryLoader] [ItemsAdder] Loaded library C:\Users\lechat\Desktop\server 1.20.1\libraries\org\apache\httpcomponents\httpclient\4.5.14\httpclient-4.5.14.jar [19:02:10 INFO]: [SpigotLibraryLoader] [ItemsAdder] Loaded library C:\Users\lechat\Desktop\server 1.20.1\libraries\org\apache\httpcomponents\httpcore\4.4.16\httpcore-4.4.16.jar [19:02:10 INFO]: [SpigotLibraryLoader] [ItemsAdder] Loaded library C:\Users\lechat\Desktop\server 1.20.1\libraries\commons-logging\commons-logging\1.2\commons-logging-1.2.jar [19:02:10 INFO]: [SpigotLibraryLoader] [ItemsAdder] Loaded library C:\Users\lechat\Desktop\server 1.20.1\libraries\commons-codec\commons-codec\1.11\commons-codec-1.11.jar [19:02:10 INFO]: [LoneLibs] Loading server plugin LoneLibs v1.0.55 [19:02:10 INFO]: [ProtocolLib] Loading server plugin ProtocolLib v5.2.0-SNAPSHOT-679 [19:02:11 INFO]: [OldCombatMechanics] Loading server plugin OldCombatMechanics v2.0.2 [19:02:11 INFO]: [ItemsAdder] Loading server plugin ItemsAdder v3.6.4-release-3 [19:02:11 INFO]: Server permissions file permissions.yml is empty, ignoring it [19:02:11 INFO]: [LoneLibs] Enabling LoneLibs v1.0.55 [19:02:11 INFO]: [ProtocolLib] Enabling ProtocolLib v5.2.0-SNAPSHOT-679 [19:02:11 INFO]: Preparing level "world" [19:02:12 INFO]: Preparing start region for dimension minecraft:overworld [19:02:12 INFO]: Time elapsed: 243 ms [19:02:12 INFO]: Preparing start region for dimension minecraft:the_nether [19:02:12 INFO]: Time elapsed: 27 ms [19:02:12 INFO]: Preparing start region for dimension minecraft:the_end [19:02:12 INFO]: Time elapsed: 24 ms [19:02:12 INFO]: [OldCombatMechanics] Enabling OldCombatMechanics v2.0.2 [19:02:13 INFO]: [OldCombatMechanics] OldCombatMechanics v2.0.2 has been enabled [19:02:13 INFO]: [ItemsAdder] Enabling ItemsAdder v3.6.4-release-3 [19:02:13 INFO]: [NBTAPI] [NBTAPI] Found Minecraft: v1_20_R2! Trying to find NMS support [19:02:13 INFO]: [NBTAPI] [NBTAPI] NMS support 'MC1_20_R2' loaded! [19:02:13 INFO]: [NBTAPI] [NBTAPI] Using the plugin 'LoneLibs' to create a bStats instance!

ItemsAdder 3.6.4-release-3 | | | |\/| /` /\ | \ | \ | |) LoneLibs 1.0.55 | | | | | ./ /--\ |/ |__/ |___ | \ Paper git-Paper-260 (MC: 1.20.2)

[19:02:15 WARN]: [ProtocolLib] [PacketFilterManager] Plugin ItemsAdder tried to register listener for unknown packet ADD_RESOURCE_PACK[PLAY, SERVER, 68, classNames: [net.minecraft.network.protocol.game.PacketPlayOutResourcePackPushPacket, net.minecraft.network.protocol.game.ClientboundResourcePackPushPacketPacket] (unregistered)] direction: from SERVER: Running delayed init tasks 19:02:16 INFO: [ItemsAdder] [Pack] Extracting internal contents from .jar 19:02:16 INFO: [ItemsAdder] [Pack] DONE extracting internal contents from .jar 19:02:16 INFO: [ItemsAdder] [License] Spigot product licensed to: aymeric_pml (1609973)

19:02:16 INFO: [ItemsAdder] UPDATE available: https://www.spigotmc.org/resources/73355/ 19:02:16 INFO: [ItemsAdder] Current version: 3.6.4-release-3 | Online version: 4.0.1-alpha-test-5

19:02:18 INFO: Timings Reset 19:02:18 INFO: [ItemsAdder] Loaded 26 items 19:02:18 INFO: [ItemsAdder] Used 0/188 REAL block IDs 19:02:18 INFO: [ItemsAdder] Used 0/750 REAL_NOTE block IDs 19:02:18 INFO: [ItemsAdder] Used 0/63 REAL_TRANSPARENT block IDs 19:02:18 INFO: [ItemsAdder] Used 11/127 REAL_WIRE block IDs 19:02:18 INFO: [ItemsAdder] Used 0/14 FIRE block IDs 19:02:18 INFO: [ItemsAdder] Used 90/6608 font_images 19:02:18 INFO: [ItemsAdder] [Init] Loaded 1 categories 19:02:18 INFO: [ItemsAdder] [Init] Loaded successfully. [19:02:19 INFO]: [ItemsAdder] [Pack] Resourcepack URL is valid (lobfile). URL: https://lobfile.com/file/c6NDkbtL.zip [19:02:29 INFO]: UUID of player lechatdeschats is 52384eea-cd74-48f6-a49b-8a8f5407db26 [19:02:30 INFO]: lechatdeschats joined the game [19:02:30 INFO]: lechatdeschats[/127.0.0.1:64578] logged in with entity id 162 at ([world]-432.44195797984776, 80.0, 636.1475738953528) [19:02:57 INFO]: lechatdeschats issued server command: /iaget tools_axe:dark_queen_axe 19:06:02 INFO: lechatdeschats issued server command: /iazip [19:06:02 WARN]: [ProtocolLib] [PacketFilterManager] Plugin ItemsAdder tried to register listener for unknown packet ADD_RESOURCE_PACK[PLAY, SERVER, 68, classNames: [net.minecraft.network.protocol.game.PacketPlayOutResourcePackPushPacket, net.minecraft.network.protocol.game.ClientboundResourcePackPushPacketPacket] (unregistered)] [direction: from SERVER] [19:06:02 WARN]: [ItemsAdder] Warning: forcefully setting player resourcepack status to installed because the plugin was reloaded. 19:06:02 INFO: [ItemsAdder] [Pack] Extracting internal contents from .jar 19:06:02 INFO: [ItemsAdder] [Pack] DONE extracting internal contents from .jar 19:06:02 INFO: [ItemsAdder] Loaded 26 items 19:06:02 INFO: [ItemsAdder] Used 0/188 REAL block IDs 19:06:02 INFO: [ItemsAdder] Used 0/750 REAL_NOTE block IDs 19:06:02 INFO: [ItemsAdder] Used 0/63 REAL_TRANSPARENT block IDs 19:06:02 INFO: [ItemsAdder] Used 11/127 REAL_WIRE block IDs 19:06:02 INFO: [ItemsAdder] Used 0/14 FIRE block IDs 19:06:02 INFO: [ItemsAdder] Used 90/6608 font_images 19:06:02 INFO: [ItemsAdder] [Init] Loaded 1 categories 19:06:02 INFO: [ItemsAdder] [Init] Loaded successfully in 211ms

19:06:02 INFO: [ItemsAdder] [Pack] Started generation

19:06:03 INFO: [ItemsAdder] [Pack] Generated resourcepack 19:06:03 INFO: [ItemsAdder] [OK] Your zip file will be protected from unzip (as set in config.yml) 19:06:03 INFO: [ItemsAdder] [Pack] Compressing resource_pack ... [19:06:03 WARN]: [ItemsAdder] Skipped file because already scheduled for compression: contents/caisse2/.vscode/settings.json [19:06:03 WARN]: [ItemsAdder] Skipped file because already scheduled for compression: contents/tools_axe/.vscode/settings.json [19:06:03 WARN]: [ItemsAdder] File compression skipped: duplicate entry: assets/.vscode/settings.json [19:06:04 INFO]: [ItemsAdder] [Pack] Resource pack successfully compressed. Uploading... [19:06:04 INFO]: [ItemsAdder] [Pack] Uploading resourcepack... [19:06:05 INFO]: [ItemsAdder] [Pack] Finished uploading resourcepack: https://lobfile.com/file/g95B2Zgs.zip [19:06:06 INFO]: [ItemsAdder] [Pack] Compressed in 2976ms [19:06:06 INFO]: [ItemsAdder] [Pack] Resourcepack URL is valid (lobfile). URL: https://lobfile.com/file/g95B2Zgs.zip [19:06:06 INFO]: [ItemsAdder] [Pack] Applying to every player... [19:06:06 INFO]: [ItemsAdder] [Pack] Applied to 1 players [19:06:23 INFO]: lechatdeschats issued server command: /iaget tools_axe:dark_queen_axe [19:16:43 INFO]: lechatdeschats issued server command: /iazip [00:37:33 INFO]: lechatdeschats issued server command: /version version [00:37:41 INFO]: This server is running Paper version git-Paper-260 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 1865625) You are 58 version(s) behind Download the new version at: https://papermc.io/downloads/paper version ItemsAdder [00:38:20 INFO]: ItemsAdder version 3.6.4-release-3 [00:38:20 INFO]: Customized Minecraft without client mods! [00:38:20 INFO]: Website: devs.beer [00:38:20 INFO]: Author: LoneDev version ProtocolLib [00:38:36 INFO]: ProtocolLib version 5.2.0-SNAPSHOT-679 [00:38:36 INFO]: Provides read/write access to the Minecraft protocol. [00:38:36 INFO]: Authors: dmulloy2 and comphenix version LoneLibs [00:38:49 INFO]: LoneLibs version 1.0.55 [00:38:49 INFO]: Collection of libs used by my plugins [00:38:49 INFO]: Authors: LoneDev and others

Error (optional)

no error in console

Problematic items yml configuration file (optional)

info:
  namespace: tools_axe
items:
  dark_queen_axe:
    display_name: "Darkqueen Axe"
    lore:
    - ' test '
    resource:
      material: DIAMOND_AXE
      generate: true
      model_path: axe_dark_queen.json
      item_flags:
      - HIDE_ADDITIONAL_TOOLTIP
      - HIDE_ATTRIBUTES

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

image

LoneDev6 commented 1 month ago

It's being worked on.

Note for me, test also with:

items:
  officer_helmet:
    display_name: Helmet
    resource:
      generate: true
      textures:
      - item/vs_staff/vs_staff_armor_helm
    item_flags:
      - HIDE_ATTRIBUTES
    specific_properties:
      armor:
        slot: HEAD
        custom_armor: officer_armor
    attribute_modifiers:
      head:
        armor: 69
        armorToughness: 420