PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
53 stars 21 forks source link

Item display furniture hitbox issues #3874

Open LuluxClient opened 2 months ago

LuluxClient commented 2 months ago

Terms

Discord tag (optional)

xdLulux

What happened?

Since updating to the latest version of minecraft and itemsadder 4.0+. After updating the furnitures to item_display I've discovered lots of issues:

Steps to reproduce the issue

  1. create a furniture with a 1x1x1 hitbox
  2. place it on a wall
  3. See a barrier block being placed on the wrong position
  4. change the hight_offset to -0.5
  5. issue fixed but the break hitbox is shifted sometimes
  6. to break a furniture it's often super hard to break it and even harder for builders when they are in gamemode creative

Server version

This server is running UniverseSpigot version 1.21-DEV-ver/1.21@64094d4 (2024-08-08T06:45:54Z) (Implementing API version 1.21-R0.1-SNAPSHOT) Universe-1.21-DEV-64094d4 (MC: 1.21)

ItemsAdder Version

4.0.2-alpha-test-3

ProtocolLib Version

5.3.0-SNAPSHOT-726

LoneLibs Version

1.0.56

Full server log

private

Error (optional)

none

Problematic items yml configuration file (optional)

wisteria_yellow_vines:
    display_name: Wisteria Yellow Vines
    resource:
      material: MAGENTA_DYE
      model_id: 683
      generate: false
      model_path: epicworld/wisteria_yellow_vines
    behaviours:
      furniture:
        entity: item_display
        gravity: false
        fixed_rotation: false
        small_hitbox: false
        solid: true
        hitbox:
          length: 1
          width: 1
          height: 1
          length_offset: 0
          width_offset: 0    
          height_offset: -0.5         
        placeable_on:
          floor: false
          ceiling: true
          walls: false
        sound:
          place:
            name: block.wood.place
          break:
            name: block.wood.break
        display_transformation:
          adjust_legacy_model: item_frame

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

Before the height offset change: https://gyazo.com/1283b5357ecc0912f390cf935c2de92a

After the height offset change: https://gyazo.com/0cf0919f42d63f4eacbe603bd906ce7d

SrMonsterYT commented 2 months ago

same problem as you