PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
51 stars 21 forks source link

Custom NBT tags remove default itemsadder NBT Tags #3890

Closed Emsa001 closed 2 weeks ago

Emsa001 commented 4 weeks ago

Terms

Discord tag (optional)

Emsa001

What happened?

it doesn't generate any logs, just when I set nbt tag it removes all default nbt tags from itemsadder

info:
  namespace: technology
items:
  phone:
    display_name: "Phone"
    permission: itemsadder.phones
    nbt: "{level:1}"
    resource:
      material: FLINT
      generate: false
      model_path: phones/phonesobjects/phone

image

Steps to reproduce the issue

  1. Set the custom NBT tag
  2. Default Itemsadder NBT tags are gone 🤯

Server version

This server is running Paper version 1.21-130-master@b1b5d4c (2024-08-10T10:02:42Z) (Implementing API version 1.21-R0.1-SNAPSHOT)

ItemsAdder Version

4.0.2-alpha-test-3

ProtocolLib Version

5.3.0-SNAPSHOT-723

LoneLibs Version

1.0.56

Full server log

No response

Error (optional)

no error

Problematic items yml configuration file (optional)

info:
  namespace: technology
items:
  phone:
    display_name: "Phone"
    permission: itemsadder.phones
    nbt: "{level:1}"
    resource:
      material: FLINT
      generate: false
      model_path: phones/phonesobjects/phone

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

PSYCHEER commented 4 weeks ago
  emerald_helmet:
    display_name: Emerald Helmet
    permission: emerald_set
    nbt: '{itemsadder:{armor:"heavy"}}'
    resource:
      generate: true
      textures:
      - item/emerald/helmet
    durability:
      max_custom_durability: 500
    specific_properties:
      armor:
        slot: head
        custom_armor: emerald_armor
    attribute_modifiers:
      head:
        armor: 3
        armorToughness: 3

This item with NBT worked on 1.20.4 but now on 1.21 when it's enabled, it's just a leather armor with other skin, no attributes as I've set in attributes_modifiers. When I comment out the NBTs, attributes shows up, but armor is acting like no attributes were set.

ABOUT NEXT SECTION I DON'T KNOW IF IT IS RELATED BUT...

Netherite set 20 armor and some toughness Emerald set(the one on right side) 22 armor and 10 toughness

Both of Husk's got 2 smashes with BASIC Netherite sword image