Tripwires aren't working properly

svaningelgem commented 2 months ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I've looked for already existing issues on the Issue Tracker and haven't found any.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.
[X] I tested this with just ItemsAdder and its dependencies and with a vanilla client of the same version as the Server.

Discord Username (optional)

Sensei_Orange

What happened?

We saw that a string duper farm wasn't working, and it was working perfectly on other servers. So we investigated:

spawn a new 1.21 paper server
create the string farm
everything works as normal
stop the server
add itemsadder & its dependencies
start the server
the string farm is STILL working properly!
break the string
add the string again
the string breaks immediately

I checked other tickets and was also playing around with custom-wire-false, but then tripwires simply didn't work at all (it gave a message about tripwires being disabled on the server).

Steps to reproduce the issue

See above

Server version

This server is running Paper version 1.21-130-master@b1b5d4c (2024-08-10T10:02:42Z) (Implementing API version 1.21-R0.1-SNAPSHOT)

ItemsAdder Version

version 4.0.2-alpha-test-7

ProtocolLib Version

version 5.3.0-SNAPSHOT-726

LoneLibs Version

LoneLibs version 1.0.57

Full Server Log

https://mclo.gs/c09jwbx

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

Without IA: setting up the string running the farm

With IA: running the farm

LoneDev6 commented 3 weeks ago

This is strange as the plugin shouldn't enable custom wire blocks if you disable them in config.yml

  custom:
    note: true
    mushroom: true
    chorus: true
    wire: false # <----
    fire: false

svaningelgem commented 6 days ago

Yes, that is exactly my config (the default one). wire: false The behaviour: the first one is placed "straight", and when you place another string next to it, it will make 1 long cord (as shown in the screenshots above).

Now when I set wire: true, it will place both "straight":

my current versions:

version
[16:55:28 INFO]: Checking version, please wait...
[16:55:28 INFO]: This server is running Paper version 1.21-130-master@b1b5d4c (2024-08-10T10:02:42Z) (Implementing API version 1.21-R0.1-SNAPSHOT)
Previous version: git-Paper-497 (MC: 1.20.4)
version ItemsAdder
[16:55:32 INFO]: ItemsAdder version 4.0.3
version LoneLibs
[16:55:37 INFO]: LoneLibs version 1.0.59
version ProtocolLib
[16:55:42 INFO]: ProtocolLib version 5.3.0

PluginBugs / Issues-ItemsAdder