search

PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
53 stars 21 forks source link

Automatic merging of `pack.mcmeta` new overlay properties #3969

Open Moosebobby123 opened 2 months ago

Moosebobby123 commented 2 months ago

Discord Username (optional)

matt_moose

What happened?

Basically due to minecraft 1.20.5 changes to shaders/overlays, you need to add a file from MythicHUD to the /pack folder of the resource pack as opposed to putting it in the /assets folder. You can't (to my knowledge) manually add this folder because /iazip will overwrite it when it is used. Proper folder layout that is needed is pasted below. 

📁 Resource Pack
├── 📁 mythichud-modern
├── 📄 pack.mcmeta
└── 📁 assets
   ├── 📁 minecraft
   └── 📁 mythichud

Steps to reproduce the issue

More Information: https://git.lumine.io/mythiccraft/mythichud/-/wikis/Adding-support-for-1.20.5-

Compatibility: https://happyhud.ehhthan.com/tutorials/compatibility

Server version

purpur-1.21-2281

ItemsAdder Version

ItemsAdder 4.0.2-alpha-test-6

ProtocolLib Version

5.3.0

LoneLibs Version

1.0.57

Screenshots/Videos (you can drag and drop files or paste links)

image

Andre601 commented 2 months ago

Please share your latest.log through https://mclo.gs as it help us getting all the necessary info required to solving this issue.

Also, what is the issue in particular? Usually you can just put any file/folder structure in contenst/<name of addon>/resourcepack/ and ItemsAdder would transfer it as-is.

Moosebobby123 commented 2 months ago

https://itemsadder.devs.beer/plugin-usage/merge-resourcepacks Based off the wiki info for merging the resource packs, it doesn't allow for merging any folders above the /assets/ folder. If you refer to the folder structure in the original post you can see where the MythicHUD folder (mythichud-modern) needs to go. I could be wrong about this but I was just going off what the wiki says.

As for latest.log, I can send it but there's no errors or anything. The issue is simply the fact I am unable to merge the proper folder into the itemsadder generated pack so the HUD doesn't work.

Andre601 commented 2 months ago

The point of the latest log is not just for the sake of errors, that's what the dedicated Errors section is for. It's to provide us with all the necessary info we may need such as the Environment the server runs on, other plugins that may be used, etc. We wouldn't ask for it, nor make it a required option in the issue template, if we didn't consider it a necessary thing to share.

Moosebobby123 commented 2 months ago

2024-09-02-16.log (https://mclo.gs/zH3IK2Z) Ignore all the mythicmobs errors, i fixed that already by updating

Andre601 commented 2 months ago

Please make sure to use 1.21.1 of your server software, as it is the latest available and also fixes a major exploit.

Andre601 commented 2 months ago

Also, while not related to ItemsAdder: Please actually buy the plugins you use and don't just use leaked versions. It's very rude as the developers put time and effort into their products, only to then be stolen by people.

Proof found here:

It actually even makes me doubt you have a license for ItemsAdder, despite the oposite in the logs, but that's not of importance here.

Moosebobby123 commented 2 months ago

You can verify my ownership in the discord if needed, or I can post proof if you'd like. Those plugins were likely added by other developers for our server and I will speak with them immediately about obtaining the proper versions of them. Thank you.

Will this issue not be looked at unless I update to 1.21.1? The issue was not addressed in the github list of fixes in ItemsAdder alpha test 9.

Andre601 commented 2 months ago

LoneDev has to look at it as he's the sole dev of this plugin. Plus it never hurts to update the server to latest recommended patch version, especially if IA supports it and it is compatible with 1.21 clients.

Moosebobby123 commented 2 months ago

Sounds good, thank you for time and fast replies to this thread. If you or LoneDev require anymore information about this issue I can try to answer what I know.

SMHenrry commented 1 month ago

I don't support the leaks topic but I do support the general topic.

I'm actually surprised that it hasn't been reported or that there aren't more topics at the moment, since since mythichud came out there have been many comments about the lack of compatibility with AI and ORA, this due to the need to put the mythichud-modern folder inside the resourcepack outside the assets folder.

I'm attaching a comment (doubt) from the author of mythichud related to compatibility. image

and a user's comment adding the correct way the folder should be so that mythichud works correctly in 1.21+ image

SomeVagueRanks commented 1 month ago

Have also posted about this on the forum https://forum.devs.beer/d/2767-not-working-with-mythichud

I have used IA for quite a lot of my projects and honestly love the plugin. MythicHUD however is something that is non-negotiable, as it is currently one of the best HUD plugins on the market. Would like a response from @LoneDev6 about any plans to add this. An update is not expected immediately but would like to know if there are plans to add this

jeffry1829 commented 1 month ago

I love this plugin too! Hope this will be added in the future, since seems like there’s no workaround.

PGMCgit commented 1 month ago

Currently waiting patiently on this as well.

LoneDev6 commented 1 month ago

ItemsAdder should already merge packs correctly and won't strip overlays properties of your custom pack.mcmeta. What you can try to do is putting your custom pack.mcmeta inside contents/_iainternal/resourcepack/ folder and let me know if it works correctly.

SMHenrry commented 1 month ago

ItemsAdder should already merge packs correctly and won't strip overlays properties of your custom pack.mcmeta. What you can try to do is putting your custom pack.mcmeta inside contents/_iainternal/resourcepack/ folder and let me know if it works correctly.

image

What I do to make the pack work properly with MythicHud is to modify the pack.mcmeta that mythichud generates and move it from the ItemsAdder/contents/_iainternal/resourcepack directory

After that I follow the instructions in the image, and that is the only way to make the pack work properly, from there every time I want to modify the hud I have to copy and paste the generated content from the MH (modern) folder to the IA folder.

"IA apparently do not support overlay system to have both old and modern shaders like oraxen does"

Currently this is not intuitive in any way.

jeffry1829 commented 1 month ago

Here's my version of making MH work with IA:

0.5. disable text-effect and disable disable-scoreboard-number in IA config. (very important)

0.6. If you are using legacy IA config (You'll have data/ folder), delete pack.mcmeta in data/resource_pack

  1. /mh reload → you need to make it automatically copy minecraft/ and mythichud/ to ItemsAdder/contents (You can set it in MythicHUD's config like this:

    copy-resource-pack:
enabled: true
# The location to copy each namespace to. The parent path is your plugins directory.
namespaces:
minecraft: ItemsAdder/contents/minecraft/resourcepack/assets/
mythichud: ItemsAdder/contents/mythichud/resourcepack/assets/
# mythichud-modern: ItemsAdder/contents/mythichud-modern/resourcepack/

    hope we can get auto-copy for mythichud-modern in the next version of MH)

  2. delete contents/minecraft/shaders folder, otherwise things are not gonna work

  3. copy mythichud-modern/ to contents/

  4. copy pack.mcmeta to contents/_iainternal/resourcepack/pack.mcmeta

  5. remove original hud by add some textures to contents/minecraft/resourcepack/assets/minecraft/textures/gui/sprites (create new folder you there isn't one)

  6. /iazip

eczv3n0m commented 1 month ago

I’m using the latest version of itemsadder today and thought it was mythichud, but when I removed the . jar of mythichud, I still had the same problem when disabling "text-effect": the resourcepack was broken and when it was reactivated it compressed with total normality and I’m only using an image folder image image

jeffry1829 commented 1 month ago

I’m using the latest version of itemsadder today and thought it was mythichud, but when I removed the . jar of mythichud, I still had the same problem when disabling "text-effect": the resourcepack was broken and when it was reactivated it compressed with total normality and I’m only using an image folder image image

Did you delete the contents/minecraft/shaders folder?

LoneDev6 commented 1 month ago

Support for automatic merging of pack.mcmeta new properties will be implemented in the next versions of ItemsAdder. Right now these properties are simply skipped.