Durability with ViaVersion, dont work fine

SliderKP commented 2 months ago

Terms

[X] I'm using the very latest version of ItemsAdder and its dependencies.
[X] I am sure this is a bug and it is not caused by a misconfiguration or by another plugin.
[X] I've looked for already existing issues on the Issue Tracker and haven't found any.
[X] I already searched on the plugin wiki to know if a solution is already known.
[X] I already searched on the forums to check if anyone already has a solution for this.
[X] I tested this with just ItemsAdder and its dependencies and with a vanilla client of the same version as the Server.

Discord Username (optional)

exxslider

What happened?

i updated my server from 1.20.4 to 1.21.1 and armor attributes and durabilities dosnt work fine usign advancedenchantment 9.11.0

Steps to reproduce the issue

updating server from 1.20.4

Server version

pufferfish 1.21.1 build 15

ItemsAdder Version

version 10 hotfix

ProtocolLib Version

build 726

LoneLibs Version

LoneLibs 1.0.58

Full Server Log

i cant uplaod to mclo.gs

Error (optional)

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

Andre601 commented 2 months ago

i cant uplaod to mclo.gs

If you can't upload to that site, use any other paste site then such as https://paste.helpch.at, https://pastes.dev or similar.

SliderKP commented 2 months ago

i cant uplaod to mclo.gs

If you can't upload to that site, use any other paste site then such as https://paste.helpch.at, https://pastes.dev or similar.

https://paste.helpch.at/iyisorixob.makefile

Andre601 commented 2 months ago

Please test if this issue also appears with just ItemsAdder and its dependencies, and the AdvancedEnchantments plugin installed, to eliminate possible other plugins as the issue.

Also, looking at the logs, I can see three things:

AE seems to be a cyclic dependency, meaning it (soft)depends on IA while IA softdepends on it. IA seems to delay loading for that matter until AE is confirmed to have loaded.
IA reports missing/unknown enchantments. Are you sure they are properly loaded in AE?
While not related to IA, are you using a leaked version of ShopGUIPlus. Please don't do that. It's rude towards the dev who probs has put a lot of time and effort into the plugin.

SliderKP commented 2 months ago

im not using leak actually, just in this test server xD

AE are actually loaded, enchants works fine, but durability on items of IA with enchantments of ItemsAdders dosnt work

LoneDev6 commented 2 months ago

Provide a video of the issue and configurations of the items which have issues.

SliderKP commented 2 months ago

Provide a video of the issue and configurations of the items which have issues.

in this image you can see the problem: "Durabilidad 26/55" (durability 26/55) and when i stay in older version (1.20.4) the durability working are the upside ("Durabilidad 602/602") this is the config:

  ecknighthelmet:
    display_name: Knight Helmet
    resource:
      generate: true
      textures:
      - item/ec_elitearmorsbundle/ecdarkknighthelmet.png
    durability:
      max_custom_durability: 602
    specific_properties:
      armor:
        slot: head
        custom_armor: ecknightarmor
    attribute_modifiers:
      head:
        armor: 8
        armorToughness: 3

Thanks a lot for your answer, if u think this is not detailed i can make a video but, i think is innecesary, i still waiting for another answer.

SliderKP commented 1 month ago

That can be fixed soon? @LoneDev6

SliderKP commented 1 month ago

I think this error is something similar to the problem happens on this issue: https://github.com/GC-spigot/AdvancedEnchantments/issues/4228#issuecomment-2177911056

SliderKP commented 1 month ago

the error occours when the user joins with 1.20.4 version, i updated to 1.21.1 #15 of pufferfish and if the user join with 1.21.1 looks to work fine, but texturepack are not working in 1.21.1 :/ 1.21.1:

1.20.4

Andre601 commented 1 month ago

Not sure if I understood you right here. The server is 1.21.1? If so, then having clients joining with 1.20.4 encountering issues with AE is not a IA issue here, but more an issue with ViaVersion, which we highly recommend you not use for anything more than a multi-version lobby server.

See #1876 for more info.

SliderKP commented 1 month ago

Not sure if I understood you right here. The server is 1.21.1? If so, then having clients joining with 1.20.4 encountering issues with AE is not a IA issue here, but more an issue with ViaVersion, which we highly recommend you not use for anything more than a multi-version lobby server.

See #1876 for more info.

yes my server is 1.21.1 and im using viaversion and viabackwards on 5.0.3

im from latin america and not all my users can use the latest version, i think is a ItemsAdder problem because durability looks fine in 1.21.1 but not when im join in 1.20.4, i think this problem is not related with AE actually, just maybe with ViaPlugins and ItemsAdder in the images, and in 1.21.1 the texturepack dosnt work, simply i get an error when trying to load it and dont getting errors on console or anything, just "Error al cargar el recurso" in enligsh: "error loading the texturepack"

SliderKP commented 1 month ago

Texturepack now works fine in 1.21.1 but the durability continues broken

Askeshine commented 1 month ago

Same problem here.

New server only with itemsAdder and ViaVersion

Andre601 commented 1 month ago

I will close this issue given that ItemsAdder does not actively support nor recommend ViaVersion to be used outside a lobby-server. This plugin causes way too many issues, especially with the item changes introduced in 1.20.5, which may be the cause of this.

If LoneDev thinks this is an issue worth fixing will he most likely do so and provide a response here, but given his own comment on ViaVersion (See my linked issue above) is it unlikely he will implement a fix, especially if ViaVersion could be at fault here too.

SliderKP commented 1 month ago

I understand until many people complain about the inconvenience, we will ignore those who have it, a shame but I bought this plugin to use it.

sennby commented 1 month ago

My viaversion is 1.20.6+ and this issue still is railing:L

LoneDev6 commented 6 days ago

Without any clear way to reproduce the issue I can't do anything. Anyway could be a ViaVersion issue as far as I know.

PluginBugs / Issues-ItemsAdder