search

PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

itemsadder items do not appear in shopkeepers after the last update #4014

Open pump61 opened 1 month ago

pump61 commented 1 month ago

Terms

Discord Username (optional)

pumpmonster

What happened?

when a player tries to open shopkeppers the menu opens empty the items within it do not appear even though they are set in the configuration, so when it is clicked on the npc it generates an error on the console the problem appeared after the current version of itemsadder was added

Steps to reproduce the issue

  1. place items with textures from itemsadder in the shopkeepers config
  2. open the menu
  3. there will be nothing there and an error will be generated in the console

Server version

This server is running Paper version 1.21.1-83-master@2aaf436 (2024-09-17T15:10:44Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT) You are running the latest version Previous version: 1.21.1-2308-8332fa4 (MC: 1.21.1)

ItemsAdder Version

Itemsadder version 4.0.2-beta-release-10

ProtocolLib Version

ProtocolLib Version 5.3.0-SNAPSHOT-723

LoneLibs Version

LoneLibs Version 1.0.58

Full Server Log

https://mclo.gs/msboefu

Error (optional)

[17:16:44 ERROR]: [ItemsAdder] Unhandled exception occurred in onPacketSending(PacketEvent) for ItemsAdder
java.lang.IncompatibleClassChangeError: Found interface org.bukkit.craftbukkit.inventory.CraftMerchant, but class was expected
        at ItemsAdder_4.0.2-beta-release-10.jar/ia.m.lN.a(SourceFile:91) ~[ItemsAdder_4.0.2-beta-release-10.jar:?]
        at ItemsAdder_4.0.2-beta-release-10.jar/ia.m.lN.b(SourceFile:51) ~[ItemsAdder_4.0.2-beta-release-10.jar:?]
        at ItemsAdder_4.0.2-beta-release-10.jar/ia.m.nQ.d(SourceFile:130) ~[ItemsAdder_4.0.2-beta-release-10.jar:?]
        at ItemsAdder_4.0.2-beta-release-10.jar/ia.m.lN.g(SourceFile:50) ~[ItemsAdder_4.0.2-beta-release-10.jar:?]
        at ItemsAdder_4.0.2-beta-release-10.jar/ia.m.W.onPacketSending(SourceFile:76) ~[ItemsAdder_4.0.2-beta-release-10.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.collection.OutboundPacketListenerSet.invokeListener(OutboundPacketListenerSet.java:74) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.collection.PacketListenerSet.lambda$invoke$0(PacketListenerSet.java:120) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.timing.TimingTracker.lambda$static$0(TimingTracker.java:7) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.collection.PacketListenerSet.invoke(PacketListenerSet.java:120) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.collection.OutboundPacketListenerSet.invoke(OutboundPacketListenerSet.java:30) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.collection.PacketListenerSet.invoke(PacketListenerSet.java:99) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.PacketFilterManager.postPacketToListeners(PacketFilterManager.java:528) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.PacketFilterManager.invokeOutboundPacketListeners(PacketFilterManager.java:516) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.netty.channel.NettyChannelInjector.processOutbound(NettyChannelInjector.java:528) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.proxyRunnable(NettyEventLoopProxy.java:44) ~[ProtocolLib.jar:?]
        at ProtocolLib.jar/com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.execute(NettyEventLoopProxy.java:233) ~[ProtocolLib.jar:?]
        at net.minecraft.network.Connection.sendPacket(Connection.java:497) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.network.Connection.send(Connection.java:457) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.network.ServerCommonPacketListenerImpl.send(ServerCommonPacketListenerImpl.java:317) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.network.ServerCommonPacketListenerImpl.send(ServerCommonPacketListenerImpl.java:298) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.level.ServerPlayer.sendMerchantOffers(ServerPlayer.java:1741) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.world.item.trading.Merchant.openTradingScreen(Merchant.java:49) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at org.bukkit.craftbukkit.entity.CraftHumanEntity.openMerchant(CraftHumanEntity.java:511) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.ui.trading.TradingHandler.openTradeWindow(TradingHandler.java:152) ~[Shopkeepers-2.23.0.jar:?]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.ui.trading.TradingHandler.openWindow(TradingHandler.java:135) ~[Shopkeepers-2.23.0.jar:?]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.ui.SKUIRegistry.requestUI(SKUIRegistry.java:193) ~[Shopkeepers-2.23.0.jar:?]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.ui.SKUIRegistry.requestUI(SKUIRegistry.java:105) ~[Shopkeepers-2.23.0.jar:?]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.ui.SKUIRegistry.requestUI(SKUIRegistry.java:97) ~[Shopkeepers-2.23.0.jar:?]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.ui.SKUIRegistry.requestUI(SKUIRegistry.java:66) ~[Shopkeepers-2.23.0.jar:?]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.shopkeeper.AbstractShopkeeper.openWindow(AbstractShopkeeper.java:1429) ~[Shopkeepers-2.23.0.jar:?]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.shopkeeper.AbstractShopkeeper.openTradingWindow(AbstractShopkeeper.java:1441) ~[Shopkeepers-2.23.0.jar:?]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.shopkeeper.AbstractShopkeeper.onPlayerInteraction(AbstractShopkeeper.java:1459) ~[Shopkeepers-2.23.0.jar:?]
        at Shopkeepers-2.23.0.jar/com.nisovin.shopkeepers.shopobjects.living.LivingEntityShopListener.onEntityInteract(LivingEntityShopListener.java:206) ~[Shopkeepers-2.23.0.jar:?]
        at com.destroystokyo.paper.event.executor.MethodHandleEventExecutor.execute(MethodHandleEventExecutor.java:40) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:1.21.1-83-2aaf436]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl$3.performInteraction(ServerGamePacketListenerImpl.java:2793) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.network.ServerGamePacketListenerImpl$3.onInteraction(ServerGamePacketListenerImpl.java:2841) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.network.protocol.game.ServerboundInteractPacket$InteractionAction.dispatch(ServerboundInteractPacket.java:138) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.network.protocol.game.ServerboundInteractPacket.dispatch(ServerboundInteractPacket.java:89) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleInteract(ServerGamePacketListenerImpl.java:2782) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:76) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:14) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:56) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1537) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:201) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1514) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1507) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:135) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1466) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1473) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1318) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:330) ~[paper-1.21.1.jar:1.21.1-83-2aaf436]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
[17:16:44 ERROR]: Parameters: 
  net.minecraft.network.protocol.game.ClientboundMerchantOffersPacket@7a6aa01b[
    containerId=1
    offers=[net.minecraft.world.item.trading.MerchantOffer@1131b2ba, net.minecraft.world.item.trading.MerchantOffer@1173dd1f, net.minecraft.world.item.trading.MerchantOffer@734ae3d8, net.minecraft.world.item.trading.MerchantOffer@5c8fefd2]
    villagerLevel=1
    villagerXp=0
    showProgress=false
    canRestock=false
  ]

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

image image

Andre601 commented 1 month ago

LoneDev updated ItemsAdder not too long ago, so please update and check if the issue still exists.

On another note, please don't use leaked plugins. It not only is extremely rude towards the dev who puts time and effort into it to have it leaked, but it also puts you at risk as the leaked plugin could have exploits and backdoors in them. I've found the following leaked plugins:

404forever1 commented 1 month ago

LoneDev updated ItemsAdder not too long ago, so please update and check if the issue still exists.

On another note, please don't use leaked plugins. It not only is extremely rude towards the dev who puts time and effort into it to have it leaked, but it also puts you at risk as the leaked plugin could have exploits and backdoors in them. I've found the following leaked plugins:

  • HeadDatabase
  • MobFarmManager

4.0.2-beta-release-11 also error

pump61 commented 1 month ago

also error

matipoirierg commented 1 month ago

Same issue Protocolib 732 ItemsAdder 4.0.2-12 LoneLibs 1.0.59 Server 1.21.1 https://mclo.gs/1UhEMzs

Verkros commented 3 weeks ago

I also have the same problem

hmad123456 commented 2 weeks ago

I also have the same problem itemsadder version 4.0.3

pump61 commented 2 weeks ago

I also have the same problem itemsadder version 4.0.3

update you shopkeepers and itemsadder

pump61 commented 2 weeks ago

I also have the same problem itemsadder version 4.0.3

update shopkeppers and itemsadder

LoneDev6 commented 5 days ago

CraftMerchant was changed from class to interface at some point. Official Spigot changelog here.

This will be fixed.