PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
54 stars 21 forks source link

Move away from LoneLibs and use maven loader of plugin.yml #4112

Open LoneDev6 opened 5 days ago

LoneDev6 commented 5 days ago

I think would be beneficial to move some libs from LoneLibs to maven and load them using the native plugin.yml feature.

Andre601 commented 5 days ago

I advice against the use of Spigot's library loader as it is a violation of Maven's terms (no automated access of their repository).

Instead I suggest the usage of libraries such as Libby to load the necessary libs. This would have multiple benefits:

OmeWillem commented 5 days ago

I advice against the use of Spigot's library loader as it is a violation of Maven's terms (no automated access of their repository).

Instead I suggest the usage of libraries such as Libby to load the necessary libs. This would have the benefit to also allow loading libs more dynamically, only loading them when needed (i.e. adventure libs on non-paper servers).

Quite sure that only counts for abuse of Maven Central.

Andre601 commented 5 days ago

Maven's terms prohibit the automated access of their repository (repo2 iirc) and instead setup and/or use mirrors. Spigot's lib loader counts as such an automated access. Has been discussed before and it's better to not take risks.

OmeWillem commented 2 days ago

Maven's terms prohibit the automated access of their repository (repo2 iirc) and instead setup and/or use mirrors. Spigot's lib loader counts as such an automated access. Has been discussed before and it's better to not take risks.

If Spigot added it then it should be save to use. Even if something does happen then they'll probably fix it anyway by using said mirrors. This is far from a good reason to not use it.