PluginBugs / Issues-ItemsAdder

Repository used to keep track of issues of my plugin ItemsAdder
https://itemsadder.devs.beer
53 stars 21 forks source link

[BUG] Not all Emojis loading #601

Closed xSorch closed 3 years ago

xSorch commented 3 years ago

Describe the bug For some reason when a few of my players connect, not all the emojis are loaded properly, which makes them show up a [] white bracket for some reason. That issue comes and go for a few players, including myself rarely. No itemsadder errors sorrounding this issue in console or my logs either.

Screenshots If applicable, add screenshots to help explain your problem.

Info (please complete the following information):

xSorch commented 3 years ago

Here is another example, doesn't always turn into brackets. https://gyazo.com/8fd0f16b951ad4470401cd9ee16f316c Both users have the server texture loaded, and no errors, but for some reason the user on the left screen doesn't see all emojis. I've realised that after I OP the user on the left side and he rejoins, then I post the emoji, it works fine. So guessing there is a perm I am missing? As far as I am aware of, there are no permission for seeing emojis, only posting them.

LoneDev6 commented 3 years ago

About the white [] it could be for some reasons (it's not brackets but a square actually = missing character):

You may identify the issue on your own by reading last lines of CLIENT logs (not server, client logs from the logs folder in %appdata%/.minecraft/, should be latest.log).

I suggest you to open a ticket on my discord and ping me, provide me your whole ItemsAdder configuration folder (zip it) so I can test (don't worry I don't care about stealing content from my customers)

Here is another example, doesn't always turn into brackets. https://gyazo.com/8fd0f16b951ad4470401cd9ee16f316c Both users have the server texture loaded, and no errors, but for some reason the user on the left screen doesn't see all emojis. I've realised that after I OP the user on the left side and he rejoins, then I post the emoji, it works fine. So guessing there is a perm I am missing? As far as I am aware of, there are no permission for seeing emojis, only posting them.

yes probably they are missing some perm, for example if the emojis is named smile you must set: ia.user.image.use.smile

and also set this to allow them to use the emojis in chat ia.user.image.chat

immagine

LoneDev6 commented 3 years ago

problem was:

resourcepack failed to load some of the emojis because some of them have uppercase or bad characters in their png file name

xSorch commented 3 years ago

Didn't solve the full problem, still seem to be happening here and there, just less. The issue with those permissions is that once you give any of those, regular players are also able to use emojis. Would be nice if it was a one way perm or set to default that people without the use perm can see them. Because on my server, the use of emojis is for premium users meaning that default players can't see the emoji. Only Premium ranks can see and use them, so it's either only premium being able to see them and not default, or everyone including default being able to see and use them. https://gyazo.com/1a6723d3daffa466af34b17aac488fd7

xSorch commented 3 years ago

Also having multiple complaints of having issues connecting with LunarClient.

LoneDev6 commented 3 years ago

I will post an update today, please install it and let me know, thanks! You can remove emojis permissions the permissons to players that are not allowed to use the premium emojis.

LoneDev6 commented 3 years ago

Also having multiple complaints of having issues connecting with LunarClient.

be more specific, like what happens? any error?

please open another report as they seem not to be connected (emoji problema and LunarClient client problem). Open a new issue after you got any valid information for me to fix the LunarClient problem, thanks