PluginBugs / Issues-MotionCapture

Repository used to keep track of issues of my plugin MotionCapture
0 stars 0 forks source link

Lagspike caused by long recordings #3

Closed loewe2702 closed 1 year ago

loewe2702 commented 1 year ago

Terms

Discord tag (optional)

Max1223#8206 Merlin#0909

What happened?

When creating long recordings (In our case 10+ minutes) the region check creates extreme lag spikes. Before the introduction of the region check everything was running fine. This only happens when the recording files are in the plugin folder. When a recording has already started playing and the file is removed from the plugin folder the lag spikes disappear.

at 9pm we put our recordings in the plugin folder and the performance usage immediately went up. https://timings.aikar.co/dev/?id=385611105b904c6bb901c3f07d42c756#plugins

Steps to reproduce the issue

  1. Create one or multiple recordings of 15 minutes (we dont know the exact count).
  2. as long as these recordings are in the plugin folder, the performance usage of the region checker increases drasticaly

our_recordings.zip

Server version

This server is running Paper version git-Paper-307 (MC: 1.19.2) (Implementing API version 1.19.2-R0.1-SNAPSHOT) (Git: 476ef25) You are running the latest version Previous version: git-Paper-345 (MC: 1.19.3)

MotionCapture Version

Motion Capture version: 2.3.1-Beta-r3

ProtocolLib Version

ProtocolLib: 5.0.0-snapshot-b610

LoneLibs Version

LoneLibs Version: 1.0.23

FULL server log

2023-01-25-3.log.gz

Error (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

No response

LoneDev6 commented 1 year ago

Seems to be caused by the region checker. The original developer of the plugin didn't really do a good job on coding that particular feature, I probably have identified the cause of the performance issue and I'll fix it as soon as possible.

LoneDev6 commented 1 year ago

Fixed https://www.spigotmc.org/resources/motion-capture-player-recording-system.61062/