search

PluginsOCSInventory-NG / officepack

Retrieve microsoft office keys
GNU General Public License v2.0
15 stars 27 forks source link

update for correct bug " key too long" #29

Closed Serizao closed 4 years ago

gillesdubois commented 7 years ago

Hi,

Could you describe a little more your PR please ? You are updating the VARCHAR length but why ? Which bug are you fixing ? Is there an issue affiliated to the PR ?

Regards, Gilles Dubois.

Serizao commented 7 years ago

When i try the first time to install it the error message is : "Specified key was too long; max key length is 767 bytes convert to utf8" it resolve this : https://github.com/PluginsOCSInventory-NG/officepack/issues/27 and i have forget in this fork to corrict php file too if you want i have aleready do this on my fork

der-mick commented 5 years ago

I ran into the same problem as you described here yesterday. The key length is still a problem on Debian Stretch with mariadb-server-10.1 (10.1.37-0+deb9u1). Using varchar-definitions with smaller maximum length did do the trick. This cause for this problem is the limit of prefix lengths for innodb databases, described here: https://dev.mysql.com/doc/refman/8.0/en/create-index.html As I think that it's highly unlikely to have keys or product names longer than 128 characters, I would suggest either to merge the length changes @Serizao suggested, or just set all varchar(255) to varchar(128).

Hope this issue can be resolved soon to enable less savvy users to enable this plugin in their OCS installations.