Plugway / MusicDiskDj

Hello
https://modrinth.com/mod/music-disk-dj
GNU General Public License v3.0
2 stars 0 forks source link

GUI scaling and Dark mode #2

Open MrHarrPrime opened 1 year ago

MrHarrPrime commented 1 year ago

Downloaded the mod, but the GUI doesn't show correctly. It's mostly blank with a few music disks.

Plugway commented 1 year ago

image Does your GUI look like this picture? If yes, you need to insert a link to a video or enter a search query in the field at the top, then click on the Search button. If results don't appear, look at the Search results from: line: YouTube and SoundCloud should be colored - if they aren't, try reconnecting by clicking the button.

If YouTube and SoundCloud are still white, please send minecraft logs after you complete all of the above steps, I will try to figure it out. The log opens in different ways, depending on the launcher, so I can’t offer any advice on that.

MrHarrPrime commented 1 year ago

The GUI looks mostly like the picture, except the only things I can see are the music disks, and I can barely read the names of said music disks. I can't find the search bar, or anything else. So I'm not sure what else to do.

MrHarrPrime commented 1 year ago

I will post a screenshot in a few minutes.

MrHarrPrime commented 1 year ago

2023-11-15_16 02 56 Heres the picture I have.

Plugway commented 1 year ago

Ok, I see the issue. In fact, there are 2 problems here and I need your help with one of them.

  1. Regarding the problem with the interface that does not fit on the screen: I'm using a library that takes GUI scaling into account. In your case, I recommend you reduce the GUI Scale in Video Settings; for me, with a screen resolution of 1920x1080, it is "2". I don't think I can change the way it works. When I made the GUI, I didn’t really think about it and yes, the interface turned out to be a little larger than, for example, the inventory menu.
  2. I expected there might be a problem with the dark theme and, apparently, it’s time to address it. Could you please tell me how you enabled it? Is this a resource pack, a mod, or something in the vanilla settings? I think it will take me a few days to solve this problem. For the time being, you can turn on the light theme as a workaround.
MrHarrPrime commented 1 year ago

Okay, sounds like I'm gonna have to live with the small GUI scale until I can get glasses, lol. As for the Dark Mode issue, yes it's a mod, however, I'm not sure at the moment which mod, I have a lot of them. I will take a look through tomorrow sometime and let you know which mod specifically if that would help. Thanks for your help!

MrHarrPrime commented 1 year ago

Good news! I turned the GUI down and so far everything is working, including Dark Mode!

Plugway commented 1 year ago

Thanks for letting me know! But it seems to me that Dark Mode may still work incorrecly. Search results and disks areas shouldn't be light gray in Dark Mode, which they are because at the moment those colors are always the same, no matter the theme.

I didn't manage to find the mod that may be responsible for Dark Mode, but I found a resource pack that does something similar. I'll try to work with the resource pack to see whether I can find a common solution for such resource packs and mods.

Plugway commented 12 months ago

I tried a lot of things, but couldn't get the dark mode to work properly. However, you can try the 1.0.1 release. Most likely, everything will work fine there in your case. If you have the time, please try it and let me know how it works.