search

Plugway / MusicDiskDj

Hello
https://modrinth.com/mod/music-disk-dj
GNU General Public License v3.0
2 stars 0 forks source link

Linux support #3

Open JeremyStarTM opened 7 months ago

JeremyStarTM commented 7 months ago

The mod tries to use backticks as a seperator, which Linux (and macOS) do not use (they use a slash as a seperator). As a result MusicDiskDj creates folders outside the .minecraft directory.

Please use File.seperator :)

Plugway commented 7 months ago

Unfortunately, this mod only works on Windows. It relies on a yt-dlp executable. A possible solution would be to notify the user to install yt-dlp. This wouldn't take much time if I didn't need to install Linux with a development environment. Given my limited free time, extending support to other systems doesn't seem likely in the near future. If I get around to adding Linux support, I'll fix the separators issue as well.

I will add an OS check so that the mod does not initialize and does not create directories where it shouldn't.

I'm actually sorry that you won't be able to use this mod, but I think it will be possible someday.

JeremyStarTM commented 7 months ago

That's understandable. Maybe I'll create a fork and create PR once I have more time. Maybe I'll learn something about Fabric/MC Modding too (never made a mod before, only plugins).