search

PlumCantaloupe / circlesxr

A work-in-progress framework that aims to bring together multi-user XR experiences in learning using WebXR.
https://www.anthony-scavarelli.com/portfolio/circles-webvr-education-platform/
MIT License
15 stars 31 forks source link

Create shoot the monkey experiment #114

Closed MarkMcGregor-dev closed 3 years ago

MarkMcGregor-dev commented 3 years ago

This PR relates to the 3rd kinematics experiment, 'shooting the monkey', which demonstrates a bullet and a monkey falling at the same rate despite very different horizontal velocities.

PlumCantaloupe commented 3 years ago

Added small change to explore view so that this world is also present in the list of worlds.

TomasBabkine-DiCaprio commented 3 years ago

@PlumCantaloupe.

Mark, Carly and I added finishing touches to the experiments! This should be good to go once you've reviewed it.

Let me know if you run into issues or bugs! :)

PlumCantaloupe commented 3 years ago

Looks great! I like how you re-organized the hub and everything looks to work well now. The whiteboards are also a nice touch.

I will go ahead and merge this so we can get some feedback from the physics Prof. The only minor issues I noticed were that the shoot-and-drop worlds don't seem to show the same floor hit times when using higher gravitys. It would be nice to add some circles-sound and perhaps some circles-artefacts to help increase immersion, and lend more context and information around the purpose of the experiments. However, this is something that may be clearer after Prof. feedback.

Also, there is still a geometry.fromBuffer error on the monkey world. It doesn't seem to affect anything but just a FYI.

Good work!

P.S. watch the naming convention. Soem OS's don't differentiate between uppercase and lower-case filetype suffices; but Linux does and will not find a file named "monkeyShootImage.PNG" if you point to "monkeyShootImage.png". I will stick with lower-case ;)