Closed ozziexsh closed 4 years ago
Merging #7 into master will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
+ Coverage 74.28% 74.29% +0.01%
==========================================
Files 55 55
Lines 1598 1599 +1
==========================================
+ Hits 1187 1188 +1
Misses 411 411
Impacted Files | Coverage Δ | |
---|---|---|
src/IO/StreamSocket.php | 64.81% <100.00%> (+0.32%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ecb5a7e...644bd6a. Read the comment docs.
This configuration setting has a default value of
"null"
(string) but is being compared againstnull
(literal)I opted for the least invasive fix as without knowing the codebase I'm guessing that changing the default could have unwanted side effects
This caused me errors when trying to connect, something along the lines of "failed to parse address null" when running this function here because "context" was set to the string literal "null"