Missing date/id in atom feed

agateblue commented 4 years ago

Based on my research, entries included the Atom feed generated by Plume doesn't include any atom:id and atom:published elements.

While published is optional, atom:id looks mandatory in the specification and its absence is likely to confuse feed readers.

In a personal projects of mine, I am aggregating multiple Plume feeds, and the absence of the published value means it's impossible to order the entries by date after aggregation.

Example from https://plume.social/@/Aster@amplifi.casa:


<feed xmlns="http://www.w3.org/2005/Atom">
    <title>Aster</title>
    <id>https://plume.social/@/Aster@amplifi.casa/atom.xml</id>
    <updated></updated>
    <entry>
        <title><![CDATA[Eu também ignorei essas coisas no começo]]></title>
        <id></id>
        <updated></updated>
        <author>
            <name>Aster</name>
            <uri>https://amplifi.casa/@/Aster/</uri>
        </author>
        <link href="https://amplifi.casa/~/Asterismos/eu-também-ignorei-essas-coisas-no-começo/" rel="alternate"/>
        <content type="html" src="https://amplifi.casa/~/Asterismos/eu-também-ignorei-essas-coisas-no-começo/">REMOVED</content>
    </entry>
</feed>

As you can see:

id is empty
updated is empty
published is missing

THere are probably a few more fields that are available in the spec you may want to include, like summary, rights or category (to indicate what blog the entry is coming from?)

papey commented 4 years ago

Hi everyone, i want to work on this issue. Is this function the good place to start ? Thanks !

elegaanz commented 4 years ago

(sorry, for the delay) Yes it is, and there is a similar one in src/routes/blogs.rs IIRC.

Kekun commented 4 years ago

This is very likely why I can't have my new fediverse.blog blog on Planet GNOME: https://gitlab.gnome.org/Infrastructure/planet-web/merge_requests/32.

papey commented 4 years ago

The issue is partially fixed by the now merged PR #720.

Currently, there is no data structure to fetch updated status for a blog post. This issue is, for now, blocked by #722.

agateblue commented 4 years ago

thank you for your work on this @papey, I'm going to try it soon on https://blog.funkwhale.audio!

papey commented 4 years ago

@KitaitiMakoto after your work on #764, do you think there is something more to do to resolve this issue ?

KitaitiMakoto commented 4 years ago

@papey Thank you for mension. No, there's nothing to work with this issue although still some validation errors remains.

Plume-org / Plume

Missing date/id in atom feed #673