robertlipe
commented
1 year ago Looking at particlesUpdate2, it's not leaving height for the VU meter when clamping PosY.
The original code didn't have the meter and had the Y axis swapped, so I battled a lot of stuff like that.
If changing PosY[i] < 0 to PosY[i] < 1 doesn't cure it, I'll look at it tonight or tomorrow.
If that does fix it, consider this my LGTM on the review. :-)
I later learned there's some method for deciding if there's a VU displayed or not, so maybe making a method call on every frame draw (don't care if it changes mid-draw) wouldn't be terrible. Or just give up the pixel on the premise that most people can't find which button on the remote it is that toggles it. Most of these do.
RJL
On Tue, Sep 26, 2023 at 9:51 PM David W Plummer @.***> wrote:
I assume this effect moves stuff on the screen, and for some reason remnants of the VU meter are getting copied to the bottom line of the matrix. It might be walking one line more than it needs to.
— Reply to this email directly, view it on GitHub https://github.com/PlummersSoftwareLLC/NightDriverStrip/issues/446, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSD354CLPUUPKT35C4QVTX4OIENANCNFSM6AAAAAA5IUM4AA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
I assume this effect moves stuff on the screen, and for some reason remnants of the VU meter are getting copied to the bottom line of the matrix. It might be walking one line more than it needs to.