PlummersSoftwareLLC / NightDriverStrip

NightDriver client for ESP32
https://plummerssoftwarellc.github.io/NightDriverStrip/
GNU General Public License v3.0
1.29k stars 210 forks source link

Add warning suppressions for external libraries in 'pio check'. #623

Closed robertlipe closed 2 months ago

robertlipe commented 2 months ago

Fixes #622.

Description

Contributing requirements

rbergen commented 2 months ago

@robertlipe Thanks for submitting this! I've taken the liberty of updating the description to link and close issue #622.

robertlipe commented 2 months ago

Awesome, thanks!

I'll enhance the std::accumulate thing that it's whining about when I next have some time. is a gold mine of easy readability/perf tweaks! Shame that the one it finds isn't someplace awesome like the per-frame LED move. It's someplace super boring like the checksum in Improv, IIRC.

BTW, I've confirmed we can build at least demo, my hopped up S3 build, and mesmerizer fine with the new GCC 13 in the latest IDF (I made some tweaks a few months ago to prepare for that...) though I've not actually run any of the binaries. Lots and lots of new warnings, though.

Just wanted to show signs of life on the project. I've done 20% of a bunch of projects instead of getting anything interesting over the line.

Later, RJL

On Thu, Apr 25, 2024 at 4:09 AM Rutger van Bergen @.***> wrote:

Merged #623 https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/623 into main.

— Reply to this email directly, view it on GitHub https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/623#event-12604772034, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSD34ZPMAHNPLFFS2E53DY7DB3DAVCNFSM6AAAAABGSYQRYSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGYYDINZXGIYDGNA . You are receiving this because you were mentioned.Message ID: <PlummersSoftwareLLC/NightDriverStrip/pull/623/issue_event/12604772034@ github.com>